RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-25 12:12:47 +01:00
Code Issues Projects Releases Wiki Activity

[Verifier] Use isIntrinsic() (NFC)

Browse Source 
Call Function::isIntrinsic() instead of manually checking the
function name for an "llvm." prefix.
This commit is contained in:
Nikita Popov 2021-07-15 20:27:52 +02:00
parent d5316f9a80
commit ff55ad2c7b
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/IR/Verifier.cpp
View File

@ -2326,11 +2326,10 @@ void Verifier::visitFunction(const Function &F) {
Assert(verifyAttributeCount(Attrs, FT->getNumParams()),
"Attribute after last parameter!", &F);
bool isLLVMdotName = F.getName().size() >= 5 &&
F.getName().substr(0, 5) == "llvm.";
bool IsIntrinsic = F.isIntrinsic();
// Check function attributes.
verifyFunctionAttrs(FT, Attrs, &F, isLLVMdotName);
verifyFunctionAttrs(FT, Attrs, &F, IsIntrinsic);
// On function declarations/definitions, we do not support the builtin
// attribute. We do not check this in VerifyFunctionAttrs since that is
@ -2407,7 +2406,7 @@ void Verifier::visitFunction(const Function &F) {
FT->getParamType(i));
Assert(Arg.getType()->isFirstClassType(),
"Function arguments must have first-class types!", &Arg);
if (!isLLVMdotName) {
if (!IsIntrinsic) {
Assert(!Arg.getType()->isMetadataTy(),
"Function takes metadata but isn't an intrinsic", &Arg, &F);
Assert(!Arg.getType()->isTokenTy(),
@ -2423,7 +2422,7 @@ void Verifier::visitFunction(const Function &F) {
++i;
}
if (!isLLVMdotName) {
if (!IsIntrinsic) {
Assert(!F.getReturnType()->isTokenTy(),
"Function returns a token but isn't an intrinsic", &F);
Assert(!F.getReturnType()->isX86_AMXTy(),
@ -2467,7 +2466,7 @@ void Verifier::visitFunction(const Function &F) {
} else {
// Verify that this function (which has a body) is not named "llvm.*". It
// is not legal to define intrinsics.
Assert(!isLLVMdotName, "llvm intrinsics cannot be defined!", &F);
Assert(!IsIntrinsic, "llvm intrinsics cannot be defined!", &F);
// Check the entry node
const BasicBlock *Entry = &F.getEntryBlock();
@ -3066,7 +3065,7 @@ void Verifier::visitCallBase(CallBase &Call) {
"Attribute after last parameter!", Call);
bool IsIntrinsic = Call.getCalledFunction() &&
Call.getCalledFunction()->getName().startswith("llvm.");
Call.getCalledFunction()->isIntrinsic();
Function *Callee =
dyn_cast<Function>(Call.getCalledOperand()->stripPointerCasts());