RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-22 12:33:33 +02:00
Code Issues Projects Releases Wiki Activity
76,472 Commits 4 Branches 5 Tags 704 MiB
6698bae640
Commit Graph

8376 Commits

Author SHA1 Message Date
Andrew Trick
c60e2addd9 LSR should avoid redundant edge splitting. 
This handles the case in which LSR rewrites an IV user that is a phi and
splits critical edges originating from a switch.
Fixes <rdar://problem/6453893> LSR is not splitting edges "nicely"

llvm-svn: 141059
 2011-10-04 03:50:44 +00:00
Andrew Trick
94d203b172 whitespace 
llvm-svn: 141058
 2011-10-04 03:34:49 +00:00
Nick Lewycky
7cd1bfb89d Add a new icmp+select optz'n. Also shows off the load(cst) folding added in 
r140966.

llvm-svn: 140969
 2011-10-02 10:37:37 +00:00
Nick Lewycky
3282ef025d Enhance a couple places where we were doing constant folding of instructions, 
but not load instructions. Noticed by inspection.

llvm-svn: 140966
 2011-10-02 09:12:55 +00:00
Andrew Trick
0489c5410d Inlining and unrolling heuristics should be aware of free truncs. 
We want heuristics to be based on accurate data, but more importantly
we don't want llvm to behave randomly. A benign trunc inserted by an
upstream pass should not cause a wild swings in optimization
level. See PR11034. It's a general problem with threshold-based
heuristics, but we can make it less bad.

llvm-svn: 140919
 2011-10-01 01:39:05 +00:00
Andrew Trick
a1161d94f5 whitespace 
llvm-svn: 140916
 2011-10-01 01:27:56 +00:00
Jim Grosbach
96af96b83d Don't modify constant in-place. 
llvm-svn: 140875
 2011-09-30 19:58:46 +00:00
Jim Grosbach
d35eaaeb6e float comparison to double 'zero' constant can just be a float 'zero.' 
InstCombine was incorrectly considering the conversion of the constant
zero to be unsafe.

We want to transform:
define float @bar(float %x) nounwind readnone optsize ssp {
  %conv = fpext float %x to double
  %cmp = fcmp olt double %conv, 0.000000e+00
  %conv1 = zext i1 %cmp to i32
  %conv2 = sitofp i32 %conv1 to float
  ret float %conv2
}

Into:
define float @bar(float %x) nounwind readnone optsize ssp {
  %cmp = fcmp olt float %x, 0.000000e+00   ; <---- This
  %conv1 = zext i1 %cmp to i32
  %conv2 = sitofp i32 %conv1 to float
  ret float %conv2
}


rdar://10215914

llvm-svn: 140869
 2011-09-30 18:45:50 +00:00
Jim Grosbach
651c847dc5 Tidy up. Trailing whitespace. 
llvm-svn: 140865
 2011-09-30 18:09:53 +00:00
Duncan Sands
b4c8b2d9fa Inlining often produces landingpad instructions with repeated 
catch or repeated filter clauses.  Teach instcombine a bunch
of tricks for simplifying landingpad clauses.  Currently the
code only recognizes the GNU C++ and Ada personality functions,
but that doesn't stop it doing a bunch of "generic" transforms
which are hopefully fine for any real-world personality function.
If these "generic" transforms turn out not to be generic, they
can always be conditioned on the personality function.  Probably
someone should add the ObjC++ personality function.  I didn't as
I don't know anything about it.

llvm-svn: 140852
 2011-09-30 13:12:16 +00:00
Nick Lewycky
fc476a3d3f Fold two identical set lookups into one. No functionality change. 
llvm-svn: 140821
 2011-09-29 23:40:12 +00:00
Dan Gohman
7dca165e93 When eliminating unnecessary retain+autorelease on return values, 
handle the case where the retain is in a different basic block.
rdar://10210274.

llvm-svn: 140815
 2011-09-29 22:27:34 +00:00
Dan Gohman
2df048a94b Don't eliminate objc_retainBlock calls on stack objects if the 
objc_retainBlock call is potentially responsible for copying
the block to the heap to extend its lifetime. rdar://10209613.

llvm-svn: 140814
 2011-09-29 22:25:23 +00:00
Eli Friedman
ac33381aa1 Clean up uses of switch instructions so they are not dependent on the operand ordering. Patch by Stepan Dyatkovskiy. 
llvm-svn: 140803
 2011-09-29 20:21:17 +00:00
Andrew Trick
fa2c108a22 typo + pasto 
llvm-svn: 140769
 2011-09-29 01:53:08 +00:00
Andrew Trick
e1d5ae73ac LSR: rewrite inner loops only. 
Rewriting the entire loop nest now requires -enable-lsr-nested.
See PR11035 for some performance data.
A few unit tests specifically test nested LSR, and are now under a flag.

llvm-svn: 140762
 2011-09-29 01:33:38 +00:00
Andrew Trick
97b40d3aff indvars should hoist [sz]ext because licm is not rerun. 
llvm-svn: 140670
 2011-09-28 01:35:36 +00:00
Benjamin Kramer
355b353595 Stop emitting instructions with the name "tmp" they eat up memory and have to be uniqued, without any benefit. 
If someone prefers %tmp42 to %42, run instnamer.

llvm-svn: 140634
 2011-09-27 20:39:19 +00:00
Bill Wendling
589336d854 Split the landing pad basic block with the correct function. Also merge the 
split landingpad instructions into a PHI node.
PR11016

llvm-svn: 140592
 2011-09-27 00:59:31 +00:00
Andrew Trick
eb2bea7d4a Disable LSR retry by default. 
Disabling aggressive LSR saves compilation time, and with the new
indvars behavior usually improves performance.

llvm-svn: 140590
 2011-09-27 00:44:14 +00:00
Andrew Trick
9a82406730 LSR, one of the new Cost::isLoser() checks did not get merged in the previous checkin. 
llvm-svn: 140583
 2011-09-26 23:35:25 +00:00
Andrew Trick
4dfc60fab6 LSR cost metric minor fix and verification. 
The minor bug heuristic was noticed by inspection. I added the
isLoser/isValid helpers because they will become more
important with subsequent checkins.

llvm-svn: 140580
 2011-09-26 23:11:04 +00:00
Andrew Trick
3540419340 LSR minor bug fix in RateRegister. 
No test case. Noticed by inspection and I doubt it ever affects the
outcome of the overall heuristic, let alone final codegen.

llvm-svn: 140431
 2011-09-23 23:05:19 +00:00
Eli Friedman
6e15091fc6 PR10987: add a missed safety check to isSafePHIToSpeculate in scalarrepl. 
llvm-svn: 140327
 2011-09-22 18:56:30 +00:00
Eli Friedman
2599a202e2 Make sure IPSCCP never marks a tracked call as overdefined in SCCPSolver::ResolvedUndefsIn. If we do, we can end up in a situation where a function is resolved to return a constant, but the caller is marked overdefined, which confuses the code later. 
<rdar://problem/9956541> (again).

llvm-svn: 140210
 2011-09-20 23:28:51 +00:00
Bill Wendling
32444d6a28 Relax this condition. 
Some passes require breaking critical edges before they're called. Don't
segfault because of that.

llvm-svn: 140196
 2011-09-20 22:28:17 +00:00
Bill Wendling
5860a42997 Place the check for an exit landing pad where it will be run on both code paths through the if-then-else. 
llvm-svn: 140195
 2011-09-20 22:27:16 +00:00
Bill Wendling
9e1900bcf7 Omit extracting a loop if one of the exits is a landing pad. 
The landing pad must accompany the invoke when it's extracted. However, if it
does, then the loop isn't properly extracted. I.e., the resulting extraction has
a loop in it. The extracted function is then extracted, etc. resulting in an
infinite loop.

llvm-svn: 140193
 2011-09-20 22:23:09 +00:00
Bill Wendling
cf8d277150 Check the terminator, not the basic block. 
llvm-svn: 140176
 2011-09-20 20:20:50 +00:00
Bill Wendling
1ac89f2739 When extracting a basic block that ends in an 'invoke' instruction, we need to 
extract its associated landing pad block as well. However, that landing pad
block may have more than one predecessor. So split the landing pad block so that
individual landing pads have only one predecessor.

This type of transformation may produce a false positive with bugpoint.

llvm-svn: 140173
 2011-09-20 19:10:24 +00:00
Bill Wendling
66d2eeb730 Use ArrayRef instead of an explicit 'const std::vector &'. 
llvm-svn: 140172
 2011-09-20 19:05:04 +00:00
Devang Patel
76e4b3cba8 If simple ownership works then friendship is not required. 
llvm-svn: 140169
 2011-09-20 18:48:56 +00:00
Bill Wendling
8a13959e3a Use ArrayRef instead of 'const std::vector' to pass around the list of basic blocks to extract. 
llvm-svn: 140168
 2011-09-20 18:42:07 +00:00
Devang Patel
5332ddba93 Update GCOVLines to provide interfaces to write line table and calculate complete length. 
llvm-svn: 140167
 2011-09-20 18:35:00 +00:00
Bill Wendling
2de4e5096d Fix comments. 
llvm-svn: 140164
 2011-09-20 18:24:46 +00:00
Devang Patel
06d7cd5b4e Update comment. 
llvm-svn: 140156
 2011-09-20 18:05:45 +00:00
Devang Patel
65d142a389 Use StringRef instead of std::string. 
llvm-svn: 140154
 2011-09-20 17:55:19 +00:00
Devang Patel
cb1e53c7ba Eliminate unnecessary copy of FileName from GCOVLines. 
GCOVLines is always accessed through a StringMap where the key is FileName.

llvm-svn: 140151
 2011-09-20 17:43:14 +00:00
Devang Patel
525663a8b3 There is no need to write a local utility routine to find subprogram info if the utility routine is already available in DebugInfo. 
llvm-svn: 140145
 2011-09-20 15:57:19 +00:00
Bill Wendling
a5db9cbefd Revert r140083 and r140084 until buildbots can be fixed. 
llvm-svn: 140094
 2011-09-19 23:30:41 +00:00
Bill Wendling
d19fa57b91 If we are extracting a basic block that ends in an invoke call, we must also 
extract the landing pad block. Otherwise, there will be a situation where the
invoke's unwind edge lands on a non-landing pad.

We also forbid the user from extracting the landing pad block by itself. Again,
this is not a valid transformation.

llvm-svn: 140083
 2011-09-19 23:00:52 +00:00
Eli Friedman
9ed4ecaf4b Fix an infinite loop where a transform in InstCombiner::visitAnd claims a construct is changed when it is not. (See included testcase.) 
Patch by Xiaoyi Guo.

llvm-svn: 140072
 2011-09-19 21:58:15 +00:00
Andrew Trick
856edc0ef5 [indvars] Fix PR10946: SCEV cannot handle Vector IVs. 
llvm-svn: 140026
 2011-09-19 17:54:39 +00:00
Andrew Trick
1dfb51c692 Reapply r139759. Disable IV rewriting by default. See PR10916. 
llvm-svn: 139842
 2011-09-15 20:58:37 +00:00
Eli Friedman
2109f34467 Make demanded-elt simplification for shufflevector slightly stronger. Spotted by inspection. 
llvm-svn: 139768
 2011-09-15 01:14:29 +00:00
Dan Gohman
f4d52b917e Don't mark objc_retainBlock as nounwind. It calls user copy constructors 
which could theoretically throw.

llvm-svn: 139710
 2011-09-14 18:33:34 +00:00
Dan Gohman
223fdfc56f objc_retainBlock is not NoModRef because it can update forwarding pointers 
in memory relevant to the optimizer. rdar://10050579.

llvm-svn: 139708
 2011-09-14 18:13:00 +00:00
Andrew Trick
2e22ddc364 [indvars] Revert r139579 until 401.bzip -arch i386 miscompilation is fixed. PR10920. 
llvm-svn: 139583
 2011-09-13 05:23:49 +00:00
Andrew Trick
2bfa2824c6 Disable IV rewriting by default. See PR10916. 
llvm-svn: 139579
 2011-09-13 03:23:21 +00:00
Andrew Trick
2cc8637af2 [indvars] Fix bugs in floating point IV range checks noticed by inspection. 
llvm-svn: 139574
 2011-09-13 01:59:32 +00:00