RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-01 00:12:50 +01:00
Code Issues Projects Releases Wiki Activity
65,119 Commits 4 Branches 5 Tags 704 MiB
8e70968a13
Commit Graph

153 Commits

Author SHA1 Message Date
Owen Anderson
8e70968a13 Fix PR8247: JumpThreading can cause a block to become unreachable while still having predecessor, if it is part of a self-loop. 
Because of this, we cannot use the Simplify* APIs, as they can assert-fail on unreachable code.  Since it's not easy to determine
if a given threading will cause a block to become unreachable, simply defer simplifying simplification to later InstCombine and/or
DCE passes.

llvm-svn: 115082
 2010-09-29 20:34:41 +00:00
Owen Anderson
9f8f48f221 Remove the option to disable LazyValueInfo in JumpThreading, as it is now 
on by default and has received significant testing.

llvm-svn: 113852
 2010-09-14 20:57:41 +00:00
Chris Lattner
41d0913a1d Change lower atomic pass to use IntrinsicInst to simplify it a bit. 
llvm-svn: 113114
 2010-09-05 20:10:47 +00:00
Chris Lattner
fc6bf7cb34 eliminate some non-obvious casts. UndefValue isa Constant. 
llvm-svn: 113113
 2010-09-05 20:03:09 +00:00
Duncan Sands
a95548a8d2 Reapply commit 112699, speculatively reverted by echristo, since 
I'm sure it is harmless.  Original commit message:
If PrototypeValue is erased in the middle of using the SSAUpdator
then the SSAUpdator may access freed memory.  Instead, simply pass
in the type and name explicitly, which is all that was used anyway.

llvm-svn: 112810
 2010-09-02 08:14:03 +00:00
Owen Anderson
e036dd5b0b JumpThreading keeps LazyValueInfo up to date, so we don't need to rerun it 
if we schedule another LVI-using pass afterwards.

llvm-svn: 112722
 2010-09-01 18:27:22 +00:00
Eric Christopher
f72b7040a2 Speculatively revert 112699 and 112702, they seem to be causing 
self host errors on clang-x86-64.

llvm-svn: 112719
 2010-09-01 17:29:10 +00:00
Duncan Sands
f7e2f45e1a If PrototypeValue is erased in the middle of using the SSAUpdator 
then the SSAUpdator may access freed memory.  Instead, simply pass
in the type and name explicitly, which is all that was used anyway.

llvm-svn: 112699
 2010-09-01 10:29:33 +00:00
Owen Anderson
233463074b More cleanups of my JumpThreading transforms, including extracting some duplicated code into a helper function. 
llvm-svn: 112634
 2010-08-31 20:26:04 +00:00
Owen Anderson
66b51ff843 Add an RAII helper to make cleanup of the RecursionSet more fool-proof. 
llvm-svn: 112628
 2010-08-31 19:24:27 +00:00
Owen Anderson
e2b5bd3a7f Refactor my fix for PR5652 to terminate the predecessor lookups after the first failure. 
llvm-svn: 112620
 2010-08-31 18:48:48 +00:00
Owen Anderson
ba28fe3dcb More Chris-inspired JumpThreading fixes: use ConstantExpr to correctly constant-fold undef, and be more careful with its return value. 
This actually exposed an infinite recursion bug in ComputeValueKnownInPredecessors which theoretically already existed (in JumpThreading's
handling of and/or of i1's), but never manifested before.  This patch adds a tracking set to prevent this case.

llvm-svn: 112589
 2010-08-31 07:36:34 +00:00
Owen Anderson
af33f22b40 Re-apply r112539, being more careful to respect the return values of the constant folding methods. Additionally, 
use the ConstantExpr::get*() methods to simplify some constant folding.

llvm-svn: 112550
 2010-08-30 23:22:36 +00:00
Owen Anderson
9d301e20e8 Revert r112539. It accidentally introduced a miscompilation. 
llvm-svn: 112543
 2010-08-30 22:33:41 +00:00
Owen Anderson
479c0c406f Fixes and cleanups pointed out by Chris. In general, be careful to handle 0 results from ComputeValueKnownInPredecessors 
(indicating undef), and re-use existing constant folding APIs.

llvm-svn: 112539
 2010-08-30 22:07:52 +00:00
Owen Anderson
a1a80a3acd Fix typos in comments. 
llvm-svn: 112286
 2010-08-27 20:32:56 +00:00
Owen Anderson
35ff7a208e Use LVI to eliminate conditional branches where we've tested a related condition previously. Update tests for this change. 
This fixes PR5652.

llvm-svn: 112270
 2010-08-27 17:12:29 +00:00
Owen Anderson
77fcf53657 Make JumpThreading smart enough to properly thread StrSwitch when it's compiled with clang++. 
llvm-svn: 112198
 2010-08-26 17:40:24 +00:00
Owen Anderson
a4d73e6be9 Turn LVI on, previously detected failures should be fixed now. 
llvm-svn: 111923
 2010-08-24 17:21:18 +00:00
Owen Anderson
9f7621fa94 Turn LVI back off, I have a testcase now. 
llvm-svn: 111834
 2010-08-23 19:59:27 +00:00
Owen Anderson
ee69c0112d Re-enable LazyValueInfo. Monitoring for failures. 
llvm-svn: 111816
 2010-08-23 18:12:23 +00:00
Owen Anderson
e22f313e44 Disable LVI while I evaluate a failure. 
llvm-svn: 111551
 2010-08-19 19:47:08 +00:00
Owen Anderson
9de85fb6c0 Tentatively enabled LVI by default. I'll be monitoring for any failures. 
llvm-svn: 111543
 2010-08-19 19:04:40 +00:00
Owen Anderson
65795241db Inform LazyValueInfo whenever a block is deleted, to avoid dangling pointer issues. 
llvm-svn: 111382
 2010-08-18 18:39:01 +00:00
Chris Lattner
ab876b6ce8 Fix PR7755: knowing something about an inval for a pred 
from the LHS should disable reconsidering that pred on the
RHS.  However, knowing something about the pred on the RHS
shouldn't disable subsequent additions on the RHS from
happening.

llvm-svn: 111349
 2010-08-18 03:14:36 +00:00
Owen Anderson
f2fea95f2f Reapply r110396, with fixes to appease the Linux buildbot gods. 
llvm-svn: 110460
 2010-08-06 18:33:48 +00:00
Owen Anderson
aadd8a89ca Revert r110396 to fix buildbots. 
llvm-svn: 110410
 2010-08-06 00:23:35 +00:00
Owen Anderson
b9762c07cb Don't use PassInfo* as a type identifier for passes. Instead, use the address of the static 
ID member as the sole unique type identifier.  Clean up APIs related to this change.

llvm-svn: 110396
 2010-08-05 23:42:04 +00:00
Owen Anderson
bbeb4e2e58 Give JumpThreading+LVI a long-form cl::opt so that it's easier to toggle the default. 
llvm-svn: 110384
 2010-08-05 22:11:31 +00:00
Owen Anderson
12ab6162bf Add an initial implementation of LazyValueInfo updating for JumpThreading. Disabled for now. 
llvm-svn: 109424
 2010-07-26 18:48:03 +00:00
Owen Anderson
f8addbb0a1 Fix batch of converting RegisterPass<> to INTIALIZE_PASS(). 
llvm-svn: 109045
 2010-07-21 22:09:45 +00:00
Gabor Greif
8159329bfb cache results of operator* 
llvm-svn: 108142
 2010-07-12 14:10:24 +00:00
Chris Lattner
baef771d17 if jump threading is able to infer interesting values on both 
the LHS and RHS of an and/or instruction, don't multiply add
known predecessor values.  This fixes the crash on testcase
from PR7498

llvm-svn: 108114
 2010-07-12 00:47:34 +00:00
Chris Lattner
88d51b0f4c jump threading can't split a critical edge from an indirectbr. This 
fixes PR7356.

llvm-svn: 105950
 2010-06-14 19:45:43 +00:00
Dan Gohman
0d7d3faf8e Move FindAvailableLoadedValue isSafeToLoadUnconditionally out of 
lib/Transforms/Utils and into lib/Analysis so that Analysis passes
can use them.

llvm-svn: 104949
 2010-05-28 16:19:17 +00:00
Chris Lattner
92b4e858d0 fix PR6743, a case where we'd delete an instruction before using it 
in some cases.

llvm-svn: 100937
 2010-04-10 18:26:57 +00:00
Duncan Sands
1b33dd3c83 There are two ways of checking for a given type, for example isa<PointerType>(T) 
and T->isPointerTy().  Convert most instances of the first form to the second form.
Requested by Chris.

llvm-svn: 96344
 2010-02-16 11:11:14 +00:00
Duncan Sands
2acaf3609c Uniformize the names of type predicates: rather than having isFloatTy and 
isInteger, we now have isFloatTy and isIntegerTy.  Requested by Chris!

llvm-svn: 96223
 2010-02-15 16:12:20 +00:00
Chris Lattner
733ffcdb1f Make jump threading honor x|undef -> true and x&undef -> false, 
instead of considering x|undef -> x, which may not be true.

llvm-svn: 95850
 2010-02-11 04:40:44 +00:00
Chris Lattner
b444bc0234 third bug from PR6119: the xor dupe extension allows 
for arbitrary terminators in predecessors, don't assume
it is a conditional or uncond branch.  The testcase shows
an example where they can happen with switches.

llvm-svn: 94323
 2010-01-23 19:21:31 +00:00
Chris Lattner
7130788ea2 add an early out to ProcessBranchOnXOR to speed it up, 
handle the case when we can infer an input to the xor
from all inputs that agree, instead of going into an
infinite loop.  Another part of PR6199

llvm-svn: 94321
 2010-01-23 19:16:25 +00:00
Chris Lattner
e4391a1adb fix a crash in jump threading, PR6119 
llvm-svn: 94319
 2010-01-23 18:56:07 +00:00
Chris Lattner
21bbaf49d5 1) Use the new SimplifyInstructionsInBlock routine instead of the copy 
in JT.

2) When cloning blocks for PHI or xor conditions, use
instsimplify to simplify the code as we go.  This allows us to 
squish common cases early in JT which opens up opportunities for
subsequent iterations, and allows it to completely simplify the
testcase.

llvm-svn: 93253
 2010-01-12 20:41:47 +00:00
Chris Lattner
bc0016437d tidy up 
llvm-svn: 93222
 2010-01-12 02:07:50 +00:00
Chris Lattner
774e3967ad Teach jump threading to duplicate small blocks when the branch 
condition is a xor with a phi node.  This eliminates nonsense
like this from 176.gcc in several places:

 LBB166_84:
        testl   %eax, %eax
-       setne   %al
-       xorb    %cl, %al
-       notb    %al
-       testb   $1, %al
-       je      LBB166_85
+       je      LBB166_69
+       jmp     LBB166_85

This is rdar://7391699

llvm-svn: 93221
 2010-01-12 02:07:17 +00:00
Chris Lattner
d6d8cc7b37 some cleanup, and make it obvious that ProcessJumpOnPHI only works 
on branches by renaming it and checking for a branch at the call site.

llvm-svn: 93208
 2010-01-11 23:41:09 +00:00
Benjamin Kramer
df696ee6b4 Use a do-while loop instead of while + boolean. 
llvm-svn: 92912
 2010-01-07 13:50:07 +00:00
David Greene
0a35321dc2 Change errs() to dbgs(). 
llvm-svn: 92614
 2010-01-05 01:27:19 +00:00
Chris Lattner
6dd4686b48 Metadata.h doesn't need to include ValueHandle.h anymore. 
llvm-svn: 92211
 2009-12-28 08:20:46 +00:00
Chris Lattner
7066a138ff fix PR5698 
llvm-svn: 90708
 2009-12-06 17:17:23 +00:00