RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-22 04:22:57 +02:00
Code Issues Projects Releases Wiki Activity
127,183 Commits 4 Branches 5 Tags 704 MiB
9569b015d4
Commit Graph

13 Commits

Author SHA1 Message Date
Derek Schuff
6203009638 Fix testing for end of stream in bitstream reader. 
This fixes a bug found while working on the bitcode reader. In
particular, the method BitstreamReader::AtEndOfStream doesn't always
behave correctly when processing a data streamer. The method
fillCurWord doesn't properly set CurWord/BitsInCurWord if the data
streamer was already at eof, but GetBytes had not yet set the
ObjectSize field of the streaming memory object.

This patch fixes this problem, and provides a test to show that
this problem has been fixed.

Patch by Karl Schimpf.

Differential Revision: http://reviews.llvm.org/D11391

llvm-svn: 243890
 2015-08-03 18:01:50 +00:00
Alexander Kornienko
f993659b8f Revert r240137 (Fixed/added namespace ending comments using clang-tidy. NFC) 
Apparently, the style needs to be agreed upon first.

llvm-svn: 240390
 2015-06-23 09:49:53 +00:00
Alexander Kornienko
40cb19d802 Fixed/added namespace ending comments using clang-tidy. NFC 
The patch is generated using this command:

tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py -fix \
  -checks=-*,llvm-namespace-comment -header-filter='llvm/.*|clang/.*' \
  llvm/lib/


Thanks to Eugene Kosov for the original patch!

llvm-svn: 240137
 2015-06-19 15:57:42 +00:00
Rafael Espindola
ac851b9af7 Use std::unique_ptr to manage the DataStreamer in bitcode parsing. 
We were already deleting it, this just makes it explicit.

llvm-svn: 239867
 2015-06-16 23:29:49 +00:00
Derek Schuff
435b70a5c0 Fix StreamingMemoryObject to respect known object size. 
The existing code for method StreamingMemoryObject.fetchToPos does not respect
the corresonding call to setKnownObjectSize(). As a result, it allows the
StreamingMemoryObject to read bytes past the object size.

This patch provides a test case, and code to fix the problem.

Patch by Karl Schimpf
Differential Revision: http://reviews.llvm.org/D8931

llvm-svn: 237939
 2015-05-21 19:40:19 +00:00
Filipe Cabecinhas
9fd1becc70 Change a reachable unreachable to a fatal error. 
Summary:
Also tagged a FIXME comment, and added information about why it breaks.

Bug found using AFL fuzz.

Reviewers: rafael, craig.topper

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D9729

llvm-svn: 237709
 2015-05-19 18:18:10 +00:00
Benjamin Kramer
45a545b9c6 Purge unused includes throughout libSupport. 
NFC.

llvm-svn: 232976
 2015-03-23 18:07:13 +00:00
Aaron Ballman
0b45511a2e Removing LLVM_DELETED_FUNCTION, as MSVC 2012 was the last reason for requiring the macro. NFC; LLVM edition. 
llvm-svn: 229340
 2015-02-15 22:54:22 +00:00
Rafael Espindola
d121845dcd Fix a silly bug in StreamingMemoryObject.cpp. 
The logic for detecting EOF was wrong and would fail if we ever requested
more than 16k past the last read position.

llvm-svn: 222505
 2014-11-21 05:15:41 +00:00
Rafael Espindola
ad6b4ce7dc Read 64 bits at a time in the bitcode reader. 
The reading of 64 bit values could still be optimized, but at least this cuts
down on the number of virtual calls to fetch more data.

llvm-svn: 221865
 2014-11-13 07:23:22 +00:00
Rafael Espindola
290c50c9e5 Use the return of readBytes to find out if we are at the end of the stream. 
This allows the removal of isObjectEnd and opens the way for reading 64 bits
at a time.

llvm-svn: 221804
 2014-11-12 18:37:00 +00:00
Rafael Espindola
9b65f4ede9 Return the number of read bytes in MemoryObject::readBytes. 
Returning more information will allow BitstreamReader to be simplified a bit
and changed to read 64 bits at a time.

llvm-svn: 221794
 2014-11-12 17:11:16 +00:00
Rafael Espindola
ed6949a6a7 Merge StreamableMemoryObject into MemoryObject. 
Every MemoryObject is a StreamableMemoryObject since the removal of
StringRefMemoryObject, so just merge the two.

I will clean up the MemoryObject interface in the upcoming commits.

llvm-svn: 221766
 2014-11-12 03:55:46 +00:00