RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-28 22:42:52 +01:00
Code Issues Projects Releases Wiki Activity
37,716 Commits 4 Branches 5 Tags 704 MiB
c9c6d88ee5
Commit Graph

898 Commits

Author SHA1 Message Date
Bill Wendling
7d054f8b3f The inst combining of inttoptr into GEP with one index was using the bit size of 
the type instead of the byte size. This was causing troublesome mis-compilations.

True to form, this took 2 days to find and is a one-line fix. :-P

llvm-svn: 48354
 2008-03-14 05:12:19 +00:00
Chris Lattner
7925cc72c0 Reimplement the parameter attributes support, phase #1. hilights: 
1. There is now a "PAListPtr" class, which is a smart pointer around
   the underlying uniqued parameter attribute list object, and manages
   its refcount.  It is now impossible to mess up the refcount.
2. PAListPtr is now the main interface to the underlying object, and
   the underlying object is now completely opaque.
3. Implementation details like SmallVector and FoldingSet are now no
   longer part of the interface.
4. You can create a PAListPtr with an arbitrary sequence of
   ParamAttrsWithIndex's, no need to make a SmallVector of a specific 
   size (you can just use an array or scalar or vector if you wish).
5. All the client code that had to check for a null pointer before
   dereferencing the pointer is simplified to just access the 
   PAListPtr directly.
6. The interfaces for adding attrs to a list and removing them is a
   bit simpler.

Phase #2 will rename some stuff (e.g. PAListPtr) and do other less 
invasive changes.

llvm-svn: 48289
 2008-03-12 17:45:29 +00:00
Devang Patel
0c7fb89803 Skip functions that return multiple values. 
llvm-svn: 48233
 2008-03-11 18:04:06 +00:00
Nick Lewycky
1d6b50743f Don't eliminate blocks that are only reachable by unwind_to. 
llvm-svn: 48106
 2008-03-09 08:50:23 +00:00
Nick Lewycky
f249c5d5ad Don't try to simplify urem and srem using arithmetic rules that don't work 
under modulo (overflow). Fixes PR1933.

llvm-svn: 47987
 2008-03-06 06:48:30 +00:00
Chris Lattner
5aeccb7353 Folding or(fcmp,fcmp) only works if the operands of the fcmps are the same fp type. 
llvm-svn: 47750
 2008-02-29 06:09:11 +00:00
Bill Wendling
bd1f1ae160 De-tabify. 
llvm-svn: 47599
 2008-02-26 10:53:30 +00:00
Dale Johannesen
ae08bdb4cf Split ParameterAttributes.h, putting the complicated 
stuff into ParamAttrsList.h.  Per feedback from
ParamAttrs changes.

llvm-svn: 47504
 2008-02-22 22:17:59 +00:00
Zhou Sheng
0742fbfedf Fixed a typo. 
llvm-svn: 47478
 2008-02-22 10:00:35 +00:00
Anton Korobeynikov
c41f5b6af4 Fix newly-introduced 4.3 warnings 
llvm-svn: 47375
 2008-02-20 12:07:57 +00:00
Anton Korobeynikov
fd6b669c80 Make Transforms to be 4.3 warnings-clean 
llvm-svn: 47371
 2008-02-20 11:26:25 +00:00
Dale Johannesen
ecb2b233b1 Expand ParameterAttributes to 32 bits (in preparation 
for adding alignment info, not there yet).  Clean up
interfaces to reference ParameterAttributes consistently.

llvm-svn: 47342
 2008-02-19 21:38:47 +00:00
Chris Lattner
6bb889cf84 fdiv/frem of undef can produce undef, because the undef operand 
can be a SNaN.  We could be more aggressive and turn this into 
unreachable, but that is less nice, and not really worth it.

llvm-svn: 47313
 2008-02-19 06:12:18 +00:00
Nick Lewycky
1f3c58df08 Correctly fold divide-by-constant, even when faced with overflow. 
llvm-svn: 47287
 2008-02-18 22:48:05 +00:00
Chris Lattner
a378b03483 Transforming -A + -B --> -(A + B) isn't safe for FP, thanks 
to Dale for noticing this!

llvm-svn: 47276
 2008-02-18 17:50:16 +00:00
Chris Lattner
9851db050b optimize away stackrestore calls that have no intervening alloca or call. 
llvm-svn: 47258
 2008-02-18 06:12:38 +00:00
Chris Lattner
2fa904b3af Fold (-x + -y) -> -(x+y) which promotes better association, fixing 
the second half of PR2047

llvm-svn: 47244
 2008-02-17 21:03:36 +00:00
Dan Gohman
588498082a Rename APInt's isPositive to isNonNegative, to reflect what it 
actually does.

llvm-svn: 47090
 2008-02-13 22:09:18 +00:00
Chris Lattner
96deed5d4d Fix a bug compiling PR1978 (perhaps not the only one though) which 
was incorrectly simplifying "x == (gep x, 1, i)" into false, even 
though i could be negative.  As it turns out, all the code to 
handle this already existed, we just need to disable the incorrect
optimization case and let the general case handle it.

llvm-svn: 46739
 2008-02-05 04:45:32 +00:00
Nick Lewycky
febd3642ce There are some cases where icmp(add) can be folded into a new icmp. Handle them. 
llvm-svn: 46687
 2008-02-03 16:33:09 +00:00
Nick Lewycky
29cd604126 Hack on vectors too. 
llvm-svn: 46684
 2008-02-03 08:19:11 +00:00
Nick Lewycky
ce4c4698d7 Fold away one multiply in instcombine. This would normally be caught in 
reassociate anyways, but they could be generated during instcombine's run.

llvm-svn: 46683
 2008-02-03 07:42:09 +00:00
Chris Lattner
83f411c586 eliminate additions of 0.0 when they are obviously dead. This has to be careful to 
avoid turning -0.0 + 0.0 -> -0.0 which is incorrect.

llvm-svn: 46499
 2008-01-29 06:52:45 +00:00
Nick Lewycky
6b070b1b93 Handle some more combinations of extend and icmp. Fixes PR1940. 
llvm-svn: 46431
 2008-01-28 03:48:02 +00:00
Chris Lattner
359756ea4b Fix PR1932 by disabling an xform invalid for fdiv. 
llvm-svn: 46429
 2008-01-28 00:58:18 +00:00
Chris Lattner
aa553aa0c1 Fold fptrunc(add (fpextend x), (fpextend y)) -> add(x,y), as GCC does. 
llvm-svn: 46406
 2008-01-27 05:29:54 +00:00
Nick Lewycky
13b6bc91d6 Enable the fix I just checked in, silly me. 
llvm-svn: 46247
 2008-01-22 05:42:02 +00:00
Nick Lewycky
78780f175b Multiply can be evaluated in a different type, so long as the target type has 
a smaller bitwidth.

llvm-svn: 46244
 2008-01-22 05:08:48 +00:00
Duncan Sands
81e35b4d47 I noticed that the trampoline straightening transformation could 
drop attributes on varargs call arguments.  Also, it could generate
invalid IR if the transformed call already had the 'nest' attribute
somewhere (this can never happen for code coming from llvm-gcc,
but it's a theoretical possibility).  Fix both problems.

llvm-svn: 45973
 2008-01-14 19:52:09 +00:00
Chris Lattner
d22a5f6314 Turn a memcpy from a double* into a load/store of double instead of 
a load/store of i64.  The later prevents promotion/scalarrepl of the
source and dest in many cases.

This fixes the 300% performance regression of the byval stuff on 
stepanov_v1p2.

llvm-svn: 45945
 2008-01-14 00:28:35 +00:00
Chris Lattner
8560bb9d98 factor memcpy/memmove simplification out to its own SimplifyMemTransfer 
method, no functionality change.

llvm-svn: 45944
 2008-01-13 23:50:23 +00:00
Chris Lattner
5fbf76aaf4 simplify some code. If we can infer alignment for source and dest that are 
greater than memcpy alignment, and if we lower to load/store, use the best 
alignment info we have.

llvm-svn: 45943
 2008-01-13 22:30:28 +00:00
Chris Lattner
4f69f1a721 simplify some code by adding a InsertBitCastBefore method, 
make memmove->memcpy conversion a bit simpler.

llvm-svn: 45942
 2008-01-13 22:23:22 +00:00
Chris Lattner
32eae5daa5 Fix PR1907, a nasty miscompilation because instcombine didn't 
realize that ne & sgt  was a signed comparison (it was only 
looking at whether the left compare was signed).

llvm-svn: 45937
 2008-01-13 20:59:02 +00:00
Duncan Sands
7414cc131b When turning a call to a bitcast function into a direct call, 
if this becomes a varargs call then deal correctly with any
parameter attributes on the newly vararg call arguments.

llvm-svn: 45931
 2008-01-13 08:02:44 +00:00
Chris Lattner
67f581b344 Implement PR1795, an instcombine hack for forming GEPs with integer pointer arithmetic. 
llvm-svn: 45745
 2008-01-08 07:23:51 +00:00
Duncan Sands
7955cf0cd7 Small cleanup for handling of type/parameter attribute 
incompatibility.

llvm-svn: 45704
 2008-01-07 17:16:06 +00:00
Duncan Sands
fd975e4b3d The transform that tries to turn calls to bitcast functions into 
direct calls bails out unless caller and callee have essentially
equivalent parameter attributes.  This is illogical - the callee's
attributes should be of no relevance here.  Rework the logic, which
incidentally fixes a crash when removed arguments have attributes.

llvm-svn: 45658
 2008-01-06 18:27:01 +00:00
Duncan Sands
b8489f09a2 When transforming a call to a bitcast function into 
a direct call with cast parameters and cast return
value (if any), instcombine was prepared to cast any
non-void return value into any other, whether castable
or not.  Add a new predicate for testing whether casting
is valid, and check it both for the return value and
(as a cleanup) for the parameters.

llvm-svn: 45657
 2008-01-06 10:12:28 +00:00
Chris Lattner
7e1c3aa702 remove a couple more unsafe xforms in the face of overflow. 
llvm-svn: 45613
 2008-01-05 01:22:42 +00:00
Chris Lattner
983697dfac remove the (x-y) < 0 comparison xform, it miscompiles 
things that are not equality comparisons, for example:
   (2147479553+4096)-2147479553 < 0    !=   (2147479553+4096) < 2147479553

llvm-svn: 45612
 2008-01-05 01:18:20 +00:00
Chris Lattner
ad9a6ccb83 Remove attribution from file headers, per discussion on llvmdev. 
llvm-svn: 45418
 2007-12-29 20:36:04 +00:00
Christopher Lamb
dfad5f19b4 Disable null pointer folding transforms for non-generic address spaces. This should probably be a target-specific predicate based on address space. That way for targets where this isn't applicable the predicate can be optimized away. 
llvm-svn: 45403
 2007-12-29 07:56:53 +00:00
Owen Anderson
ebd3e9c500 Repair a transform that Chris noticed a bug in. Thanks to Nicholas for pointing out my stupid mistakes when writing this patch. :-) 
llvm-svn: 45384
 2007-12-28 07:42:12 +00:00
Chris Lattner
2456399ce5 disable this instcombine xform, it miscompiles: 
define i32 @main() {
entry:
	%z = alloca i32		; <i32*> [#uses=2]
	store i32 0, i32* %z
	%tmp = load i32* %z		; <i32> [#uses=1]
	%sub = sub i32 %tmp, 1		; <i32> [#uses=1]
	%cmp = icmp ult i32 %sub, 0		; <i1> [#uses=1]
	%retval = select i1 %cmp, i32 1, i32 0		; <i32> [#uses=1]
	ret i32 %retval
}

into ret 1, instead of ret 0.

Christopher, please investigate.

llvm-svn: 45383
 2007-12-28 06:24:31 +00:00
Chris Lattner
d64df490ca implement InstCombine/shift-trunc-shift.ll. This allows 
us to compile:
#include <math.h>
int t1(double d) { return signbit(d); }

into:

_t1:
	movd	%xmm0, %rax
	shrq	$63, %rax
	ret

instead of:

_t1:
	movd	%xmm0, %rax
	shrq	$32, %rax
	shrl	$31, %eax
	ret

on x86-64.

llvm-svn: 45311
 2007-12-22 09:07:47 +00:00
Christopher Lamb
7ca648a7b1 Implement review feedback, including additional transforms 
(icmp slt (sub A B) 1) -> (icmp sle A B)
icmp sgt (sub A B) -1) -> (icmp sge A B)

and add testcase.

llvm-svn: 45256
 2007-12-20 07:21:11 +00:00
Chris Lattner
1a386cbdae simplify this code with the new m_Zero() pattern. Make sure the select only 
has a single use, and generalize it to not require N to be a constant.

llvm-svn: 45250
 2007-12-20 01:56:58 +00:00
Duncan Sands
56f3add5b7 When inlining through an 'nounwind' call, mark inlined 
calls 'nounwind'.  It is important for correct C++
exception handling that nounwind markings do not get
lost, so this transformation is actually needed for
correctness.

llvm-svn: 45218
 2007-12-19 21:13:37 +00:00
Christopher Lamb
be0cbc7e92 Fold subtracts into integer compares vs. zero. This improves generate code for this case on X86 
from
_foo:
        movl    $99, %ecx
        movl    4(%esp), %eax
        subl    %eax, %ecx
        xorl    %edx, %edx
        testl   %ecx, %ecx
        cmovs   %edx, %eax
        ret

to
_foo:
        xorl    %ecx, %ecx
        movl    4(%esp), %eax
        cmpl    $99, %eax
        cmovg   %ecx, %eax
        ret

llvm-svn: 45173
 2007-12-18 21:32:20 +00:00