mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 04:02:41 +01:00
3f0b170fdd
Problem: On SystemZ we need to open text files in text mode. On Windows, files opened in text mode adds a CRLF '\r\n' which may not be desirable. Solution: This patch adds two new flags - OF_CRLF which indicates that CRLF translation is used. - OF_TextWithCRLF = OF_Text | OF_CRLF indicates that the file is text and uses CRLF translation. Developers should now use either the OF_Text or OF_TextWithCRLF for text files and OF_None for binary files. If the developer doesn't want carriage returns on Windows, they should use OF_Text, if they do want carriage returns on Windows, they should use OF_TextWithCRLF. So this is the behaviour per platform with my patch: z/OS: OF_None: open in binary mode OF_Text : open in text mode OF_TextWithCRLF: open in text mode Windows: OF_None: open file with no carriage return OF_Text: open file with no carriage return OF_TextWithCRLF: open file with carriage return The Major change is in llvm/lib/Support/Windows/Path.inc to only set text mode if the OF_CRLF is set. ``` if (Flags & OF_CRLF) CrtOpenFlags |= _O_TEXT; ``` These following files are the ones that still use OF_Text which I left unchanged. I modified all these except raw_ostream.cpp in recent patches so I know these were previously in Binary mode on Windows. ./llvm/lib/Support/raw_ostream.cpp ./llvm/lib/TableGen/Main.cpp ./llvm/tools/dsymutil/DwarfLinkerForBinary.cpp ./llvm/unittests/Support/Path.cpp ./clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp ./clang/lib/Frontend/CompilerInstance.cpp ./clang/lib/Driver/Driver.cpp ./clang/lib/Driver/ToolChains/Clang.cpp Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D99426
187 lines
5.5 KiB
C++
187 lines
5.5 KiB
C++
//===-- DOTGraphTraitsPass.h - Print/View dotty graphs-----------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Templates to create dotty viewer and printer passes for GraphTraits graphs.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_ANALYSIS_DOTGRAPHTRAITSPASS_H
|
|
#define LLVM_ANALYSIS_DOTGRAPHTRAITSPASS_H
|
|
|
|
#include "llvm/Analysis/CFGPrinter.h"
|
|
|
|
namespace llvm {
|
|
|
|
/// Default traits class for extracting a graph from an analysis pass.
|
|
///
|
|
/// This assumes that 'GraphT' is 'AnalysisT *' and so just passes it through.
|
|
template <typename AnalysisT, typename GraphT = AnalysisT *>
|
|
struct DefaultAnalysisGraphTraits {
|
|
static GraphT getGraph(AnalysisT *A) { return A; }
|
|
};
|
|
|
|
template <
|
|
typename AnalysisT, bool IsSimple, typename GraphT = AnalysisT *,
|
|
typename AnalysisGraphTraitsT = DefaultAnalysisGraphTraits<AnalysisT, GraphT> >
|
|
class DOTGraphTraitsViewer : public FunctionPass {
|
|
public:
|
|
DOTGraphTraitsViewer(StringRef GraphName, char &ID)
|
|
: FunctionPass(ID), Name(GraphName) {}
|
|
|
|
/// Return true if this function should be processed.
|
|
///
|
|
/// An implementation of this class my override this function to indicate that
|
|
/// only certain functions should be viewed.
|
|
///
|
|
/// @param Analysis The current analysis result for this function.
|
|
virtual bool processFunction(Function &F, AnalysisT &Analysis) {
|
|
return true;
|
|
}
|
|
|
|
bool runOnFunction(Function &F) override {
|
|
auto &Analysis = getAnalysis<AnalysisT>();
|
|
|
|
if (!processFunction(F, Analysis))
|
|
return false;
|
|
|
|
GraphT Graph = AnalysisGraphTraitsT::getGraph(&Analysis);
|
|
std::string GraphName = DOTGraphTraits<GraphT>::getGraphName(Graph);
|
|
std::string Title = GraphName + " for '" + F.getName().str() + "' function";
|
|
|
|
ViewGraph(Graph, Name, IsSimple, Title);
|
|
|
|
return false;
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
AU.setPreservesAll();
|
|
AU.addRequired<AnalysisT>();
|
|
}
|
|
|
|
private:
|
|
std::string Name;
|
|
};
|
|
|
|
template <
|
|
typename AnalysisT, bool IsSimple, typename GraphT = AnalysisT *,
|
|
typename AnalysisGraphTraitsT = DefaultAnalysisGraphTraits<AnalysisT, GraphT> >
|
|
class DOTGraphTraitsPrinter : public FunctionPass {
|
|
public:
|
|
DOTGraphTraitsPrinter(StringRef GraphName, char &ID)
|
|
: FunctionPass(ID), Name(GraphName) {}
|
|
|
|
/// Return true if this function should be processed.
|
|
///
|
|
/// An implementation of this class my override this function to indicate that
|
|
/// only certain functions should be printed.
|
|
///
|
|
/// @param Analysis The current analysis result for this function.
|
|
virtual bool processFunction(Function &F, AnalysisT &Analysis) {
|
|
return true;
|
|
}
|
|
|
|
bool runOnFunction(Function &F) override {
|
|
auto &Analysis = getAnalysis<AnalysisT>();
|
|
|
|
if (!processFunction(F, Analysis))
|
|
return false;
|
|
|
|
GraphT Graph = AnalysisGraphTraitsT::getGraph(&Analysis);
|
|
std::string Filename = Name + "." + F.getName().str() + ".dot";
|
|
std::error_code EC;
|
|
|
|
errs() << "Writing '" << Filename << "'...";
|
|
|
|
raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF);
|
|
std::string GraphName = DOTGraphTraits<GraphT>::getGraphName(Graph);
|
|
std::string Title = GraphName + " for '" + F.getName().str() + "' function";
|
|
|
|
if (!EC)
|
|
WriteGraph(File, Graph, IsSimple, Title);
|
|
else
|
|
errs() << " error opening file for writing!";
|
|
errs() << "\n";
|
|
|
|
return false;
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
AU.setPreservesAll();
|
|
AU.addRequired<AnalysisT>();
|
|
}
|
|
|
|
private:
|
|
std::string Name;
|
|
};
|
|
|
|
template <
|
|
typename AnalysisT, bool IsSimple, typename GraphT = AnalysisT *,
|
|
typename AnalysisGraphTraitsT = DefaultAnalysisGraphTraits<AnalysisT, GraphT> >
|
|
class DOTGraphTraitsModuleViewer : public ModulePass {
|
|
public:
|
|
DOTGraphTraitsModuleViewer(StringRef GraphName, char &ID)
|
|
: ModulePass(ID), Name(GraphName) {}
|
|
|
|
bool runOnModule(Module &M) override {
|
|
GraphT Graph = AnalysisGraphTraitsT::getGraph(&getAnalysis<AnalysisT>());
|
|
std::string Title = DOTGraphTraits<GraphT>::getGraphName(Graph);
|
|
|
|
ViewGraph(Graph, Name, IsSimple, Title);
|
|
|
|
return false;
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
AU.setPreservesAll();
|
|
AU.addRequired<AnalysisT>();
|
|
}
|
|
|
|
private:
|
|
std::string Name;
|
|
};
|
|
|
|
template <
|
|
typename AnalysisT, bool IsSimple, typename GraphT = AnalysisT *,
|
|
typename AnalysisGraphTraitsT = DefaultAnalysisGraphTraits<AnalysisT, GraphT> >
|
|
class DOTGraphTraitsModulePrinter : public ModulePass {
|
|
public:
|
|
DOTGraphTraitsModulePrinter(StringRef GraphName, char &ID)
|
|
: ModulePass(ID), Name(GraphName) {}
|
|
|
|
bool runOnModule(Module &M) override {
|
|
GraphT Graph = AnalysisGraphTraitsT::getGraph(&getAnalysis<AnalysisT>());
|
|
std::string Filename = Name + ".dot";
|
|
std::error_code EC;
|
|
|
|
errs() << "Writing '" << Filename << "'...";
|
|
|
|
raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF);
|
|
std::string Title = DOTGraphTraits<GraphT>::getGraphName(Graph);
|
|
|
|
if (!EC)
|
|
WriteGraph(File, Graph, IsSimple, Title);
|
|
else
|
|
errs() << " error opening file for writing!";
|
|
errs() << "\n";
|
|
|
|
return false;
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
AU.setPreservesAll();
|
|
AU.addRequired<AnalysisT>();
|
|
}
|
|
|
|
private:
|
|
std::string Name;
|
|
};
|
|
|
|
} // end namespace llvm
|
|
|
|
#endif
|