mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-25 14:02:52 +02:00
dad102bcc9
analyses to have a common type which is enforced rather than using a char object and a `void *` type when used as an identifier. This has a number of advantages. First, it at least helps some of the confusion raised in Justin Lebar's code review of why `void *` was being used everywhere by having a stronger type that connects to documentation about this. However, perhaps more importantly, it addresses a serious issue where the alignment of these pointer-like identifiers was unknown. This made it hard to use them in pointer-like data structures. We were already dodging this in dangerous ways to create the "all analyses" entry. In a subsequent patch I attempted to use these with TinyPtrVector and things fell apart in a very bad way. And it isn't just a compile time or type system issue. Worse than that, the actual alignment of these pointer-like opaque identifiers wasn't guaranteed to be a useful alignment as they were just characters. This change introduces a type to use as the "key" object whose address forms the opaque identifier. This both forces the objects to have proper alignment, and provides type checking that we get it right everywhere. It also makes the types somewhat less mysterious than `void *`. We could go one step further and introduce a truly opaque pointer-like type to return from the `ID()` static function rather than returning `AnalysisKey *`, but that didn't seem to be a clear win so this is just the initial change to get to a reliably typed and aligned object serving is a key for all the analyses. Thanks to Richard Smith and Justin Lebar for helping pick plausible names and avoid making this refactoring many times. =] And thanks to Sean for the super fast review! While here, I've tried to move away from the "PassID" nomenclature entirely as it wasn't really helping and is overloaded with old pass manager constructs. Now we have IDs for analyses, and key objects whose address can be used as IDs. Where possible and clear I've shortened this to just "ID". In a few places I kept "AnalysisID" to make it clear what was being identified. Differential Revision: https://reviews.llvm.org/D27031 llvm-svn: 287783 |
||
|---|---|---|
| .. | ||
| AsmWriter.cpp | ||
| AttributeImpl.h | ||
| Attributes.cpp | ||
| AttributesCompatFunc.td | ||
| AttributeSetNode.h | ||
| AutoUpgrade.cpp | ||
| BasicBlock.cpp | ||
| CMakeLists.txt | ||
| Comdat.cpp | ||
| ConstantFold.cpp | ||
| ConstantFold.h | ||
| ConstantRange.cpp | ||
| Constants.cpp | ||
| ConstantsContext.h | ||
| Core.cpp | ||
| DataLayout.cpp | ||
| DebugInfo.cpp | ||
| DebugInfoMetadata.cpp | ||
| DebugLoc.cpp | ||
| DiagnosticInfo.cpp | ||
| DiagnosticPrinter.cpp | ||
| DIBuilder.cpp | ||
| Dominators.cpp | ||
| Function.cpp | ||
| GCOV.cpp | ||
| Globals.cpp | ||
| GVMaterializer.cpp | ||
| InlineAsm.cpp | ||
| Instruction.cpp | ||
| Instructions.cpp | ||
| IntrinsicInst.cpp | ||
| IRBuilder.cpp | ||
| IRPrintingPasses.cpp | ||
| LegacyPassManager.cpp | ||
| LLVMBuild.txt | ||
| LLVMContext.cpp | ||
| LLVMContextImpl.cpp | ||
| LLVMContextImpl.h | ||
| Mangler.cpp | ||
| MDBuilder.cpp | ||
| Metadata.cpp | ||
| MetadataImpl.h | ||
| Module.cpp | ||
| ModuleSummaryIndex.cpp | ||
| Operator.cpp | ||
| OptBisect.cpp | ||
| Pass.cpp | ||
| PassManager.cpp | ||
| PassRegistry.cpp | ||
| ProfileSummary.cpp | ||
| Statepoint.cpp | ||
| SymbolTableListTraitsImpl.h | ||
| Type.cpp | ||
| TypeFinder.cpp | ||
| Use.cpp | ||
| User.cpp | ||
| Value.cpp | ||
| ValueSymbolTable.cpp | ||
| ValueTypes.cpp | ||
| Verifier.cpp | ||