mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-22 04:22:57 +02:00
145c25bada
Summary: Scalarizer has two data structures that hold information about changes to the function, Gathered and Scattered. These are cleared in finish() at the end of runOnFunction() if finish() detects any changes to the function. However, finish() was checking for changes by only checking if Gathered was non-empty. The function visitStore() only modifies Scattered without touching Gathered. As a result, Scattered could have ended up having stale data if Scalarizer only scalarized store instructions. Since the data in Scattered is used during the execution of the pass, this introduced dangling pointer errors. The fix is to check whether both Scattered and Gathered are empty before deciding what to do in finish(). This also fixes a problem where the Function can be modified although the pass returns false. Reviewers: rnk Subscribers: rnk, srhines, llvm-commits Differential Revision: http://reviews.llvm.org/D10459 llvm-svn: 243040
26 lines
1.0 KiB
LLVM
26 lines
1.0 KiB
LLVM
; RUN: opt -scalarizer -scalarize-load-store -S < %s | FileCheck %s
|
|
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
|
|
|
|
; This input caused the scalarizer not to clear cached results
|
|
; properly.
|
|
;
|
|
; Any regressions should trigger an assert in the scalarizer.
|
|
|
|
define void @func(<4 x float> %val, <4 x float> *%ptr) {
|
|
store <4 x float> %val, <4 x float> *%ptr
|
|
ret void
|
|
; CHECK: store float %val.i0, float* %ptr.i0, align 16
|
|
; CHECK: store float %val.i1, float* %ptr.i1, align 4
|
|
; CHECK: store float %val.i2, float* %ptr.i2, align 8
|
|
; CHECK: store float %val.i3, float* %ptr.i3, align 4
|
|
}
|
|
|
|
define void @func.copy(<4 x float> %val, <4 x float> *%ptr) {
|
|
store <4 x float> %val, <4 x float> *%ptr
|
|
ret void
|
|
; CHECK: store float %val.i0, float* %ptr.i0, align 16
|
|
; CHECK: store float %val.i1, float* %ptr.i1, align 4
|
|
; CHECK: store float %val.i2, float* %ptr.i2, align 8
|
|
; CHECK: store float %val.i3, float* %ptr.i3, align 4
|
|
}
|