mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-26 04:32:44 +01:00
0c1aee0b16
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
10 lines
415 B
LLVM
10 lines
415 B
LLVM
!named = !{!0, !1, !2, !3, !4, !5}
|
|
|
|
!0 = distinct !DISubprogram() ; Use this as a scope.
|
|
!1 = !DILocation(line: 3, column: 7, scope: !0)
|
|
!2 = !DILocation(line: 3, column: 7, scope: !0, inlinedAt: !1)
|
|
!3 = !DILocation(line: 3, column: 7, scope: !0, inlinedAt: !2)
|
|
; Test distinct nodes.
|
|
!4 = distinct !DILocation(line: 3, column: 7, scope: !0)
|
|
!5 = distinct !DILocation(line: 3, column: 7, scope: !0, inlinedAt: !4)
|