mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 19:23:23 +01:00
f8a414589e
Summary: This clang-tidy check is looking for unsigned integer variables whose initializer starts with an implicit cast from llvm::Register and changes the type of the variable to llvm::Register (dropping the llvm:: where possible). Partial reverts in: X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned& MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register PPCFastISel.cpp - No Register::operator-=() PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned& MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor Manual fixups in: ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned& HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register. PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned& Depends on D65919 Reviewers: arsenm, bogner, craig.topper, RKSimon Reviewed By: arsenm Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D65962 llvm-svn: 369041
166 lines
5.4 KiB
C++
166 lines
5.4 KiB
C++
//===---------------------- ProcessImplicitDefs.cpp -----------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/ADT/SetVector.h"
|
|
#include "llvm/Analysis/AliasAnalysis.h"
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
#include "llvm/CodeGen/MachineInstr.h"
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
#include "llvm/CodeGen/Passes.h"
|
|
#include "llvm/CodeGen/TargetInstrInfo.h"
|
|
#include "llvm/CodeGen/TargetSubtargetInfo.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
using namespace llvm;
|
|
|
|
#define DEBUG_TYPE "processimpdefs"
|
|
|
|
namespace {
|
|
/// Process IMPLICIT_DEF instructions and make sure there is one implicit_def
|
|
/// for each use. Add isUndef marker to implicit_def defs and their uses.
|
|
class ProcessImplicitDefs : public MachineFunctionPass {
|
|
const TargetInstrInfo *TII;
|
|
const TargetRegisterInfo *TRI;
|
|
MachineRegisterInfo *MRI;
|
|
|
|
SmallSetVector<MachineInstr*, 16> WorkList;
|
|
|
|
void processImplicitDef(MachineInstr *MI);
|
|
bool canTurnIntoImplicitDef(MachineInstr *MI);
|
|
|
|
public:
|
|
static char ID;
|
|
|
|
ProcessImplicitDefs() : MachineFunctionPass(ID) {
|
|
initializeProcessImplicitDefsPass(*PassRegistry::getPassRegistry());
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &au) const override;
|
|
|
|
bool runOnMachineFunction(MachineFunction &MF) override;
|
|
};
|
|
} // end anonymous namespace
|
|
|
|
char ProcessImplicitDefs::ID = 0;
|
|
char &llvm::ProcessImplicitDefsID = ProcessImplicitDefs::ID;
|
|
|
|
INITIALIZE_PASS(ProcessImplicitDefs, DEBUG_TYPE,
|
|
"Process Implicit Definitions", false, false)
|
|
|
|
void ProcessImplicitDefs::getAnalysisUsage(AnalysisUsage &AU) const {
|
|
AU.setPreservesCFG();
|
|
AU.addPreserved<AAResultsWrapperPass>();
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
|
|
bool ProcessImplicitDefs::canTurnIntoImplicitDef(MachineInstr *MI) {
|
|
if (!MI->isCopyLike() &&
|
|
!MI->isInsertSubreg() &&
|
|
!MI->isRegSequence() &&
|
|
!MI->isPHI())
|
|
return false;
|
|
for (const MachineOperand &MO : MI->operands())
|
|
if (MO.isReg() && MO.isUse() && MO.readsReg())
|
|
return false;
|
|
return true;
|
|
}
|
|
|
|
void ProcessImplicitDefs::processImplicitDef(MachineInstr *MI) {
|
|
LLVM_DEBUG(dbgs() << "Processing " << *MI);
|
|
Register Reg = MI->getOperand(0).getReg();
|
|
|
|
if (Register::isVirtualRegister(Reg)) {
|
|
// For virtual registers, mark all uses as <undef>, and convert users to
|
|
// implicit-def when possible.
|
|
for (MachineOperand &MO : MRI->use_nodbg_operands(Reg)) {
|
|
MO.setIsUndef();
|
|
MachineInstr *UserMI = MO.getParent();
|
|
if (!canTurnIntoImplicitDef(UserMI))
|
|
continue;
|
|
LLVM_DEBUG(dbgs() << "Converting to IMPLICIT_DEF: " << *UserMI);
|
|
UserMI->setDesc(TII->get(TargetOpcode::IMPLICIT_DEF));
|
|
WorkList.insert(UserMI);
|
|
}
|
|
MI->eraseFromParent();
|
|
return;
|
|
}
|
|
|
|
// This is a physreg implicit-def.
|
|
// Look for the first instruction to use or define an alias.
|
|
MachineBasicBlock::instr_iterator UserMI = MI->getIterator();
|
|
MachineBasicBlock::instr_iterator UserE = MI->getParent()->instr_end();
|
|
bool Found = false;
|
|
for (++UserMI; UserMI != UserE; ++UserMI) {
|
|
for (MachineOperand &MO : UserMI->operands()) {
|
|
if (!MO.isReg())
|
|
continue;
|
|
Register UserReg = MO.getReg();
|
|
if (!Register::isPhysicalRegister(UserReg) ||
|
|
!TRI->regsOverlap(Reg, UserReg))
|
|
continue;
|
|
// UserMI uses or redefines Reg. Set <undef> flags on all uses.
|
|
Found = true;
|
|
if (MO.isUse())
|
|
MO.setIsUndef();
|
|
}
|
|
if (Found)
|
|
break;
|
|
}
|
|
|
|
// If we found the using MI, we can erase the IMPLICIT_DEF.
|
|
if (Found) {
|
|
LLVM_DEBUG(dbgs() << "Physreg user: " << *UserMI);
|
|
MI->eraseFromParent();
|
|
return;
|
|
}
|
|
|
|
// Using instr wasn't found, it could be in another block.
|
|
// Leave the physreg IMPLICIT_DEF, but trim any extra operands.
|
|
for (unsigned i = MI->getNumOperands() - 1; i; --i)
|
|
MI->RemoveOperand(i);
|
|
LLVM_DEBUG(dbgs() << "Keeping physreg: " << *MI);
|
|
}
|
|
|
|
/// processImplicitDefs - Process IMPLICIT_DEF instructions and turn them into
|
|
/// <undef> operands.
|
|
bool ProcessImplicitDefs::runOnMachineFunction(MachineFunction &MF) {
|
|
|
|
LLVM_DEBUG(dbgs() << "********** PROCESS IMPLICIT DEFS **********\n"
|
|
<< "********** Function: " << MF.getName() << '\n');
|
|
|
|
bool Changed = false;
|
|
|
|
TII = MF.getSubtarget().getInstrInfo();
|
|
TRI = MF.getSubtarget().getRegisterInfo();
|
|
MRI = &MF.getRegInfo();
|
|
assert(MRI->isSSA() && "ProcessImplicitDefs only works on SSA form.");
|
|
assert(WorkList.empty() && "Inconsistent worklist state");
|
|
|
|
for (MachineFunction::iterator MFI = MF.begin(), MFE = MF.end();
|
|
MFI != MFE; ++MFI) {
|
|
// Scan the basic block for implicit defs.
|
|
for (MachineBasicBlock::instr_iterator MBBI = MFI->instr_begin(),
|
|
MBBE = MFI->instr_end(); MBBI != MBBE; ++MBBI)
|
|
if (MBBI->isImplicitDef())
|
|
WorkList.insert(&*MBBI);
|
|
|
|
if (WorkList.empty())
|
|
continue;
|
|
|
|
LLVM_DEBUG(dbgs() << printMBBReference(*MFI) << " has " << WorkList.size()
|
|
<< " implicit defs.\n");
|
|
Changed = true;
|
|
|
|
// Drain the WorkList to recursively process any new implicit defs.
|
|
do processImplicitDef(WorkList.pop_back_val());
|
|
while (!WorkList.empty());
|
|
}
|
|
return Changed;
|
|
}
|