Jonas Devlieghere ab486fe71a [MC] Fix undefined behavior in MCInstPrinter::formatHex ... Passing INT64_MIN to MCInstPrinter::formatHex triggers undefined behavior because the negation of -9223372036854775808 cannot be represented in type 'int64_t' (aka 'long long'). This patch puts a workaround in place to just print the hex value directly. A possible alternative involves using a small helper functions that uses (implementation) defined conversions to achieve the desirable value: static int64_t helper(int64_t V) { auto U = static_cast<uint64_t>(V); return V < 0 ? -U : U; } The underlying problem is that MCInstPrinter::formatHex(int64_t) returns a format_object<int64_t> and should really return a format_object<uint64_t>. However, that's not possible because formatImm needs to be able to print both as decimal (where a signed is required) and hex (where we'd prefer to always have an unsigned). format_object<int64_t> formatImm(int64_t Value) const { return PrintImmHex ? formatHex(Value) : formatDec(Value); } Differential revision: https://reviews.llvm.org/D67236 llvm-svn: 371159		2019-09-06 01:13:32 +00:00
..
CMakeLists.txt	[MC] Fix undefined behavior in MCInstPrinter::formatHex	2019-09-06 01:13:32 +00:00
Disassembler.cpp
DwarfLineTables.cpp	[llvm] Migrate llvm::make_unique to std::make_unique	2019-08-15 15:54:37 +00:00
MCInstPrinter.cpp	[MC] Fix undefined behavior in MCInstPrinter::formatHex	2019-09-06 01:13:32 +00:00
StringTableBuilderTest.cpp
TargetRegistry.cpp