mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-01-31 20:51:52 +01:00
f88703e30a
Summary: When performing indirect call promotion, current implementation inspects "all" parameters of the callsite and attemps to match with the formal argument type of the callee function. However, it is not possible to find the type for variable length arguments, and the compiler crashes when it attemps to match the type for variable lenght argument. It seems that the bug is introduced with D40658. Prior to that, the type matching is performed only for the parameters whose ID is less than callee->getFunctionNumParams(). The attached test case will crash without the patch. Reviewers: mssimpso, davidxl, davide Reviewed By: mssimpso Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D46026 llvm-svn: 330844
29 lines
1.0 KiB
LLVM
29 lines
1.0 KiB
LLVM
; RUN: opt < %s -pgo-icall-prom -S | FileCheck %s
|
|
|
|
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-unknown-linux-gnu"
|
|
|
|
%struct.A = type { i8 }
|
|
%struct.B = type { i8 }
|
|
@foo = common global i32 (%struct.A*, ...)* null, align 8
|
|
|
|
define i32 @func1(%struct.B* %x, ...) {
|
|
entry:
|
|
ret i32 0
|
|
}
|
|
|
|
define i32 @bar(%struct.A* %x) {
|
|
entry:
|
|
%tmp = load i32 (%struct.A*, ...)*, i32 (%struct.A*, ...)** @foo, align 8
|
|
; CHECK: [[CMP:%[0-9]+]] = icmp eq i32 (%struct.A*, ...)* %tmp, bitcast (i32 (%struct.B*, ...)* @func1 to i32 (%struct.A*, ...)*)
|
|
; CHECK: br i1 [[CMP]], label %if.true.direct_targ, label %if.false.orig_indirect, !prof [[BRANCH_WEIGHT:![0-9]+]]
|
|
; CHECK: if.true.direct_targ:
|
|
; CHECK: [[DIRCALL_RET:%[0-9]+]] = call i32 (%struct.B*, ...) @func1
|
|
; CHECK: br label %if.end.icp
|
|
%call = call i32 (%struct.A*, ...) %tmp(%struct.A* %x, i32 0), !prof !1
|
|
ret i32 %call
|
|
}
|
|
|
|
; CHECK: [[BRANCH_WEIGHT]] = !{!"branch_weights", i32 1500, i32 100}
|
|
!1 = !{!"VP", i32 0, i64 1600, i64 -2545542355363006406, i64 1500}
|