1
0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 10:42:39 +01:00
llvm-mirror/tools/llvm-rc
Martin Storsjö ea4f7bb1a3 [llvm-rc] Allow dashes as part of resource name strings
This matches what MS rc.exe allows in practice. I'm not aware of
any legal syntax case that are broken by allowing dashes as part
of what the tokenizer considers an Identifier - but I'm not
very well versed in the RC syntax either, can @amccarth think of
any case that would be broken by this?

This fixes downstream bug
https://github.com/msys2/MINGW-packages/issues/9180.

Additionally, rc.exe allows such resource name strings to be surrounded
by quotes, ending up with e.g.

    Resource name (string): "QUOTEDNAME"

(i.e., the quotes end up as part of the string), which llvm-rc doesn't
support yet either. (I'm not aware of such cases in the wild though,
but resource string names with dashes do exist.)

This also allows including files with unquoted paths, with filenames
containing dashes (which fixes
https://github.com/msys2/MINGW-packages/issues/9130, which has been
worked around differently so far).

Differential Revision: https://reviews.llvm.org/D106598
2021-07-23 23:05:20 +03:00
..
CMakeLists.txt
llvm-rc.cpp [llvm-rc] Don't rewrite the arch in the default triple unless necessary 2021-06-25 22:59:09 +03:00
Opts.td
ResourceFileWriter.cpp [llvm] Rename StringRef _lower() method calls to _insensitive() 2021-06-25 00:22:01 +03:00
ResourceFileWriter.h
ResourceScriptCppFilter.cpp [llvm] Rename StringRef _lower() method calls to _insensitive() 2021-06-25 00:22:01 +03:00
ResourceScriptCppFilter.h
ResourceScriptParser.cpp [llvm-rc] Make commas in user data structs optional 2021-07-09 14:31:12 +03:00
ResourceScriptParser.h
ResourceScriptStmt.cpp
ResourceScriptStmt.h [llvm] Rename StringRef _lower() method calls to _insensitive() 2021-06-25 00:22:01 +03:00
ResourceScriptToken.cpp [llvm-rc] Allow dashes as part of resource name strings 2021-07-23 23:05:20 +03:00
ResourceScriptToken.h
ResourceScriptTokenList.def
ResourceVisitor.h
WindresOpts.td