mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-26 12:43:36 +01:00
f59acc15ad
Summary: This is a resurrection of work first proposed and discussed in Aug 2015: http://lists.llvm.org/pipermail/llvm-dev/2015-August/089384.html and initially landed (but then backed out) in Nov 2015: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151109/312083.html The @llvm.memcpy/memmove/memset intrinsics currently have an explicit argument which is required to be a constant integer. It represents the alignment of the dest (and source), and so must be the minimum of the actual alignment of the two. This change is the first in a series that allows source and dest to each have their own alignments by using the alignment attribute on their arguments. In this change we: 1) Remove the alignment argument. 2) Add alignment attributes to the source & dest arguments. We, temporarily, require that the alignments for source & dest be equal. For example, code which used to read: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dest, i8* %src, i32 100, i32 4, i1 false) will now read call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 4 %dest, i8* align 4 %src, i32 100, i1 false) Downstream users may have to update their lit tests that check for @llvm.memcpy/memmove/memset call/declaration patterns. The following extended sed script may help with updating the majority of your tests, but it does not catch all possible patterns so some manual checking and updating will be required. s~declare void @llvm\.mem(set|cpy|move)\.p([^(]*)\((.*), i32, i1\)~declare void @llvm.mem\1.p\2(\3, i1)~g s~call void @llvm\.memset\.p([^(]*)i8\(i8([^*]*)\* (.*), i8 (.*), i8 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i8(i8\2* \3, i8 \4, i8 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i16\(i8([^*]*)\* (.*), i8 (.*), i16 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i16(i8\2* \3, i8 \4, i16 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i32\(i8([^*]*)\* (.*), i8 (.*), i32 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i32(i8\2* \3, i8 \4, i32 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i64\(i8([^*]*)\* (.*), i8 (.*), i64 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i64(i8\2* \3, i8 \4, i64 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i128\(i8([^*]*)\* (.*), i8 (.*), i128 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i128(i8\2* \3, i8 \4, i128 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i8\(i8([^*]*)\* (.*), i8 (.*), i8 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i8(i8\2* align \6 \3, i8 \4, i8 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i16\(i8([^*]*)\* (.*), i8 (.*), i16 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i16(i8\2* align \6 \3, i8 \4, i16 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i32\(i8([^*]*)\* (.*), i8 (.*), i32 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i32(i8\2* align \6 \3, i8 \4, i32 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i64\(i8([^*]*)\* (.*), i8 (.*), i64 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i64(i8\2* align \6 \3, i8 \4, i64 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i128\(i8([^*]*)\* (.*), i8 (.*), i128 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i128(i8\2* align \6 \3, i8 \4, i128 \5, i1 \7)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i8\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i8 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i8(i8\3* \4, i8\5* \6, i8 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i16\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i16 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i16(i8\3* \4, i8\5* \6, i16 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i32\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i32 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i32(i8\3* \4, i8\5* \6, i32 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i64\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i64 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i64(i8\3* \4, i8\5* \6, i64 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i128\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i128 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i128(i8\3* \4, i8\5* \6, i128 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i8\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i8 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i8(i8\3* align \8 \4, i8\5* align \8 \6, i8 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i16\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i16 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i16(i8\3* align \8 \4, i8\5* align \8 \6, i16 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i32\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i32 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i32(i8\3* align \8 \4, i8\5* align \8 \6, i32 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i64\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i64 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i64(i8\3* align \8 \4, i8\5* align \8 \6, i64 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i128\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i128 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i128(i8\3* align \8 \4, i8\5* align \8 \6, i128 \7, i1 \9)~g The remaining changes in the series will: Step 2) Expand the IRBuilder API to allow creation of memcpy/memmove with differing source and dest alignments. Step 3) Update Clang to use the new IRBuilder API. Step 4) Update Polly to use the new IRBuilder API. Step 5) Update LLVM passes that create memcpy/memmove calls to use the new IRBuilder API, and those that use use MemIntrinsicInst::[get|set]Alignment() to use getDestAlignment() and getSourceAlignment() instead. Step 6) Remove the single-alignment IRBuilder API for memcpy/memmove, and the MemIntrinsicInst::[get|set]Alignment() methods. Reviewers: pete, hfinkel, lhames, reames, bollu Reviewed By: reames Subscribers: niosHD, reames, jholewinski, qcolombet, jfb, sanjoy, arsenm, dschuff, dylanmckay, mehdi_amini, sdardis, nemanjai, david2050, nhaehnle, javed.absar, sbc100, jgravelle-google, eraman, aheejin, kbarton, JDevlieghere, asb, rbar, johnrusso, simoncook, jordy.potman.lists, apazos, sabuasal, llvm-commits Differential Revision: https://reviews.llvm.org/D41675 llvm-svn: 322965
127 lines
4.3 KiB
LLVM
127 lines
4.3 KiB
LLVM
; Test that loops with sufficient registers do not reload or spill on
|
|
; stack. These cases include calls and it is necessary to have the GR128 /
|
|
; FP128 registers part of the callee saved registers list in order to avoid
|
|
; spilling / reloading.
|
|
;
|
|
; RUN: llc -switch-peel-threshold=101 < %s -mtriple=s390x-linux-gnu -mcpu=z13 | FileCheck %s
|
|
|
|
%0 = type { %0*, %0*, %0*, i32, %1*, i64, i64, i64, i64, i64, i64, %2, %5, %7 }
|
|
%1 = type { i32, i32, i32 (%1*, i64, i32)*, i32 (%1*, i64, i64, i32, i8**)*, i32 (%1*, i64, i64, i64, i32)*, i32 (%1*)*, void (i8*)*, i8*, i8* }
|
|
%2 = type { i64, i64, %3** }
|
|
%3 = type { %4*, i64 }
|
|
%4 = type { i64, i8* }
|
|
%5 = type { i64, i64, %6** }
|
|
%6 = type { i64, %4*, i32, i64, i8* }
|
|
%7 = type { i64, i64, %8** }
|
|
%8 = type { i64, i64*, i64*, %4*, i64, i32*, %5, i32, i64, i64 }
|
|
|
|
declare void @llvm.memcpy.p0i8.p0i8.i64(i8* nocapture writeonly, i8* nocapture readonly, i64, i1)
|
|
|
|
define void @fun0(%0*) {
|
|
; CHECK-LABEL: .LBB0_4
|
|
; CHECK: => This Inner Loop Header: Depth=2
|
|
; CHECK-NOT: 16-byte Folded Spill
|
|
; CHECK-NOT: 16-byte Folded Reload
|
|
|
|
%2 = load i64, i64* undef, align 8
|
|
%3 = udiv i64 128, %2
|
|
%4 = mul i64 %3, %2
|
|
%5 = load i64, i64* undef, align 8
|
|
switch i32 undef, label %36 [
|
|
i32 1, label %6
|
|
i32 2, label %7
|
|
i32 3, label %8
|
|
i32 4, label %9
|
|
i32 5, label %10
|
|
i32 6, label %11
|
|
]
|
|
|
|
; <label>:6: ; preds = %1
|
|
br label %12
|
|
|
|
; <label>:7: ; preds = %1
|
|
br label %12
|
|
|
|
; <label>:8: ; preds = %1
|
|
unreachable
|
|
|
|
; <label>:9: ; preds = %1
|
|
unreachable
|
|
|
|
; <label>:10: ; preds = %1
|
|
unreachable
|
|
|
|
; <label>:11: ; preds = %1
|
|
unreachable
|
|
|
|
; <label>:12: ; preds = %7, %6
|
|
%13 = getelementptr inbounds %0, %0* %0, i64 0, i32 5
|
|
br label %14
|
|
|
|
; <label>:14: ; preds = %31, %12
|
|
%15 = phi i64 [ undef, %31 ], [ %5, %12 ]
|
|
%16 = phi i64 [ %35, %31 ], [ undef, %12 ]
|
|
%17 = load i64, i64* %13, align 8
|
|
%18 = icmp ult i64 %15, %17
|
|
%19 = select i1 %18, i64 %15, i64 %17
|
|
%20 = udiv i64 %19, %4
|
|
%21 = icmp ugt i64 %20, 1
|
|
%22 = select i1 %21, i64 %20, i64 1
|
|
%23 = sub i64 %22, 0
|
|
br label %24
|
|
|
|
; <label>:24: ; preds = %24, %14
|
|
%25 = phi i64 [ %23, %14 ], [ %27, %24 ]
|
|
call void @llvm.memcpy.p0i8.p0i8.i64(i8* undef, i8* nonnull undef, i64 %4, i1 false)
|
|
%26 = getelementptr inbounds i8, i8* null, i64 %4
|
|
store i8* %26, i8** undef, align 8
|
|
%27 = add i64 %25, -4
|
|
%28 = icmp eq i64 %27, 0
|
|
br i1 %28, label %31, label %24
|
|
|
|
; <label>:29: ; preds = %24
|
|
br i1 undef, label %31, label %30
|
|
|
|
; <label>:30: ; preds = %29
|
|
call void @llvm.memcpy.p0i8.p0i8.i64(i8* %26, i8* nonnull undef, i64 %4, i1 false)
|
|
br label %31
|
|
|
|
; <label>:31: ; preds = %30, %29
|
|
%32 = call signext i32 undef(%1* undef, i64 %16, i32 signext 8)
|
|
%33 = icmp eq i64 undef, 0
|
|
%34 = select i1 %33, i64 0, i64 %19
|
|
%35 = add i64 %34, %16
|
|
br i1 %33, label %36, label %14
|
|
|
|
; <label>:36: ; preds = %31, %1
|
|
ret void
|
|
}
|
|
|
|
declare fp128 @llvm.pow.f128(fp128, fp128)
|
|
|
|
define void @fun1(fp128*) {
|
|
; CHECK-LABEL: .LBB1_2
|
|
; CHECK: =>This Inner Loop Header: Depth=1
|
|
; CHECK-NOT: 16-byte Folded Spill
|
|
; CHECK-NOT: 16-byte Folded Reload
|
|
; CHECK-LABEL: .LBB1_3
|
|
|
|
br i1 undef, label %7, label %2
|
|
|
|
; <label>:2: ; preds = %2, %1
|
|
%3 = phi fp128 [ %5, %2 ], [ 0xL00000000000000000000000000000000, %1 ]
|
|
%4 = tail call fp128 @llvm.pow.f128(fp128 0xL00000000000000000000000000000000, fp128 0xL00000000000000000000000000000000) #2
|
|
%5 = fadd fp128 %3, %4
|
|
%6 = icmp eq i64 undef, 0
|
|
br i1 %6, label %7, label %2
|
|
|
|
; <label>:7: ; preds = %2, %1
|
|
%8 = phi fp128 [ 0xL00000000000000000000000000000000, %1 ], [ %5, %2 ]
|
|
%9 = fadd fp128 0xL00000000000000000000000000000000, %8
|
|
%10 = fadd fp128 0xL00000000000000000000000000000000, %9
|
|
%11 = fadd fp128 0xL00000000000000000000000000000000, %10
|
|
%12 = tail call fp128 @llvm.pow.f128(fp128 %11, fp128 0xL00000000000000000000000000000000) #2
|
|
store fp128 %12, fp128* %0, align 8
|
|
ret void
|
|
}
|