Duncan P. N. Exon Smith 9f6a612ccc ADT: Rely on std::aligned_union_t for math in AlignedCharArrayUnion, NFC ...

Instead of computing the alignment and size of the `char` buffer in
`AlignedCharArrayUnion`, rely on the math in `std::aligned_union_t`.
Because some users of this rely on the `buffer` field existing with a
type convertible to `char *`, we can't change the field type, but we can
still avoid duplicating the logic.

A potential follow up would be to delete `AlignedCharArrayUnion` after
updating its users to use `std::aligned_union_t` directly; or if we like
our template parameters better, could update users to stop peeking
inside and then replace the definition with:
```
template <class T, class... Ts>
using AlignedCharArrayUnion = std::aligned_union_t<1, T, Ts...>;
```

Differential Revision: https://reviews.llvm.org/D92500

2020-12-02 15:56:12 -08:00

..

llvm

ADT: Rely on std::aligned_union_t for math in AlignedCharArrayUnion, NFC

2020-12-02 15:56:12 -08:00

llvm-c

Creating a named struct requires only a Context and a name, but looking up a struct by name requires a Module. The method on Module merely accesses the LLVMContextImpl and no data from the module itself, so this patch moves getTypeByName to a static method on StructType that takes a Context and a name.

2020-11-30 11:34:12 -08:00