Kevin Enderby a6534d0295 Thread Expected<...> up from createMachOObjectFile() to allow llvm-objdump to produce a real error message ... Produce the first specific error message for a malformed Mach-O file describing the problem instead of the generic message for object_error::parse_failed of "Invalid data was encountered while parsing the file”.  Many more good error messages will follow after this first one. This is built on Lang Hames’ great work of adding the ’Error' class for structured error handling and threading Error through MachOObjectFile construction. And making createMachOObjectFile return Expected<...> . So to to get the error to the llvm-obdump tool, I changed the stack of these methods to also return Expected<...> : object::ObjectFile::createObjectFile() object::SymbolicFile::createSymbolicFile() object::createBinary() Then finally in ParseInputMachO() in MachODump.cpp the error can be reported and the specific error message can be printed in llvm-objdump and can be seen in the existing test case for the existing malformed binary but with the updated error message. Converting these interfaces to Expected<> from ErrorOr<> does involve touching a number of places. To contain the changes for now use of errorToErrorCode() and errorOrToExpected() are used where the callers are yet to be converted. Also there some were bugs in the existing code that did not deal with the old ErrorOr<> return values. So now with Expected<> since they must be checked and the error handled, I added a TODO and a comment: “// TODO: Actually report errors helpfully” and a call something like consumeError(ObjOrErr.takeError()) so the buggy code will not crash since needed to deal with the Error. Note there is one fix also needed to lld/COFF/InputFiles.cpp that goes along with this that I will commit right after this. So expect lld not to built after this commit and before the next one. llvm-svn: 265606		2016-04-06 22:14:09 +00:00
..
CMakeLists.txt	llvm-cov: Simplify coverage reports, fixing PR22575 in the process	2015-02-14 02:01:24 +00:00
CodeCoverage.cpp	[Object] Search for architecures by name in MachOUniversalBinary::getObjectForArch()	2015-06-22 21:33:24 +00:00
CoverageFilters.cpp	llvm-cov: Disentangle the coverage data logic from the display (NFC)	2014-09-20 15:31:56 +00:00
CoverageFilters.h	[cleanup] Re-sort all the #include lines in LLVM using	2015-01-14 11:23:27 +00:00
CoverageReport.cpp	[llvm-cov] Adjust column widths for function and file reports	2015-10-21 16:03:32 +00:00
CoverageReport.h	llvm-cov: Actually use the command line arguments when reporting	2015-02-14 02:05:05 +00:00
CoverageSummaryInfo.cpp	llvm-cov: Simplify coverage reports, fixing PR22575 in the process	2015-02-14 02:01:24 +00:00
CoverageSummaryInfo.h	llvm-cov: Simplify coverage reports, fixing PR22575 in the process	2015-02-14 02:01:24 +00:00
CoverageViewOptions.h	[llvm-cov] Disable name and path truncation	2015-09-14 23:26:36 +00:00
gcov.cpp	Rename one of our two llvm::GCOVOptions classes to llvm::GCOV::Options. We used	2015-10-14 00:04:19 +00:00
llvm-cov.cpp	llvm-cov: Make llvm-cov --version DTRT	2015-06-03 02:48:09 +00:00
LLVMBuild.txt
RenderingSupport.h	Removing LLVM_DELETED_FUNCTION, as MSVC 2012 was the last reason for requiring the macro. NFC; LLVM edition.	2015-02-15 22:54:22 +00:00
SourceCoverageView.cpp	InstrProf: Fix display of large numbers in llvm-cov	2015-05-13 22:41:48 +00:00
SourceCoverageView.h	InstrProf: Teach llvm-cov to show the max count instead of the last	2015-02-23 21:21:34 +00:00
TestingSupport.cpp	Thread Expected<...> up from createMachOObjectFile() to allow llvm-objdump to produce a real error message	2016-04-06 22:14:09 +00:00