mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-22 20:43:44 +02:00
40bfd37ca7
Whilst working on improvements to the error handling of the debug line parsing code, I noticed that if an invalid offset were to be specified in a call to getOrParseLineTable(), an entry in the LineTableMap would still be created, even if the offset was not within the section range. The immediate parsing attempt afterwards would fail (it would end up getting a version of 0), and thereafter, any subsequent calls to getOrParseLineTable or getLineTable would return the default- constructed, invalid line table. In reality, we shouldn't even attempt to parse this table, and we should always return a nullptr from these two functions for this situation. I have tested this via a unit test, which required some new framework for unit testing debug line. My plan is to add quite a few more unit tests for the new error reporting mechanism that will follow shortly, hence the reason why the supporting code for the tests are written the way they are - I intend to extend the DwarfGenerator class to support generating debug line. At that point, I'll make sure that there are a few positive test cases for this and the parsing code too. Differential Revision: https://reviews.llvm.org/D44200 Reviewers: JDevlieghere, aprantl llvm-svn: 326995
24 lines
398 B
CMake
24 lines
398 B
CMake
set(LLVM_LINK_COMPONENTS
|
|
${LLVM_TARGETS_TO_BUILD}
|
|
AsmPrinter
|
|
DebugInfoDWARF
|
|
MC
|
|
Object
|
|
ObjectYAML
|
|
Support
|
|
)
|
|
|
|
set(DebugInfoSources
|
|
DwarfGenerator.cpp
|
|
DwarfUtils.cpp
|
|
DWARFDebugInfoTest.cpp
|
|
DWARFDebugLineTest.cpp
|
|
DWARFFormValueTest.cpp
|
|
)
|
|
|
|
add_llvm_unittest(DebugInfoDWARFTests
|
|
${DebugInfoSources}
|
|
)
|
|
|
|
target_link_libraries(DebugInfoDWARFTests PRIVATE LLVMTestingSupport)
|