mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-24 21:42:54 +02:00
1f42c70b4f
This is a partial re-commit -- maybe more of a re-implementation -- of
r265631 (reverted in r265637).
This makes RF_IgnoreMissingLocals behave (almost) consistently between
the Value and the Metadata hierarchy. In particular:
- MapValue returns nullptr or "metadata !{}" for missing locals in
MetadataAsValue/LocalAsMetadata bridging paris, depending on
the RF_IgnoreMissingLocals flag.
- MapValue doesn't memoize LocalAsMetadata-related results.
- MapMetadata no longer deals with LocalAsMetadata or
RF_IgnoreMissingLocals at all. (This wasn't in r265631 at all, but
I realized during testing it would make the patch simpler with no
loss of generality.)
r265631 went too far, making both functions universally ignore
RF_IgnoreMissingLocals. This broke building (e.g.) compiler-rt.
Reassociate (and possibly other passes) don't currently maintain
dominates-use invariants for metadata operands, resulting in IR like
this:
define void @foo(i32 %arg) {
call void @llvm.some.intrinsic(metadata i32 %x)
%x = add i32 1, i32 %arg
}
If the inliner chooses to inline @foo into another function, then
RemapInstruction will call `MapValue(metadata i32 %x)` and assert that
the return is not nullptr.
I've filed PR27273 to add a Verifier check and fix the underlying
problem in the optimization passes.
As a workaround, return `!{}` instead of nullptr for unmapped
LocalAsMetadata when RF_IgnoreMissingLocals is unset. Otherwise, match
the behaviour of r265631.
Original commit message:
ValueMapper: Make LocalAsMetadata match function-local Values
Start treating LocalAsMetadata similarly to function-local members of
the Value hierarchy in MapValue and MapMetadata.
- Don't memoize them.
- Return nullptr if they are missing.
This also cleans up ConstantAsMetadata to stop listening to the
RF_IgnoreMissingLocals flag.
llvm-svn: 265759
|
||
|---|---|---|
| .. | ||
| AddDiscriminators.cpp | ||
| ASanStackFrameLayout.cpp | ||
| BasicBlockUtils.cpp | ||
| BreakCriticalEdges.cpp | ||
| BuildLibCalls.cpp | ||
| BypassSlowDivision.cpp | ||
| CloneFunction.cpp | ||
| CloneModule.cpp | ||
| CMakeLists.txt | ||
| CmpInstAnalysis.cpp | ||
| CodeExtractor.cpp | ||
| CtorUtils.cpp | ||
| DemoteRegToStack.cpp | ||
| Evaluator.cpp | ||
| FlattenCFG.cpp | ||
| FunctionImportUtils.cpp | ||
| GlobalStatus.cpp | ||
| InlineFunction.cpp | ||
| InstructionNamer.cpp | ||
| IntegerDivision.cpp | ||
| LCSSA.cpp | ||
| LLVMBuild.txt | ||
| Local.cpp | ||
| LoopSimplify.cpp | ||
| LoopUnroll.cpp | ||
| LoopUnrollRuntime.cpp | ||
| LoopUtils.cpp | ||
| LoopVersioning.cpp | ||
| LowerInvoke.cpp | ||
| LowerSwitch.cpp | ||
| Mem2Reg.cpp | ||
| MemorySSA.cpp | ||
| MetaRenamer.cpp | ||
| ModuleUtils.cpp | ||
| PromoteMemoryToRegister.cpp | ||
| SanitizerStats.cpp | ||
| SimplifyCFG.cpp | ||
| SimplifyIndVar.cpp | ||
| SimplifyInstructions.cpp | ||
| SimplifyLibCalls.cpp | ||
| SplitModule.cpp | ||
| SSAUpdater.cpp | ||
| SymbolRewriter.cpp | ||
| UnifyFunctionExitNodes.cpp | ||
| Utils.cpp | ||
| ValueMapper.cpp | ||