mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-20 11:33:24 +02:00
0c1aee0b16
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
52 lines
2.2 KiB
LLVM
52 lines
2.2 KiB
LLVM
; RUN: llc < %s - | FileCheck %s
|
|
;
|
|
; FIXME: A potentially more interesting test case would be:
|
|
; %call = @bar()
|
|
; dbg.value j=0
|
|
; %call2 = @bar()
|
|
; dbg.value j=%call
|
|
;
|
|
; We cannot current handle the above sequence because codegenprepare
|
|
; hoists the second dbg.value above %call2, which then appears to
|
|
; conflict with j=0. It does this because SelectionDAG cannot handle
|
|
; global debug values.
|
|
|
|
target triple = "x86_64-apple-darwin10.0.0"
|
|
|
|
;CHECK: ## DW_OP_consts
|
|
;CHECK-NEXT: .byte 42
|
|
define i32 @foobar() nounwind readonly noinline ssp {
|
|
entry:
|
|
tail call void @llvm.dbg.value(metadata i32 42, i64 0, metadata !6, metadata !DIExpression()), !dbg !9
|
|
%call = tail call i32 @bar(), !dbg !11
|
|
tail call void @llvm.dbg.value(metadata i32 %call, i64 0, metadata !6, metadata !DIExpression()), !dbg !11
|
|
%call2 = tail call i32 @bar(), !dbg !11
|
|
%add = add nsw i32 %call2, %call, !dbg !12
|
|
ret i32 %add, !dbg !10
|
|
}
|
|
|
|
declare void @llvm.dbg.value(metadata, i64, metadata, metadata) nounwind readnone
|
|
declare i32 @bar() nounwind readnone
|
|
|
|
!llvm.dbg.cu = !{!2}
|
|
!llvm.module.flags = !{!17}
|
|
|
|
!0 = distinct !DISubprogram(name: "foobar", linkageName: "foobar", line: 12, isLocal: false, isDefinition: true, virtualIndex: 6, isOptimized: true, file: !15, scope: !1, type: !3, function: i32 ()* @foobar, variables: !14)
|
|
!1 = !DIFile(filename: "mu.c", directory: "/private/tmp")
|
|
!2 = distinct !DICompileUnit(language: DW_LANG_C99, producer: "clang version 2.9 (trunk 114183)", isOptimized: true, emissionKind: 1, file: !15, enums: !16, retainedTypes: !16, subprograms: !13, imports: null)
|
|
!3 = !DISubroutineType(types: !4)
|
|
!4 = !{!5}
|
|
!5 = !DIBasicType(tag: DW_TAG_base_type, name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!6 = !DILocalVariable(name: "j", line: 15, scope: !7, file: !1, type: !5)
|
|
!7 = distinct !DILexicalBlock(line: 12, column: 52, file: !15, scope: !0)
|
|
!8 = !{i32 42}
|
|
!9 = !DILocation(line: 15, column: 12, scope: !7)
|
|
!10 = !DILocation(line: 23, column: 3, scope: !7)
|
|
!11 = !DILocation(line: 17, column: 3, scope: !7)
|
|
!12 = !DILocation(line: 18, column: 3, scope: !7)
|
|
!13 = !{!0}
|
|
!14 = !{!6}
|
|
!15 = !DIFile(filename: "mu.c", directory: "/private/tmp")
|
|
!16 = !{}
|
|
!17 = !{i32 1, !"Debug Info Version", i32 3}
|