mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 18:54:02 +01:00
2820258583
This patch removes hidden codegen flag -print-schedule effectively reverting the logic originally committed as r300311 (https://llvm.org/viewvc/llvm-project?view=revision&revision=300311). Flag -print-schedule was originally introduced by r300311 to address PR32216 (https://bugs.llvm.org/show_bug.cgi?id=32216). That bug was about adding "Better testing of schedule model instruction latencies/throughputs". These days, we can use llvm-mca to test scheduling models. So there is no longer a need for flag -print-schedule in LLVM. The main use case for PR32216 is now addressed by llvm-mca. Flag -print-schedule is mainly used for debugging purposes, and it is only actually used by x86 specific tests. We already have extensive (latency and throughput) tests under "test/tools/llvm-mca" for X86 processor models. That means, most (if not all) existing -print-schedule tests for X86 are redundant. When flag -print-schedule was first added to LLVM, several files had to be modified; a few APIs gained new arguments (see for example method MCAsmStreamer::EmitInstruction), and MCSubtargetInfo/TargetSubtargetInfo gained a couple of getSchedInfoStr() methods. Method getSchedInfoStr() had to originally work for both MCInst and MachineInstr. The original implmentation of getSchedInfoStr() introduced a subtle layering violation (reported as PR37160 and then fixed/worked-around by r330615). In retrospect, that new API could have been designed more optimally. We can always query MCSchedModel to get the latency and throughput. More importantly, the "sched-info" string should not have been generated by the subtarget. Note, r317782 fixed an issue where "print-schedule" didn't work very well in the presence of inline assembly. That commit is also reverted by this change. Differential Revision: https://reviews.llvm.org/D57244 llvm-svn: 353043
233 lines
6.9 KiB
C++
233 lines
6.9 KiB
C++
//===-- RecordStreamer.cpp - Record asm defined and used symbols ----------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "RecordStreamer.h"
|
|
#include "llvm/IR/Mangler.h"
|
|
#include "llvm/IR/Module.h"
|
|
#include "llvm/MC/MCContext.h"
|
|
#include "llvm/MC/MCSymbol.h"
|
|
|
|
using namespace llvm;
|
|
|
|
void RecordStreamer::markDefined(const MCSymbol &Symbol) {
|
|
State &S = Symbols[Symbol.getName()];
|
|
switch (S) {
|
|
case DefinedGlobal:
|
|
case Global:
|
|
S = DefinedGlobal;
|
|
break;
|
|
case NeverSeen:
|
|
case Defined:
|
|
case Used:
|
|
S = Defined;
|
|
break;
|
|
case DefinedWeak:
|
|
break;
|
|
case UndefinedWeak:
|
|
S = DefinedWeak;
|
|
}
|
|
}
|
|
|
|
void RecordStreamer::markGlobal(const MCSymbol &Symbol,
|
|
MCSymbolAttr Attribute) {
|
|
State &S = Symbols[Symbol.getName()];
|
|
switch (S) {
|
|
case DefinedGlobal:
|
|
case Defined:
|
|
S = (Attribute == MCSA_Weak) ? DefinedWeak : DefinedGlobal;
|
|
break;
|
|
|
|
case NeverSeen:
|
|
case Global:
|
|
case Used:
|
|
S = (Attribute == MCSA_Weak) ? UndefinedWeak : Global;
|
|
break;
|
|
case UndefinedWeak:
|
|
case DefinedWeak:
|
|
break;
|
|
}
|
|
}
|
|
|
|
void RecordStreamer::markUsed(const MCSymbol &Symbol) {
|
|
State &S = Symbols[Symbol.getName()];
|
|
switch (S) {
|
|
case DefinedGlobal:
|
|
case Defined:
|
|
case Global:
|
|
case DefinedWeak:
|
|
case UndefinedWeak:
|
|
break;
|
|
|
|
case NeverSeen:
|
|
case Used:
|
|
S = Used;
|
|
break;
|
|
}
|
|
}
|
|
|
|
void RecordStreamer::visitUsedSymbol(const MCSymbol &Sym) { markUsed(Sym); }
|
|
|
|
RecordStreamer::RecordStreamer(MCContext &Context, const Module &M)
|
|
: MCStreamer(Context), M(M) {}
|
|
|
|
RecordStreamer::const_iterator RecordStreamer::begin() {
|
|
return Symbols.begin();
|
|
}
|
|
|
|
RecordStreamer::const_iterator RecordStreamer::end() { return Symbols.end(); }
|
|
|
|
void RecordStreamer::EmitInstruction(const MCInst &Inst,
|
|
const MCSubtargetInfo &STI) {
|
|
MCStreamer::EmitInstruction(Inst, STI);
|
|
}
|
|
|
|
void RecordStreamer::EmitLabel(MCSymbol *Symbol, SMLoc Loc) {
|
|
MCStreamer::EmitLabel(Symbol);
|
|
markDefined(*Symbol);
|
|
}
|
|
|
|
void RecordStreamer::EmitAssignment(MCSymbol *Symbol, const MCExpr *Value) {
|
|
markDefined(*Symbol);
|
|
MCStreamer::EmitAssignment(Symbol, Value);
|
|
}
|
|
|
|
bool RecordStreamer::EmitSymbolAttribute(MCSymbol *Symbol,
|
|
MCSymbolAttr Attribute) {
|
|
if (Attribute == MCSA_Global || Attribute == MCSA_Weak)
|
|
markGlobal(*Symbol, Attribute);
|
|
if (Attribute == MCSA_LazyReference)
|
|
markUsed(*Symbol);
|
|
return true;
|
|
}
|
|
|
|
void RecordStreamer::EmitZerofill(MCSection *Section, MCSymbol *Symbol,
|
|
uint64_t Size, unsigned ByteAlignment,
|
|
SMLoc Loc) {
|
|
markDefined(*Symbol);
|
|
}
|
|
|
|
void RecordStreamer::EmitCommonSymbol(MCSymbol *Symbol, uint64_t Size,
|
|
unsigned ByteAlignment) {
|
|
markDefined(*Symbol);
|
|
}
|
|
|
|
RecordStreamer::State RecordStreamer::getSymbolState(const MCSymbol *Sym) {
|
|
auto SI = Symbols.find(Sym->getName());
|
|
if (SI == Symbols.end())
|
|
return NeverSeen;
|
|
return SI->second;
|
|
}
|
|
|
|
void RecordStreamer::emitELFSymverDirective(StringRef AliasName,
|
|
const MCSymbol *Aliasee) {
|
|
SymverAliasMap[Aliasee].push_back(AliasName);
|
|
}
|
|
|
|
iterator_range<RecordStreamer::const_symver_iterator>
|
|
RecordStreamer::symverAliases() {
|
|
return {SymverAliasMap.begin(), SymverAliasMap.end()};
|
|
}
|
|
|
|
void RecordStreamer::flushSymverDirectives() {
|
|
// Mapping from mangled name to GV.
|
|
StringMap<const GlobalValue *> MangledNameMap;
|
|
// The name in the assembler will be mangled, but the name in the IR
|
|
// might not, so we first compute a mapping from mangled name to GV.
|
|
Mangler Mang;
|
|
SmallString<64> MangledName;
|
|
for (const GlobalValue &GV : M.global_values()) {
|
|
if (!GV.hasName())
|
|
continue;
|
|
MangledName.clear();
|
|
MangledName.reserve(GV.getName().size() + 1);
|
|
Mang.getNameWithPrefix(MangledName, &GV, /*CannotUsePrivateLabel=*/false);
|
|
MangledNameMap[MangledName] = &GV;
|
|
}
|
|
|
|
// Walk all the recorded .symver aliases, and set up the binding
|
|
// for each alias.
|
|
for (auto &Symver : SymverAliasMap) {
|
|
const MCSymbol *Aliasee = Symver.first;
|
|
MCSymbolAttr Attr = MCSA_Invalid;
|
|
bool IsDefined = false;
|
|
|
|
// First check if the aliasee binding was recorded in the asm.
|
|
RecordStreamer::State state = getSymbolState(Aliasee);
|
|
switch (state) {
|
|
case RecordStreamer::Global:
|
|
case RecordStreamer::DefinedGlobal:
|
|
Attr = MCSA_Global;
|
|
break;
|
|
case RecordStreamer::UndefinedWeak:
|
|
case RecordStreamer::DefinedWeak:
|
|
Attr = MCSA_Weak;
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
switch (state) {
|
|
case RecordStreamer::Defined:
|
|
case RecordStreamer::DefinedGlobal:
|
|
case RecordStreamer::DefinedWeak:
|
|
IsDefined = true;
|
|
break;
|
|
case RecordStreamer::NeverSeen:
|
|
case RecordStreamer::Global:
|
|
case RecordStreamer::Used:
|
|
case RecordStreamer::UndefinedWeak:
|
|
break;
|
|
}
|
|
|
|
if (Attr == MCSA_Invalid || !IsDefined) {
|
|
const GlobalValue *GV = M.getNamedValue(Aliasee->getName());
|
|
if (!GV) {
|
|
auto MI = MangledNameMap.find(Aliasee->getName());
|
|
if (MI != MangledNameMap.end())
|
|
GV = MI->second;
|
|
}
|
|
if (GV) {
|
|
// If we don't have a symbol attribute from assembly, then check if
|
|
// the aliasee was defined in the IR.
|
|
if (Attr == MCSA_Invalid) {
|
|
if (GV->hasExternalLinkage())
|
|
Attr = MCSA_Global;
|
|
else if (GV->hasLocalLinkage())
|
|
Attr = MCSA_Local;
|
|
else if (GV->isWeakForLinker())
|
|
Attr = MCSA_Weak;
|
|
}
|
|
IsDefined = IsDefined || !GV->isDeclarationForLinker();
|
|
}
|
|
}
|
|
|
|
// Set the detected binding on each alias with this aliasee.
|
|
for (auto AliasName : Symver.second) {
|
|
std::pair<StringRef, StringRef> Split = AliasName.split("@@@");
|
|
SmallString<128> NewName;
|
|
if (!Split.second.empty() && !Split.second.startswith("@")) {
|
|
// Special processing for "@@@" according
|
|
// https://sourceware.org/binutils/docs/as/Symver.html
|
|
const char *Separator = IsDefined ? "@@" : "@";
|
|
AliasName =
|
|
(Split.first + Separator + Split.second).toStringRef(NewName);
|
|
}
|
|
MCSymbol *Alias = getContext().getOrCreateSymbol(AliasName);
|
|
// TODO: Handle "@@@". Depending on SymbolAttribute value it needs to be
|
|
// converted into @ or @@.
|
|
const MCExpr *Value = MCSymbolRefExpr::create(Aliasee, getContext());
|
|
if (IsDefined)
|
|
markDefined(*Alias);
|
|
// Don't use EmitAssignment override as it always marks alias as defined.
|
|
MCStreamer::EmitAssignment(Alias, Value);
|
|
if (Attr != MCSA_Invalid)
|
|
EmitSymbolAttribute(Alias, Attr);
|
|
}
|
|
}
|
|
}
|