mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 18:54:02 +01:00
6b81c5b99d
When MemCpyOpt performs call slot optimization it will concatenate the `alias.scope` metadata between the function call and the memcpy. However, scoped AA relies on the domains in metadata to be maintained in a caller-callee relationship. Naive concatenation breaks this assumption leading to bad AA results. The fix is to take the intersection of domains then union the scopes within those domains. The original bug came from a case of rust bad codegen which uses this bad aliasing to perform additional memcpy optimizations. As show in the added test case `%src` got forwarded past its lifetime leading to a dereference of garbage data. Testing ninja check-llvm Reviewed By: jeroen.dobbelaere Differential Revision: https://reviews.llvm.org/D91576
45 lines
1.2 KiB
LLVM
45 lines
1.2 KiB
LLVM
; RUN: opt -scoped-noalias-aa -basic-aa -newgvn -S < %s | FileCheck %s
|
|
|
|
define i32 @test1(i32* %p, i32* %q) {
|
|
; CHECK-LABEL: @test1(i32* %p, i32* %q)
|
|
; CHECK: load i32, i32* %p
|
|
; CHECK-NOT: noalias
|
|
; CHECK: %c = add i32 %a, %a
|
|
%a = load i32, i32* %p, !noalias !3
|
|
%b = load i32, i32* %p
|
|
%c = add i32 %a, %b
|
|
ret i32 %c
|
|
}
|
|
|
|
define i32 @test2(i32* %p, i32* %q) {
|
|
; CHECK-LABEL: @test2(i32* %p, i32* %q)
|
|
; CHECK: load i32, i32* %p, align 4, !alias.scope ![[SCOPE1:[0-9]+]]
|
|
; CHECK: %c = add i32 %a, %a
|
|
%a = load i32, i32* %p, !alias.scope !3
|
|
%b = load i32, i32* %p, !alias.scope !3
|
|
%c = add i32 %a, %b
|
|
ret i32 %c
|
|
}
|
|
|
|
define i32 @test3(i32* %p, i32* %q) {
|
|
; CHECK-LABEL: @test3(i32* %p, i32* %q)
|
|
; CHECK: load i32, i32* %p, align 4, !alias.scope ![[SCOPE2:[0-9]+]]
|
|
; CHECK: %c = add i32 %a, %a
|
|
%a = load i32, i32* %p, !alias.scope !4
|
|
%b = load i32, i32* %p, !alias.scope !5
|
|
%c = add i32 %a, %b
|
|
ret i32 %c
|
|
}
|
|
|
|
; CHECK: ![[SCOPE1]] = !{!{{[0-9]+}}}
|
|
; CHECK: ![[SCOPE2]] = !{!{{[0-9]+}}, !{{[0-9]+}}}
|
|
declare i32 @foo(i32*) readonly
|
|
|
|
!0 = distinct !{!0, !2, !"callee0: %a"}
|
|
!1 = distinct !{!1, !2, !"callee0: %b"}
|
|
!2 = distinct !{!2, !"callee0"}
|
|
|
|
!3 = !{!0}
|
|
!4 = !{!1}
|
|
!5 = !{!0, !1}
|