mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 18:54:02 +01:00
089f3ae98c
`MipsGOTParser` is a helper class that is used to dump MIPS GOT and PLT. There is a problem with it: it might call report_fatal_error() on invalid input. When this happens, the tool reports a crash: ``` # command stderr: LLVM ERROR: Cannot find PLTGOT dynamic table tag. PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backt race. Stack dump: ... ``` Such error were not tested. In this patch I've refactored `MipsGOTParser`: I've splitted handling of GOT and PLT to separate methods. This allows to propagate any possible errors to caller and should allow to dump the PLT when something is wrong with the GOT and vise versa in the future. I've added tests for each `report_fatal_error()` and now calling the `reportError` instead. In the future we might want to switch to reporting warnings, but it requres the additional testing and should be performed independently. I've kept `unwrapOrError` calls untouched for now as I'd like to focus on eliminating `report_fatal_error` calls in this patch only. Differential revision: https://reviews.llvm.org/D83225 |
||
|---|---|---|
| .. | ||
| ARMEHABIPrinter.h | ||
| ARMWinEHPrinter.cpp | ||
| ARMWinEHPrinter.h | ||
| CMakeLists.txt | ||
| COFFDumper.cpp | ||
| COFFImportDumper.cpp | ||
| DwarfCFIEHPrinter.h | ||
| ELFDumper.cpp | ||
| Error.cpp | ||
| Error.h | ||
| llvm-readobj.cpp | ||
| llvm-readobj.h | ||
| LLVMBuild.txt | ||
| MachODumper.cpp | ||
| ObjDumper.cpp | ||
| ObjDumper.h | ||
| StackMapPrinter.h | ||
| WasmDumper.cpp | ||
| Win64EHDumper.cpp | ||
| Win64EHDumper.h | ||
| WindowsResourceDumper.cpp | ||
| WindowsResourceDumper.h | ||
| XCOFFDumper.cpp | ||