mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 20:23:11 +01:00
f873e2ec93
Initial implementation - needs similar work/testing for other tools bugpoint invokes (llc, lli I think, maybe more). Alternatively (as suggested by chandlerc@) an environment variable could be used. This would allow the option to pass transparently through user scripts, pass to compilers if they happened to be LLVM-ish, etc. I worry a bit about using cl::opt in the crash handling code - LLVM might crash early, perhaps before the cl::opt is properly initialized? Or at least before arguments have been parsed? - should be OK since it defaults to "pretty", so if the crash is very early in opt parsing, etc, then crash reports will still be symbolized. I shyed away from doing this with an environment variable when I realized that would require copying the existing environment and appending the env variable of interest. But it seems there's no existing LLVM API for accessing the environment (even the Support tests for process launching have their own ifdefs for getting the environment). It could be added, but seemed like a higher bar/untested codepath to actually add environment variables. Most importantly, this reduces the runtime of test/BugPoint/metadata.ll in a split-dwarf Debug build from 1m34s to 6.5s by avoiding a lot of symbolication. (this wasn't a problem for non-split-dwarf builds only because the executable was too large to map into memory (due to bugpoint setting a 400MB memory (including address space - not sure why? Going to remove that) limit on the child process) so symbolication would fail fast & wouldn't spend all that time parsing DWARF, etc) Reviewers: chandlerc, dannyb Differential Revision: https://reviews.llvm.org/D33804 llvm-svn: 305056
22 lines
1007 B
LLVM
22 lines
1007 B
LLVM
; REQUIRES: loadable_module
|
|
; RUN: echo "import sys" > %t.py
|
|
; RUN: echo "print('args = ' + str(sys.argv))" >> %t.py
|
|
; RUN: echo "exit(1)" >> %t.py
|
|
; RUN: not bugpoint -load %llvmshlibdir/BugpointPasses%shlibext %s -output-prefix %t -bugpoint-crashcalls -opt-command="%python" -opt-args %t.py | FileCheck %s
|
|
; RUN: not --crash opt -load %llvmshlibdir/BugpointPasses%shlibext %s -bugpoint-crashcalls -disable-symbolication 2>&1 | FileCheck --check-prefix=CRASH %s
|
|
|
|
; Test that bugpoint disables symbolication on the opt tool to reduce runtime overhead when opt crashes
|
|
; CHECK: args = {{.*}}'-disable-symbolication'
|
|
|
|
; Test that opt, when it crashes & is passed -disable-symbolication, doesn't symbolicate.
|
|
; In theory this test should maybe be in test/tools/opt or
|
|
; test/Transforms, but since there doesn't seem to be another convenient way to
|
|
; crash opt, apart from the BugpointPasses dynamic plugin, this is the spot for
|
|
; now.
|
|
; CRASH-NOT: Signals.inc
|
|
|
|
define void @f() {
|
|
call void @f()
|
|
ret void
|
|
}
|