mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 20:23:11 +01:00
2ca6c65ad5
passes too many time. I think this is actually the issue that someone raised with me at the developer's meeting and in an email, but that we never really got to the bottom of. Having all the testing utilities made it much easier to dig down and uncover the core issue. When a pass manager is running many passes over a single function, we need it to invalidate the analyses between each run so that they can be re-computed as needed. We also need to track the intersection of preserved higher-level analyses across all the passes that we run (for example, if there is one module analysis which all the function analyses preserve, we want to track that and propagate it). Unfortunately, this interacted poorly with any enclosing pass adaptor between two IR units. It would see the intersection of preserved analyses, and need to invalidate any other analyses, but some of the un-preserved analyses might have already been invalidated *and recomputed*! We would fail to propagate the fact that the analysis had already been invalidated. The solution to this struck me as really strange at first, but the more I thought about it, the more natural it seemed. After a nice discussion with Duncan about it on IRC, it seemed even nicer. The idea is that invalidating an analysis *causes* it to be preserved! Preserving the lack of result is trivial. If it is recomputed, great. Until something *else* invalidates it again, we're good. The consequence of this is that the invalidate methods on the analysis manager which operate over many passes now consume their PreservedAnalyses object, update it to "preserve" every analysis pass to which it delivers an invalidation (regardless of whether the pass chooses to be removed, or handles the invalidation itself by updating itself). Then we return this augmented set from the invalidate routine, letting the pass manager take the result and use the intersection of *that* across each pass run to compute the final preserved set. This accounts for all the places where the early invalidation of an analysis has already "preserved" it for a future run. I've beefed up the testing and adjusted the assertions to show that we no longer repeatedly invalidate or compute the analyses across nested pass managers. llvm-svn: 225333 |
||
|---|---|---|
| .. | ||
| AsmWriter.cpp | ||
| AsmWriter.h | ||
| AttributeImpl.h | ||
| Attributes.cpp | ||
| AutoUpgrade.cpp | ||
| BasicBlock.cpp | ||
| CMakeLists.txt | ||
| Comdat.cpp | ||
| ConstantFold.cpp | ||
| ConstantFold.h | ||
| ConstantRange.cpp | ||
| Constants.cpp | ||
| ConstantsContext.h | ||
| Core.cpp | ||
| DataLayout.cpp | ||
| DebugInfo.cpp | ||
| DebugLoc.cpp | ||
| DiagnosticInfo.cpp | ||
| DiagnosticPrinter.cpp | ||
| DIBuilder.cpp | ||
| Dominators.cpp | ||
| Function.cpp | ||
| GCOV.cpp | ||
| Globals.cpp | ||
| GVMaterializer.cpp | ||
| InlineAsm.cpp | ||
| Instruction.cpp | ||
| Instructions.cpp | ||
| IntrinsicInst.cpp | ||
| IRBuilder.cpp | ||
| IRPrintingPasses.cpp | ||
| LeaksContext.h | ||
| LegacyPassManager.cpp | ||
| LLVMBuild.txt | ||
| LLVMContext.cpp | ||
| LLVMContextImpl.cpp | ||
| LLVMContextImpl.h | ||
| Makefile | ||
| Mangler.cpp | ||
| MDBuilder.cpp | ||
| Metadata.cpp | ||
| MetadataTracking.cpp | ||
| Module.cpp | ||
| module.modulemap | ||
| Pass.cpp | ||
| PassManager.cpp | ||
| PassRegistry.cpp | ||
| Statepoint.cpp | ||
| SymbolTableListTraitsImpl.h | ||
| Type.cpp | ||
| TypeFinder.cpp | ||
| Use.cpp | ||
| UseListOrder.cpp | ||
| User.cpp | ||
| Value.cpp | ||
| ValueSymbolTable.cpp | ||
| ValueTypes.cpp | ||
| Verifier.cpp | ||