mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 04:02:41 +01:00
bb77d317cd
The fix itself is fairly simple: move getAccessVariant to MCValue so that we replace the old weak expression evaluation with the far more general EvaluateAsRelocatable. This then requires that EvaluateAsRelocatable stop when it finds a non trivial reference kind. And that in turn requires the ELF writer to look harder for weak references. Last but not least, this found a case where we were being bug by bug compatible with gas and accepting an invalid input. I reported pr19647 to track it. llvm-svn: 207920
62 lines
1.5 KiB
C++
62 lines
1.5 KiB
C++
//===- lib/MC/MCValue.cpp - MCValue implementation ------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/MC/MCValue.h"
|
|
#include "llvm/MC/MCExpr.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include "llvm/Support/ErrorHandling.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
using namespace llvm;
|
|
|
|
void MCValue::print(raw_ostream &OS, const MCAsmInfo *MAI) const {
|
|
if (isAbsolute()) {
|
|
OS << getConstant();
|
|
return;
|
|
}
|
|
|
|
// FIXME: prints as a number, which isn't ideal. But the meaning will be
|
|
// target-specific anyway.
|
|
if (getRefKind())
|
|
OS << ':' << getRefKind() << ':';
|
|
|
|
getSymA()->print(OS);
|
|
|
|
if (getSymB()) {
|
|
OS << " - ";
|
|
getSymB()->print(OS);
|
|
}
|
|
|
|
if (getConstant())
|
|
OS << " + " << getConstant();
|
|
}
|
|
|
|
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
|
|
void MCValue::dump() const {
|
|
print(dbgs(), nullptr);
|
|
}
|
|
#endif
|
|
|
|
MCSymbolRefExpr::VariantKind MCValue::getAccessVariant() const {
|
|
const MCSymbolRefExpr *B = getSymB();
|
|
if (B) {
|
|
if (B->getKind() != MCSymbolRefExpr::VK_None)
|
|
llvm_unreachable("unsupported");
|
|
}
|
|
|
|
const MCSymbolRefExpr *A = getSymA();
|
|
if (!A)
|
|
return MCSymbolRefExpr::VK_None;
|
|
|
|
MCSymbolRefExpr::VariantKind Kind = A->getKind();
|
|
if (Kind == MCSymbolRefExpr::VK_WEAKREF)
|
|
return MCSymbolRefExpr::VK_None;
|
|
return Kind;
|
|
}
|