mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-02-01 05:01:59 +01:00
dce7717f79
Summary:
Testing of caret location in diagnostic message is currently made with
CHECK directive with the following general format:
CHECK: {{^ \^$}}
James Henderson suggested the following would be more readable:
CHECK: {{^}} ^{{$}}
and when whole lines can be matched (as is the case for command-line
testing where error messages do not include path):
CHECK: ^
using the option --match-full-lines.
This commit implements these 2 changes on all existing caret position
tests. It also aligns the caret to the character it is trying to match
in the above line.
Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk
Subscribers: JonChesterfield, rogfer01, hfinkel, kristina, rnk, tra, arichardson, grimar, dblaikie, probinson, llvm-commits, hiraditya
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D64923
> llvm-svn: 366861
llvm-svn: 366898
26 lines
1.3 KiB
Plaintext
26 lines
1.3 KiB
Plaintext
; Test incorrect syntax for -D# option is correctly diagnosed.
|
|
|
|
; Invalid variable name: starts with a digit.
|
|
RUN: not FileCheck -D#10VALUE=10 --input-file %s %s 2>&1 \
|
|
RUN: | FileCheck %s --strict-whitespace --match-full-lines --check-prefix NUMERRCLIFMT
|
|
|
|
NUMERRCLIFMT:Global defines:1:46: error: invalid variable name
|
|
NUMERRCLIFMT-NEXT:Global define #1: #10VALUE=10 (parsed as: {{\[\[#10VALUE:10\]\]}})
|
|
NUMERRCLIFMT-NEXT: ^
|
|
|
|
; Invalid definition of pseudo variable.
|
|
RUN: not FileCheck -D#@VALUE=10 --input-file %s %s 2>&1 \
|
|
RUN: | FileCheck %s --strict-whitespace --match-full-lines --check-prefix NUMERRCLIPSEUDO
|
|
|
|
NUMERRCLIPSEUDO:Global defines:1:45: error: definition of pseudo numeric variable unsupported
|
|
NUMERRCLIPSEUDO-NEXT:Global define #1: #@VALUE=10 (parsed as: {{\[\[#@VALUE:10\]\]}})
|
|
NUMERRCLIPSEUDO-NEXT: ^
|
|
|
|
; Invalid definition of an expression.
|
|
RUN: not FileCheck -D#VALUE+2=10 --input-file %s %s 2>&1 \
|
|
RUN: | FileCheck %s --strict-whitespace --match-full-lines --check-prefix NUMERRCLITRAIL
|
|
|
|
NUMERRCLITRAIL:Global defines:1:51: error: unexpected characters after numeric variable name
|
|
NUMERRCLITRAIL-NEXT:Global define #1: #VALUE+2=10 (parsed as: {{\[\[#VALUE\+2:10\]\]}})
|
|
NUMERRCLITRAIL-NEXT: ^
|