mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-02-01 05:01:59 +01:00
60c8d3580e
Currently, YAML has the following syntax for describing the symbols:
Symbols:
Local:
LocalSymbol1:
...
LocalSymbol2:
...
...
Global:
GlobalSymbol1:
...
Weak:
...
GNUUnique:
I.e. symbols are grouped by their bindings. That is not very convenient,
because:
It does not allow to set a custom binding, what can be useful for producing
broken/special outputs for test cases. Adding a new binding would require to
change a syntax (what we observed when added GNUUnique recently).
It does not allow to change the order of the symbols in .symtab/.dynsym,
i.e. currently all Local symbols are placed first, then Global, Weak and GNUUnique
are following, but we are not able to change the order.
It is not consistent. Binding is just one of the properties of the symbol,
we do not group them by other properties.
It makes the code more complex that it can be. This patch shows it can be simplified
with the change performed.
The patch changes the syntax to just:
Symbols:
Symbol1:
...
Symbol2:
...
...
With that, we are able to work with the binding field just like with any other symbol property.
Differential revision: https://reviews.llvm.org/D60122
llvm-svn: 357595
37 lines
1014 B
YAML
37 lines
1014 B
YAML
# Test that a relocation's symbol can be an integer.
|
|
# RUN: yaml2obj %s > %t
|
|
# LLVM tools (both llvm-readobj and llvm-objdump) reject relocations with
|
|
# invalid symbol indexes, so inspect the hex contents instead.
|
|
# RUN: llvm-readobj -x .rela.text %t | FileCheck %s
|
|
|
|
# CHECK: Hex dump of section '.rela.text':
|
|
# CHECK-NEXT: 0x00000000 00000000 00000000 02000000 42000000
|
|
# Symbol index 0x42 --^
|
|
# CHECK-NEXT: 0x00000010 00000000 00000000 00000000 00000000
|
|
# CHECK-NEXT: 0x00000020 02000000 01000000 00000000 00000000
|
|
# Symbol index 0x01 --^
|
|
|
|
--- !ELF
|
|
FileHeader:
|
|
Class: ELFCLASS64
|
|
Data: ELFDATA2LSB
|
|
Type: ET_REL
|
|
Machine: EM_X86_64
|
|
Sections:
|
|
- Name: .text
|
|
Type: SHT_PROGBITS
|
|
- Name: .rela.text
|
|
Type: SHT_RELA
|
|
Info: .text
|
|
Link: .symtab
|
|
Relocations:
|
|
- Type: R_X86_64_PC32
|
|
Offset: 0
|
|
Symbol: 0x42
|
|
- Type: R_X86_64_PC32
|
|
Offset: 0
|
|
Symbol: 0x1
|
|
Symbols:
|
|
- Name: foo
|
|
Binding: STB_GLOBAL
|