mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-02-01 05:01:59 +01:00
279a200561
That patch is the fix for https://bugs.llvm.org/show_bug.cgi?id=40703 "wrong line number info for obj file compiled with -ffunction-sections" bug. The problem happened with only .o files. If object file contains several .text sections then line number information showed incorrectly. The reason for this is that DwarfLineTable could not detect section which corresponds to specified address(because address is the local to the section). And as the result it could not select proper sequence in the line table. The fix is to pass SectionIndex with the address. So that it would be possible to differentiate addresses from various sections. With this fix llvm-objdump shows correct line numbers for disassembled code. Differential review: https://reviews.llvm.org/D58194 llvm-svn: 354972
120 lines
4.5 KiB
C++
120 lines
4.5 KiB
C++
//===-- PDBContext.cpp ------------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===/
|
|
|
|
#include "llvm/DebugInfo/PDB/PDBContext.h"
|
|
#include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"
|
|
#include "llvm/DebugInfo/PDB/IPDBLineNumber.h"
|
|
#include "llvm/DebugInfo/PDB/IPDBSourceFile.h"
|
|
#include "llvm/DebugInfo/PDB/PDBSymbol.h"
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolData.h"
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolFunc.h"
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolPublicSymbol.h"
|
|
#include "llvm/Object/COFF.h"
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::object;
|
|
using namespace llvm::pdb;
|
|
|
|
PDBContext::PDBContext(const COFFObjectFile &Object,
|
|
std::unique_ptr<IPDBSession> PDBSession)
|
|
: DIContext(CK_PDB), Session(std::move(PDBSession)) {
|
|
ErrorOr<uint64_t> ImageBase = Object.getImageBase();
|
|
if (ImageBase)
|
|
Session->setLoadAddress(ImageBase.get());
|
|
}
|
|
|
|
void PDBContext::dump(raw_ostream &OS, DIDumpOptions DumpOpts){}
|
|
|
|
DILineInfo PDBContext::getLineInfoForAddress(object::SectionedAddress Address,
|
|
DILineInfoSpecifier Specifier) {
|
|
DILineInfo Result;
|
|
Result.FunctionName = getFunctionName(Address.Address, Specifier.FNKind);
|
|
|
|
uint32_t Length = 1;
|
|
std::unique_ptr<PDBSymbol> Symbol =
|
|
Session->findSymbolByAddress(Address.Address, PDB_SymType::None);
|
|
if (auto Func = dyn_cast_or_null<PDBSymbolFunc>(Symbol.get())) {
|
|
Length = Func->getLength();
|
|
} else if (auto Data = dyn_cast_or_null<PDBSymbolData>(Symbol.get())) {
|
|
Length = Data->getLength();
|
|
}
|
|
|
|
// If we couldn't find a symbol, then just assume 1 byte, so that we get
|
|
// only the line number of the first instruction.
|
|
auto LineNumbers = Session->findLineNumbersByAddress(Address.Address, Length);
|
|
if (!LineNumbers || LineNumbers->getChildCount() == 0)
|
|
return Result;
|
|
|
|
auto LineInfo = LineNumbers->getNext();
|
|
assert(LineInfo);
|
|
auto SourceFile = Session->getSourceFileById(LineInfo->getSourceFileId());
|
|
|
|
if (SourceFile &&
|
|
Specifier.FLIKind != DILineInfoSpecifier::FileLineInfoKind::None)
|
|
Result.FileName = SourceFile->getFileName();
|
|
Result.Column = LineInfo->getColumnNumber();
|
|
Result.Line = LineInfo->getLineNumber();
|
|
return Result;
|
|
}
|
|
|
|
DILineInfoTable
|
|
PDBContext::getLineInfoForAddressRange(object::SectionedAddress Address,
|
|
uint64_t Size,
|
|
DILineInfoSpecifier Specifier) {
|
|
if (Size == 0)
|
|
return DILineInfoTable();
|
|
|
|
DILineInfoTable Table;
|
|
auto LineNumbers = Session->findLineNumbersByAddress(Address.Address, Size);
|
|
if (!LineNumbers || LineNumbers->getChildCount() == 0)
|
|
return Table;
|
|
|
|
while (auto LineInfo = LineNumbers->getNext()) {
|
|
DILineInfo LineEntry = getLineInfoForAddress(
|
|
{LineInfo->getVirtualAddress(), Address.SectionIndex}, Specifier);
|
|
Table.push_back(std::make_pair(LineInfo->getVirtualAddress(), LineEntry));
|
|
}
|
|
return Table;
|
|
}
|
|
|
|
DIInliningInfo
|
|
PDBContext::getInliningInfoForAddress(object::SectionedAddress Address,
|
|
DILineInfoSpecifier Specifier) {
|
|
DIInliningInfo InlineInfo;
|
|
DILineInfo Frame = getLineInfoForAddress(Address, Specifier);
|
|
InlineInfo.addFrame(Frame);
|
|
return InlineInfo;
|
|
}
|
|
|
|
std::string PDBContext::getFunctionName(uint64_t Address,
|
|
DINameKind NameKind) const {
|
|
if (NameKind == DINameKind::None)
|
|
return std::string();
|
|
|
|
std::unique_ptr<PDBSymbol> FuncSymbol =
|
|
Session->findSymbolByAddress(Address, PDB_SymType::Function);
|
|
auto *Func = dyn_cast_or_null<PDBSymbolFunc>(FuncSymbol.get());
|
|
|
|
if (NameKind == DINameKind::LinkageName) {
|
|
// It is not possible to get the mangled linkage name through a
|
|
// PDBSymbolFunc. For that we have to specifically request a
|
|
// PDBSymbolPublicSymbol.
|
|
auto PublicSym =
|
|
Session->findSymbolByAddress(Address, PDB_SymType::PublicSymbol);
|
|
if (auto *PS = dyn_cast_or_null<PDBSymbolPublicSymbol>(PublicSym.get())) {
|
|
// If we also have a function symbol, prefer the use of public symbol name
|
|
// only if it refers to the same address. The public symbol uses the
|
|
// linkage name while the function does not.
|
|
if (!Func || Func->getVirtualAddress() == PS->getVirtualAddress())
|
|
return PS->getName();
|
|
}
|
|
}
|
|
|
|
return Func ? Func->getName() : std::string();
|
|
}
|