mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-01-31 20:51:52 +01:00
5d27c8ae50
It's common for code that manipulates the stack via inline assembly or that has to set up its own stack canary (such as the Linux kernel) would like to avoid stack protectors in certain functions. In this case, we've been bitten by numerous bugs where a callee with a stack protector is inlined into an attribute((no_stack_protector)) caller, which generally breaks the caller's assumptions about not having a stack protector. LTO exacerbates the issue. While developers can avoid this by putting all no_stack_protector functions in one translation unit together and compiling those with -fno-stack-protector, it's generally not very ergonomic or as ergonomic as a function attribute, and still doesn't work for LTO. See also: https://lore.kernel.org/linux-pm/20200915172658.1432732-1-rkir@google.com/ https://lore.kernel.org/lkml/20200918201436.2932360-30-samitolvanen@google.com/T/#u SSP attributes can be ordered by strength. Weakest to strongest, they are: ssp, sspstrong, sspreq. Callees with differing SSP attributes may be inlined into each other, and the strongest attribute will be applied to the caller. (No change) After this change: * A callee with no SSP attributes will no longer be inlined into a caller with SSP attributes. * The reverse is also true: a callee with an SSP attribute will not be inlined into a caller with no SSP attributes. * The alwaysinline attribute overrides these rules. Functions that get synthesized by the compiler may not get inlined as a result if they are not created with the same stack protector function attribute as their callers. Alternative approach to https://reviews.llvm.org/D87956. Fixes pr/47479. Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed By: rnk, MaskRay Differential Revision: https://reviews.llvm.org/D91816
87 lines
2.5 KiB
LLVM
87 lines
2.5 KiB
LLVM
; RUN: opt < %s -S -partial-inliner -skip-partial-inlining-cost-analysis=true | FileCheck %s
|
|
|
|
|
|
define i32 @callee_most(i32 %v) unnamed_addr #0 #1 {
|
|
entry:
|
|
%cmp = icmp sgt i32 %v, 2000
|
|
br i1 %cmp, label %if.then, label %if.end
|
|
|
|
if.then:
|
|
br label %if.then2
|
|
|
|
if.then2:
|
|
%sub = sub i32 %v, 10
|
|
br label %if.end
|
|
|
|
if.end:
|
|
%v2 = phi i32 [ %v, %entry ], [ %sub, %if.then2 ]
|
|
%add = add nsw i32 %v2, 200
|
|
ret i32 %add
|
|
}
|
|
|
|
define i32 @callee_noinline(i32 %v) optnone noinline {
|
|
entry:
|
|
%cmp = icmp sgt i32 %v, 2000
|
|
br i1 %cmp, label %if.then, label %if.end
|
|
|
|
if.then:
|
|
br label %if.then2
|
|
|
|
if.then2:
|
|
%sub = sub i32 %v, 10
|
|
br label %if.end
|
|
|
|
if.end:
|
|
%v2 = phi i32 [ %v, %entry ], [ %sub, %if.then2 ]
|
|
%add = add nsw i32 %v2, 200
|
|
ret i32 %add
|
|
}
|
|
|
|
define i32 @callee_writeonly(i32 %v) writeonly ssp {
|
|
entry:
|
|
%cmp = icmp sgt i32 %v, 2000
|
|
br i1 %cmp, label %if.then, label %if.end
|
|
|
|
if.then:
|
|
br label %if.then2
|
|
|
|
if.then2:
|
|
%sub = sub i32 %v, 10
|
|
br label %if.end
|
|
|
|
if.end:
|
|
%v2 = phi i32 [ %v, %entry ], [ %sub, %if.then2 ]
|
|
%add = add nsw i32 %v2, 200
|
|
ret i32 %add
|
|
}
|
|
; CHECK-LABEL: @caller
|
|
; CHECK: call void @callee_most.2.if.then(i32 %v
|
|
; CHECK: call i32 @callee_noinline(i32 %v)
|
|
; CHECK: call void @callee_writeonly.1.if.then(i32 %v
|
|
define i32 @caller(i32 %v) ssp {
|
|
entry:
|
|
%c1 = call i32 @callee_most(i32 %v)
|
|
%c2 = call i32 @callee_noinline(i32 %v)
|
|
%c3 = call i32 @callee_writeonly(i32 %v)
|
|
ret i32 %c3
|
|
}
|
|
|
|
; CHECK: define internal void @callee_writeonly.1.if.then(i32 %v, i32* %sub.out) [[FN_ATTRS0:#[0-9]+]]
|
|
; CHECK: define internal void @callee_most.2.if.then(i32 %v, i32* %sub.out) [[FN_ATTRS:#[0-9]+]]
|
|
|
|
; attributes to preserve
|
|
attributes #0 = {
|
|
inlinehint minsize noduplicate noimplicitfloat norecurse noredzone nounwind
|
|
nonlazybind optsize safestack sanitize_address sanitize_hwaddress sanitize_memory
|
|
sanitize_thread ssp sspreq sspstrong strictfp uwtable "foo"="bar"
|
|
"patchable-function"="prologue-short-redirect" "probe-stack"="_foo_guard" "stack-probe-size"="4096" }
|
|
|
|
; CHECK: attributes [[FN_ATTRS0]] = { ssp
|
|
; CHECK: attributes [[FN_ATTRS]] = { inlinehint minsize noduplicate noimplicitfloat norecurse noredzone nounwind nonlazybind optsize safestack sanitize_address sanitize_hwaddress sanitize_memory sanitize_thread ssp sspreq sspstrong strictfp uwtable "foo"="bar" "patchable-function"="prologue-short-redirect" "probe-stack"="_foo_guard" "stack-probe-size"="4096" }
|
|
|
|
; attributes to drop
|
|
attributes #1 = {
|
|
alignstack=16 convergent inaccessiblememonly inaccessiblemem_or_argmemonly naked
|
|
noreturn readonly argmemonly returns_twice speculatable "thunk"
|
|
}
|