mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 19:12:56 +02:00
bce1b9a58d
Summary: In a .symver assembler directive like: .symver name, name2@@nodename "name2@@nodename" should get the same symbol binding as "name". While the ELF object writer is updating the symbol binding for .symver aliases before emitting the object file, not doing so when the module inline assembly is handled by the RecordStreamer is causing the wrong behavior in *LTO mode. E.g. when "name" is global, "name2@@nodename" must also be marked as global. Otherwise, the symbol is skipped when iterating over the LTO InputFile symbols (InputFile::Symbol::shouldSkip). So, for example, when performing any *LTO via the gold-plugin, the versioned symbol definition is not recorded by the plugin and passed back to the linker. If the object was in an archive, and there were no other symbols needed from that object, the object would not be included in the final link and references to the versioned symbol are undefined. The llvm-lto2 tests added will give an error about an unused symbol resolution without the fix. Reviewers: rafael, pcc Reviewed By: pcc Subscribers: mehdi_amini, llvm-commits Differential Revision: https://reviews.llvm.org/D30485 llvm-svn: 297332
63 lines
1.7 KiB
C++
63 lines
1.7 KiB
C++
//===- ModuleSymbolTable.h - symbol table for in-memory IR ----------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This class represents a symbol table built from in-memory IR. It provides
|
|
// access to GlobalValues and should only be used if such access is required
|
|
// (e.g. in the LTO implementation).
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_OBJECT_MODULESYMBOLTABLE_H
|
|
#define LLVM_OBJECT_MODULESYMBOLTABLE_H
|
|
|
|
#include "llvm/ADT/PointerUnion.h"
|
|
#include "llvm/ADT/Triple.h"
|
|
#include "llvm/IR/Mangler.h"
|
|
#include "llvm/Object/SymbolicFile.h"
|
|
#include <string>
|
|
#include <utility>
|
|
|
|
namespace llvm {
|
|
|
|
class GlobalValue;
|
|
class RecordStreamer;
|
|
|
|
class ModuleSymbolTable {
|
|
public:
|
|
typedef std::pair<std::string, uint32_t> AsmSymbol;
|
|
typedef PointerUnion<GlobalValue *, AsmSymbol *> Symbol;
|
|
|
|
private:
|
|
Module *FirstMod = nullptr;
|
|
|
|
SpecificBumpPtrAllocator<AsmSymbol> AsmSymbols;
|
|
std::vector<Symbol> SymTab;
|
|
Mangler Mang;
|
|
|
|
public:
|
|
ArrayRef<Symbol> symbols() const { return SymTab; }
|
|
void addModule(Module *M);
|
|
|
|
void printSymbolName(raw_ostream &OS, Symbol S) const;
|
|
uint32_t getSymbolFlags(Symbol S) const;
|
|
|
|
/// Parse inline ASM and collect the symbols that are defined or referenced in
|
|
/// the current module.
|
|
///
|
|
/// For each found symbol, call \p AsmSymbol with the name of the symbol found
|
|
/// and the associated flags.
|
|
static void CollectAsmSymbols(
|
|
const Module &M,
|
|
function_ref<void(StringRef, object::BasicSymbolRef::Flags)> AsmSymbol);
|
|
};
|
|
|
|
}
|
|
|
|
#endif
|