mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-22 12:33:33 +02:00
0c1aee0b16
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
35 lines
1.6 KiB
LLVM
35 lines
1.6 KiB
LLVM
; RUN: llc %s -O0 -o /dev/null -mtriple=x86_64-apple-darwin
|
|
; PR 5197
|
|
; There is not any llvm instruction assocated with !5. The code generator
|
|
; should be able to handle this.
|
|
|
|
define void @bar() nounwind ssp {
|
|
entry:
|
|
%count_ = alloca i32, align 4 ; <i32*> [#uses=2]
|
|
br label %do.body, !dbg !0
|
|
|
|
do.body: ; preds = %entry
|
|
call void @llvm.dbg.declare(metadata i32* %count_, metadata !4, metadata !DIExpression()), !dbg !DILocation(scope: !5)
|
|
%conv = ptrtoint i32* %count_ to i32, !dbg !0 ; <i32> [#uses=1]
|
|
%call = call i32 @foo(i32 %conv) ssp, !dbg !0 ; <i32> [#uses=0]
|
|
br label %do.end, !dbg !0
|
|
|
|
do.end: ; preds = %do.body
|
|
ret void, !dbg !7
|
|
}
|
|
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata) nounwind readnone
|
|
|
|
declare i32 @foo(i32) ssp
|
|
|
|
!0 = !DILocation(line: 5, column: 2, scope: !1)
|
|
!1 = distinct !DILexicalBlock(line: 1, column: 1, file: null, scope: !2)
|
|
!2 = distinct !DISubprogram(name: "bar", linkageName: "bar", line: 4, isLocal: false, isDefinition: true, virtualIndex: 6, isOptimized: false, scope: !3)
|
|
!3 = distinct !DICompileUnit(language: DW_LANG_C99, producer: "clang 1.1", isOptimized: true, emissionKind: 0, file: !8, retainedTypes: !9)
|
|
!4 = !DILocalVariable(name: "count_", line: 5, scope: !5, file: !3, type: !6)
|
|
!5 = distinct !DILexicalBlock(line: 1, column: 1, file: null, scope: !1)
|
|
!6 = !DIBasicType(tag: DW_TAG_base_type, name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!7 = !DILocation(line: 6, column: 1, scope: !2)
|
|
!8 = !DIFile(filename: "genmodes.i", directory: "/Users/yash/Downloads")
|
|
!9 = !{i32 0}
|