mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-20 11:33:24 +02:00
0c1aee0b16
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
72 lines
3.3 KiB
LLVM
72 lines
3.3 KiB
LLVM
; DWARF linkage name attributes are optional; verify they are missing for
|
|
; PS4 triple or when tuning for SCE.
|
|
|
|
; RUN: llc -O0 -mtriple=x86_64-unknown-unknown < %s | FileCheck %s -check-prefix LINKAGE1
|
|
; RUN: llc -O0 -mtriple=x86_64-unknown-unknown < %s | FileCheck %s -check-prefix LINKAGE2
|
|
; RUN: llc -O0 -mtriple=x86_64-scei-ps4 < %s | FileCheck %s -check-prefix NOLINKAGE
|
|
; RUN: llc -O0 -mtriple=x86_64-unknown-unknown -debugger-tune=sce < %s | FileCheck %s -check-prefix NOLINKAGE
|
|
|
|
; $ clang++ -emit-llvm -S -g dwarf-linkage-names.cpp
|
|
; namespace test {
|
|
; int global_var;
|
|
; int bar() { return global_var; }
|
|
;};
|
|
|
|
; With linkage names, we get an attribute for the declaration (first) entry
|
|
; for the global variable, and one for the function.
|
|
|
|
; This assumes the variable will appear before the function.
|
|
; LINKAGE1: .section .debug_info
|
|
; LINKAGE1: DW_TAG_variable
|
|
; LINKAGE1-NOT: DW_TAG
|
|
; LINKAGE1: {{DW_AT_(MIPS_)?linkage_name}}
|
|
; LINKAGE1: DW_TAG_subprogram
|
|
; LINKAGE1-NOT: DW_TAG
|
|
; LINKAGE1: {{DW_AT_(MIPS_)?linkage_name}}
|
|
; LINKAGE1: .section
|
|
|
|
; Also verify we see the mangled names. We do this as a separate pass to
|
|
; avoid depending on the order of .debug_info and .debug_str sections.
|
|
|
|
; LINKAGE2-DAG: .asciz "_ZN4test10global_varE"
|
|
; LINKAGE2-DAG: .asciz "_ZN4test3barEv"
|
|
|
|
; Without linkage names, verify there aren't any linkage-name attributes,
|
|
; and no mangled names.
|
|
|
|
; NOLINKAGE-NOT: {{DW_AT_(MIPS_)?linkage_name}}
|
|
; NOLINKAGE-NOT: .asciz "_ZN4test10global_varE"
|
|
; NOLINKAGE-NOT: .asciz "_ZN4test3barEv"
|
|
|
|
@_ZN4test10global_varE = global i32 0, align 4
|
|
|
|
; Function Attrs: nounwind uwtable
|
|
define i32 @_ZN4test3barEv() #0 {
|
|
entry:
|
|
%0 = load i32, i32* @_ZN4test10global_varE, align 4, !dbg !14
|
|
ret i32 %0, !dbg !15
|
|
}
|
|
|
|
attributes #0 = { nounwind uwtable "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+sse,+sse2" "unsafe-fp-math"="false" "use-soft-float"="false" }
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!11, !12}
|
|
!llvm.ident = !{!13}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1, producer: "clang version 3.8.0 (trunk 244662)", isOptimized: false, runtimeVersion: 0, emissionKind: 1, enums: !2, subprograms: !3, globals: !9)
|
|
!1 = !DIFile(filename: "dwarf-linkage-names.cpp", directory: "/home/probinson/projects/scratch")
|
|
!2 = !{}
|
|
!3 = !{!4}
|
|
!4 = distinct !DISubprogram(name: "bar", linkageName: "_ZN4test3barEv", scope: !5, file: !1, line: 3, type: !6, isLocal: false, isDefinition: true, scopeLine: 3, flags: DIFlagPrototyped, isOptimized: false, function: i32 ()* @_ZN4test3barEv, variables: !2)
|
|
!5 = !DINamespace(name: "test", scope: null, file: !1, line: 1)
|
|
!6 = !DISubroutineType(types: !7)
|
|
!7 = !{!8}
|
|
!8 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!9 = !{!10}
|
|
!10 = !DIGlobalVariable(name: "global_var", linkageName: "_ZN4test10global_varE", scope: !5, file: !1, line: 2, type: !8, isLocal: false, isDefinition: true, variable: i32* @_ZN4test10global_varE)
|
|
!11 = !{i32 2, !"Dwarf Version", i32 4}
|
|
!12 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!13 = !{!"clang version 3.8.0 (trunk 244662)"}
|
|
!14 = !DILocation(line: 3, column: 21, scope: !4)
|
|
!15 = !DILocation(line: 3, column: 14, scope: !4)
|