mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 11:02:59 +02:00
c686f0d8f2
This version of the patch includes a fix addressing a stage2 LTO buildbot
failure and addressed some additional nits.
Original commit message:
This updates the SCCP solver to use of the ValueElement lattice for
parameters, which provides integer range information. The range
information is used to remove unneeded icmp instructions.
For the following function, f() can be optimized to ret i32 2 with
this change
source_filename = "sccp.c"
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
; Function Attrs: norecurse nounwind readnone uwtable
define i32 @main() local_unnamed_addr #0 {
entry:
%call = tail call fastcc i32 @f(i32 1)
%call1 = tail call fastcc i32 @f(i32 47)
%add3 = add nsw i32 %call, %call1
ret i32 %add3
}
; Function Attrs: noinline norecurse nounwind readnone uwtable
define internal fastcc i32 @f(i32 %x) unnamed_addr #1 {
entry:
%c1 = icmp sle i32 %x, 100
%cmp = icmp sgt i32 %x, 300
%. = select i1 %cmp, i32 1, i32 2
ret i32 %.
}
attributes #1 = { noinline }
Reviewers: davide, sanjoy, efriedma, dberlin
Reviewed By: davide, dberlin
Subscribers: mcrosier, gberry, mssimpso, dberlin, llvm-commits
Differential Revision: https://reviews.llvm.org/D36656
llvm-svn: 316891
144 lines
3.6 KiB
LLVM
144 lines
3.6 KiB
LLVM
; RUN: opt < %s -ipsccp -S | FileCheck %s
|
|
|
|
; Constant range for %a is [1, 48) and for %b is [301, 1000)
|
|
; CHECK-LABEL: f1
|
|
; CHECK-NOT: icmp
|
|
; CHECK: %a.1 = select i1 false, i32 1, i32 2
|
|
; CHECK: %b.1 = select i1 true, i32 1, i32 2
|
|
; CHECK: %a.2 = select i1 false, i32 1, i32 2
|
|
; CHECK: %b.2 = select i1 true, i32 1, i32 2
|
|
define internal i32 @f1(i32 %a, i32 %b) {
|
|
entry:
|
|
%cmp.a = icmp sgt i32 %a, 300
|
|
%cmp.b = icmp sgt i32 %b, 300
|
|
%cmp.a2 = icmp ugt i32 %a, 300
|
|
%cmp.b2 = icmp ugt i32 %b, 300
|
|
|
|
%a.1 = select i1 %cmp.a, i32 1, i32 2
|
|
%b.1 = select i1 %cmp.b, i32 1, i32 2
|
|
%a.2 = select i1 %cmp.a2, i32 1, i32 2
|
|
%b.2 = select i1 %cmp.b2, i32 1, i32 2
|
|
%res1 = add i32 %a.1, %b.1
|
|
%res2 = add i32 %a.2, %b.2
|
|
%res3 = add i32 %res1, %res2
|
|
ret i32 %res3
|
|
}
|
|
|
|
; Constant range for %x is [47, 302)
|
|
; CHECK-LABEL: f2
|
|
; CHECK: %cmp = icmp sgt i32 %x, 300
|
|
; CHECK: %res1 = select i1 %cmp, i32 1, i32 2
|
|
; CHECK-NEXT: %res2 = select i1 true, i32 3, i32 4
|
|
; CHECK-NEXT: %res3 = select i1 true, i32 5, i32 6
|
|
; CHECK-NEXT: %res4 = select i1 %cmp4, i32 3, i32 4
|
|
; CHECK-NEXT: %res5 = select i1 true, i32 5, i32 6
|
|
define internal i32 @f2(i32 %x) {
|
|
entry:
|
|
%cmp = icmp sgt i32 %x, 300
|
|
%cmp2 = icmp ne i32 %x, 10
|
|
%cmp3 = icmp sge i32 %x, 47
|
|
%cmp4 = icmp ugt i32 %x, 300
|
|
%cmp5 = icmp uge i32 %x, 47
|
|
%res1 = select i1 %cmp, i32 1, i32 2
|
|
%res2 = select i1 %cmp2, i32 3, i32 4
|
|
%res3 = select i1 %cmp3, i32 5, i32 6
|
|
%res4 = select i1 %cmp4, i32 3, i32 4
|
|
%res5 = select i1 %cmp5, i32 5, i32 6
|
|
|
|
%res6 = add i32 %res1, %res2
|
|
%res7 = add i32 %res3, %res4
|
|
%res = add i32 %res6, %res5
|
|
ret i32 %res
|
|
}
|
|
|
|
define i32 @caller1() {
|
|
entry:
|
|
%call1 = tail call i32 @f1(i32 1, i32 301)
|
|
%call2 = tail call i32 @f1(i32 47, i32 999)
|
|
%call3 = tail call i32 @f2(i32 47)
|
|
%call4 = tail call i32 @f2(i32 301)
|
|
%res = add nsw i32 %call1, %call2
|
|
%res.1 = add nsw i32 %res, %call3
|
|
%res.2 = add nsw i32 %res.1, %call4
|
|
ret i32 %res.2
|
|
}
|
|
|
|
; x is overdefined, because constant ranges are only used for parameter
|
|
; values.
|
|
; CHECK-LABEL: f3
|
|
; CHECK: %cmp = icmp sgt i32 %x, 300
|
|
; CHECK: %res = select i1 %cmp, i32 1, i32 2
|
|
; CHECK: ret i32 %res
|
|
define internal i32 @f3(i32 %x) {
|
|
entry:
|
|
%cmp = icmp sgt i32 %x, 300
|
|
%res = select i1 %cmp, i32 1, i32 2
|
|
ret i32 %res
|
|
}
|
|
|
|
; The phi node could be converted in a ConstantRange.
|
|
define i32 @caller2(i1 %cmp) {
|
|
entry:
|
|
br i1 %cmp, label %if.true, label %end
|
|
|
|
if.true:
|
|
br label %end
|
|
|
|
end:
|
|
%res = phi i32 [ 0, %entry], [ 1, %if.true ]
|
|
%call1 = tail call i32 @f3(i32 %res)
|
|
ret i32 %call1
|
|
}
|
|
|
|
; CHECK-LABEL: f4
|
|
; CHECK: %cmp = icmp sgt i32 %x, 300
|
|
; CHECK: %res = select i1 %cmp, i32 1, i32 2
|
|
; CHECK: ret i32 %res
|
|
define internal i32 @f4(i32 %x) {
|
|
entry:
|
|
%cmp = icmp sgt i32 %x, 300
|
|
%res = select i1 %cmp, i32 1, i32 2
|
|
ret i32 %res
|
|
}
|
|
|
|
; ICmp could introduce bounds on ConstantRanges.
|
|
define i32 @caller3(i32 %x) {
|
|
entry:
|
|
%cmp = icmp sgt i32 %x, 300
|
|
br i1 %cmp, label %if.true, label %end
|
|
|
|
if.true:
|
|
%x.1 = tail call i32 @f4(i32 %x)
|
|
br label %end
|
|
|
|
end:
|
|
%res = phi i32 [ 0, %entry], [ %x.1, %if.true ]
|
|
ret i32 %res
|
|
}
|
|
|
|
; Check to make sure we do not attempt to access lattice values in unreachable
|
|
; blocks.
|
|
define i32 @test_unreachable() {
|
|
entry:
|
|
call i1 @test_unreachable_callee(i32 1)
|
|
call i1 @test_unreachable_callee(i32 2)
|
|
ret i32 1
|
|
}
|
|
|
|
define internal i1 @test_unreachable_callee(i32 %a) {
|
|
entry:
|
|
ret i1 true
|
|
|
|
unreachablebb:
|
|
%cmp = icmp eq i32 undef, %a
|
|
unreachable
|
|
}
|
|
|
|
; Check that we do not attempt to get range info for non-integer types and
|
|
; crash.
|
|
define double @test_struct({ double, double } %test) {
|
|
%v = extractvalue { double, double } %test, 0
|
|
%r = fmul double %v, %v
|
|
ret double %r
|
|
}
|