mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-24 19:52:54 +01:00
f8a414589e
Summary: This clang-tidy check is looking for unsigned integer variables whose initializer starts with an implicit cast from llvm::Register and changes the type of the variable to llvm::Register (dropping the llvm:: where possible). Partial reverts in: X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned& MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register PPCFastISel.cpp - No Register::operator-=() PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned& MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor Manual fixups in: ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned& HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register. PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned& Depends on D65919 Reviewers: arsenm, bogner, craig.topper, RKSimon Reviewed By: arsenm Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D65962 llvm-svn: 369041
175 lines
6.2 KiB
C++
175 lines
6.2 KiB
C++
//===- DeadMachineInstructionElim.cpp - Remove dead machine instructions --===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This is an extremely simple MachineInstr-level dead-code-elimination pass.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/ADT/Statistic.h"
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
#include "llvm/CodeGen/Passes.h"
|
|
#include "llvm/CodeGen/TargetSubtargetInfo.h"
|
|
#include "llvm/Pass.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
using namespace llvm;
|
|
|
|
#define DEBUG_TYPE "dead-mi-elimination"
|
|
|
|
STATISTIC(NumDeletes, "Number of dead instructions deleted");
|
|
|
|
namespace {
|
|
class DeadMachineInstructionElim : public MachineFunctionPass {
|
|
bool runOnMachineFunction(MachineFunction &MF) override;
|
|
|
|
const TargetRegisterInfo *TRI;
|
|
const MachineRegisterInfo *MRI;
|
|
const TargetInstrInfo *TII;
|
|
BitVector LivePhysRegs;
|
|
|
|
public:
|
|
static char ID; // Pass identification, replacement for typeid
|
|
DeadMachineInstructionElim() : MachineFunctionPass(ID) {
|
|
initializeDeadMachineInstructionElimPass(*PassRegistry::getPassRegistry());
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
AU.setPreservesCFG();
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
|
|
private:
|
|
bool isDead(const MachineInstr *MI) const;
|
|
};
|
|
}
|
|
char DeadMachineInstructionElim::ID = 0;
|
|
char &llvm::DeadMachineInstructionElimID = DeadMachineInstructionElim::ID;
|
|
|
|
INITIALIZE_PASS(DeadMachineInstructionElim, DEBUG_TYPE,
|
|
"Remove dead machine instructions", false, false)
|
|
|
|
bool DeadMachineInstructionElim::isDead(const MachineInstr *MI) const {
|
|
// Technically speaking inline asm without side effects and no defs can still
|
|
// be deleted. But there is so much bad inline asm code out there, we should
|
|
// let them be.
|
|
if (MI->isInlineAsm())
|
|
return false;
|
|
|
|
// Don't delete frame allocation labels.
|
|
if (MI->getOpcode() == TargetOpcode::LOCAL_ESCAPE)
|
|
return false;
|
|
|
|
// Don't delete instructions with side effects.
|
|
bool SawStore = false;
|
|
if (!MI->isSafeToMove(nullptr, SawStore) && !MI->isPHI())
|
|
return false;
|
|
|
|
// Examine each operand.
|
|
for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) {
|
|
const MachineOperand &MO = MI->getOperand(i);
|
|
if (MO.isReg() && MO.isDef()) {
|
|
Register Reg = MO.getReg();
|
|
if (Register::isPhysicalRegister(Reg)) {
|
|
// Don't delete live physreg defs, or any reserved register defs.
|
|
if (LivePhysRegs.test(Reg) || MRI->isReserved(Reg))
|
|
return false;
|
|
} else {
|
|
for (const MachineInstr &Use : MRI->use_nodbg_instructions(Reg)) {
|
|
if (&Use != MI)
|
|
// This def has a non-debug use. Don't delete the instruction!
|
|
return false;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// If there are no defs with uses, the instruction is dead.
|
|
return true;
|
|
}
|
|
|
|
bool DeadMachineInstructionElim::runOnMachineFunction(MachineFunction &MF) {
|
|
if (skipFunction(MF.getFunction()))
|
|
return false;
|
|
|
|
bool AnyChanges = false;
|
|
MRI = &MF.getRegInfo();
|
|
TRI = MF.getSubtarget().getRegisterInfo();
|
|
TII = MF.getSubtarget().getInstrInfo();
|
|
|
|
// Loop over all instructions in all blocks, from bottom to top, so that it's
|
|
// more likely that chains of dependent but ultimately dead instructions will
|
|
// be cleaned up.
|
|
for (MachineBasicBlock &MBB : make_range(MF.rbegin(), MF.rend())) {
|
|
// Start out assuming that reserved registers are live out of this block.
|
|
LivePhysRegs = MRI->getReservedRegs();
|
|
|
|
// Add live-ins from successors to LivePhysRegs. Normally, physregs are not
|
|
// live across blocks, but some targets (x86) can have flags live out of a
|
|
// block.
|
|
for (MachineBasicBlock::succ_iterator S = MBB.succ_begin(),
|
|
E = MBB.succ_end(); S != E; S++)
|
|
for (const auto &LI : (*S)->liveins())
|
|
LivePhysRegs.set(LI.PhysReg);
|
|
|
|
// Now scan the instructions and delete dead ones, tracking physreg
|
|
// liveness as we go.
|
|
for (MachineBasicBlock::reverse_iterator MII = MBB.rbegin(),
|
|
MIE = MBB.rend(); MII != MIE; ) {
|
|
MachineInstr *MI = &*MII++;
|
|
|
|
// If the instruction is dead, delete it!
|
|
if (isDead(MI)) {
|
|
LLVM_DEBUG(dbgs() << "DeadMachineInstructionElim: DELETING: " << *MI);
|
|
// It is possible that some DBG_VALUE instructions refer to this
|
|
// instruction. They get marked as undef and will be deleted
|
|
// in the live debug variable analysis.
|
|
MI->eraseFromParentAndMarkDBGValuesForRemoval();
|
|
AnyChanges = true;
|
|
++NumDeletes;
|
|
continue;
|
|
}
|
|
|
|
// Record the physreg defs.
|
|
for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) {
|
|
const MachineOperand &MO = MI->getOperand(i);
|
|
if (MO.isReg() && MO.isDef()) {
|
|
Register Reg = MO.getReg();
|
|
if (Register::isPhysicalRegister(Reg)) {
|
|
// Check the subreg set, not the alias set, because a def
|
|
// of a super-register may still be partially live after
|
|
// this def.
|
|
for (MCSubRegIterator SR(Reg, TRI,/*IncludeSelf=*/true);
|
|
SR.isValid(); ++SR)
|
|
LivePhysRegs.reset(*SR);
|
|
}
|
|
} else if (MO.isRegMask()) {
|
|
// Register mask of preserved registers. All clobbers are dead.
|
|
LivePhysRegs.clearBitsNotInMask(MO.getRegMask());
|
|
}
|
|
}
|
|
// Record the physreg uses, after the defs, in case a physreg is
|
|
// both defined and used in the same instruction.
|
|
for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) {
|
|
const MachineOperand &MO = MI->getOperand(i);
|
|
if (MO.isReg() && MO.isUse()) {
|
|
Register Reg = MO.getReg();
|
|
if (Register::isPhysicalRegister(Reg)) {
|
|
for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI)
|
|
LivePhysRegs.set(*AI);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
LivePhysRegs.clear();
|
|
return AnyChanges;
|
|
}
|