mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-22 04:22:57 +02:00
8fc32bf8f9
The standard library functions ::isprint/std::isprint have platform-
and locale-dependent behavior which makes LLVM's output less
predictable. In particular, regression tests my fail depending on the
implementation of these functions.
Implement llvm::isPrint in StringExtras.h with a standard behavior and
replace all uses of ::isprint/std::isprint by a call it llvm::isPrint.
The function is inlined and does not look up language settings so it
should perform better than the standard library's version.
Such a replacement has already been done for isdigit, isalpha, isxdigit
in r314883. gtest does the same in gtest-printers.cc using the following
justification:
// Returns true if c is a printable ASCII character. We test the
// value of c directly instead of calling isprint(), which is buggy on
// Windows Mobile.
inline bool IsPrintableAscii(wchar_t c) {
return 0x20 <= c && c <= 0x7E;
}
Similar issues have also been encountered by Julia:
https://github.com/JuliaLang/julia/issues/7416
I noticed the problem myself when on Windows isprint('\t') started to
evaluate to true (see https://stackoverflow.com/questions/51435249) and
thus caused several unit tests to fail. The result of isprint doesn't
seem to be well-defined even for ASCII characters. Therefore I suggest
to replace isprint by a platform-independent version.
Differential Revision: https://reviews.llvm.org/D49680
llvm-svn: 338034
120 lines
3.5 KiB
C++
120 lines
3.5 KiB
C++
//===- StringExtrasTest.cpp - Unit tests for String extras ----------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/ADT/StringExtras.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace llvm;
|
|
|
|
TEST(StringExtrasTest, isPrint) {
|
|
EXPECT_FALSE(isPrint('\0'));
|
|
EXPECT_FALSE(isPrint('\t'));
|
|
EXPECT_TRUE(isPrint('0'));
|
|
EXPECT_TRUE(isPrint('a'));
|
|
EXPECT_TRUE(isPrint('A'));
|
|
EXPECT_TRUE(isPrint(' '));
|
|
EXPECT_TRUE(isPrint('~'));
|
|
EXPECT_TRUE(isPrint('?'));
|
|
}
|
|
|
|
TEST(StringExtrasTest, Join) {
|
|
std::vector<std::string> Items;
|
|
EXPECT_EQ("", join(Items.begin(), Items.end(), " <sep> "));
|
|
|
|
Items = {"foo"};
|
|
EXPECT_EQ("foo", join(Items.begin(), Items.end(), " <sep> "));
|
|
|
|
Items = {"foo", "bar"};
|
|
EXPECT_EQ("foo <sep> bar", join(Items.begin(), Items.end(), " <sep> "));
|
|
|
|
Items = {"foo", "bar", "baz"};
|
|
EXPECT_EQ("foo <sep> bar <sep> baz",
|
|
join(Items.begin(), Items.end(), " <sep> "));
|
|
}
|
|
|
|
TEST(StringExtrasTest, JoinItems) {
|
|
const char *Foo = "foo";
|
|
std::string Bar = "bar";
|
|
llvm::StringRef Baz = "baz";
|
|
char X = 'x';
|
|
|
|
EXPECT_EQ("", join_items(" <sep> "));
|
|
EXPECT_EQ("", join_items('/'));
|
|
|
|
EXPECT_EQ("foo", join_items(" <sep> ", Foo));
|
|
EXPECT_EQ("foo", join_items('/', Foo));
|
|
|
|
EXPECT_EQ("foo <sep> bar", join_items(" <sep> ", Foo, Bar));
|
|
EXPECT_EQ("foo/bar", join_items('/', Foo, Bar));
|
|
|
|
EXPECT_EQ("foo <sep> bar <sep> baz", join_items(" <sep> ", Foo, Bar, Baz));
|
|
EXPECT_EQ("foo/bar/baz", join_items('/', Foo, Bar, Baz));
|
|
|
|
EXPECT_EQ("foo <sep> bar <sep> baz <sep> x",
|
|
join_items(" <sep> ", Foo, Bar, Baz, X));
|
|
|
|
EXPECT_EQ("foo/bar/baz/x", join_items('/', Foo, Bar, Baz, X));
|
|
}
|
|
|
|
TEST(StringExtrasTest, ToAndFromHex) {
|
|
std::vector<uint8_t> OddBytes = {0x5, 0xBD, 0x0D, 0x3E, 0xCD};
|
|
std::string OddStr = "05BD0D3ECD";
|
|
StringRef OddData(reinterpret_cast<const char *>(OddBytes.data()),
|
|
OddBytes.size());
|
|
EXPECT_EQ(OddStr, toHex(OddData));
|
|
EXPECT_EQ(OddData, fromHex(StringRef(OddStr).drop_front()));
|
|
|
|
std::vector<uint8_t> EvenBytes = {0xA5, 0xBD, 0x0D, 0x3E, 0xCD};
|
|
std::string EvenStr = "A5BD0D3ECD";
|
|
StringRef EvenData(reinterpret_cast<const char *>(EvenBytes.data()),
|
|
EvenBytes.size());
|
|
EXPECT_EQ(EvenStr, toHex(EvenData));
|
|
EXPECT_EQ(EvenData, fromHex(EvenStr));
|
|
}
|
|
|
|
TEST(StringExtrasTest, to_float) {
|
|
float F;
|
|
EXPECT_TRUE(to_float("4.7", F));
|
|
EXPECT_FLOAT_EQ(4.7f, F);
|
|
|
|
double D;
|
|
EXPECT_TRUE(to_float("4.7", D));
|
|
EXPECT_DOUBLE_EQ(4.7, D);
|
|
|
|
long double LD;
|
|
EXPECT_TRUE(to_float("4.7", LD));
|
|
EXPECT_DOUBLE_EQ(4.7, LD);
|
|
|
|
EXPECT_FALSE(to_float("foo", F));
|
|
EXPECT_FALSE(to_float("7.4 foo", F));
|
|
EXPECT_FLOAT_EQ(4.7f, F); // F should be unchanged
|
|
}
|
|
|
|
TEST(StringExtrasTest, printLowerCase) {
|
|
std::string str;
|
|
raw_string_ostream OS(str);
|
|
printLowerCase("ABCdefg01234.,&!~`'}\"", OS);
|
|
EXPECT_EQ("abcdefg01234.,&!~`'}\"", OS.str());
|
|
}
|
|
|
|
TEST(StringExtrasTest, printEscapedString) {
|
|
std::string str;
|
|
raw_string_ostream OS(str);
|
|
printEscapedString("ABCdef123&<>\\\"'\t", OS);
|
|
EXPECT_EQ("ABCdef123&<>\\5C\\22'\\09", OS.str());
|
|
}
|
|
|
|
TEST(StringExtrasTest, printHTMLEscaped) {
|
|
std::string str;
|
|
raw_string_ostream OS(str);
|
|
printHTMLEscaped("ABCdef123&<>\"'", OS);
|
|
EXPECT_EQ("ABCdef123&<>"'", OS.str());
|
|
}
|