mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-24 03:33:20 +01:00
cb9b91e743
This patch fixes the memory sanitizer origin store instrumentation for
array types. This can be triggered by cases where frontend lowers
function return to array type instead of aggregation.
For instance, the C code:
--
struct mypair {
int64_t x;
int y;
};
mypair my_make_pair(int64_t x, int y) {
mypair p;
p.x = x;
p.y = y;
return p;
}
int foo (int p)
{
mypair z = my_make_pair(p, 0);
return z.y + z.x;
}
--
It will be lowered with target set to aarch64-linux and -O0 to:
--
[...]
define i32 @_Z3fooi(i32 %p) #0 {
[...]
%call = call [2 x i64] @_Z12my_make_pairxi(i64 %conv, i32 0)
%1 = bitcast %struct.mypair* %z to [2 x i64]*
store [2 x i64] %call, [2 x i64]* %1, align 8
[...]
--
The origin store will emit a 'icmp' to test each store value again the
TLS origin array. However since 'icmp' does not support ArrayType the
memory instrumentation phase will bail out with an error.
This patch change it by using the same strategy used for struct type on
array.
It fixes the 'test/msan/insertvalue_origin.cc' for aarch64 (the -O0 case).
llvm-svn: 257375
24 lines
802 B
LLVM
24 lines
802 B
LLVM
; RUN: opt < %s -msan -msan-check-access-address=0 -msan-track-origins=2 -S | FileCheck %s
|
|
|
|
target datalayout = "e-m:e-i64:64-i128:128-n32:64-S128"
|
|
target triple = "aarch64-unknown-linux-gnu"
|
|
|
|
; Check origin handling of array types.
|
|
|
|
define void @foo([2 x i64] %v, [2 x i64]* %p) sanitize_memory {
|
|
entry:
|
|
store [2 x i64] %v, [2 x i64]* %p, align 8
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: @foo
|
|
; CHECK: [[PARAM:%[01-9a-z]+]] = load {{.*}} @__msan_param_tls
|
|
; CHECK: [[ORIGIN:%[01-9a-z]+]] = load {{.*}} @__msan_param_origin_tls
|
|
|
|
; CHECK: [[TMP1:%[01-9a-z]+]] = ptrtoint
|
|
; CHECK: [[TMP2:%[01-9a-z]+]] = xor i64 [[TMP1]]
|
|
; CHECK: [[TMP3:%[01-9a-z]+]] = inttoptr i64 [[TMP2]] to [2 x i64]*
|
|
; CHECK: store [2 x i64] [[PARAM]], [2 x i64]* [[TMP3]]
|
|
|
|
; CHECK: {{.*}} call i32 @__msan_chain_origin(i32 {{.*}}[[ORIGIN]])
|