mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 12:12:47 +01:00
4e50d0475a
Just as as llvm IR supports explicitly specifying numeric value ids
for instructions, and emits them by default in textual output, now do
the same for blocks.
This is a slightly incompatible change in the textual IR format.
Previously, llvm would parse numeric labels as string names. E.g.
define void @f() {
br label %"55"
55:
ret void
}
defined a label *named* "55", even without needing to be quoted, while
the reference required quoting. Now, if you intend a block label which
looks like a value number to be a name, you must quote it in the
definition too (e.g. `"55":`).
Previously, llvm would print nameless blocks only as a comment, and
would omit it if there was no predecessor. This could cause confusion
for readers of the IR, just as unnamed instructions did prior to the
addition of "%5 = " syntax, back in 2008 (PR2480).
Now, it will always print a label for an unnamed block, with the
exception of the entry block. (IMO it may be better to print it for
the entry-block as well. However, that requires updating many more
tests.)
Thus, the following is supported, and is the canonical printing:
define i32 @f(i32, i32) {
%3 = add i32 %0, %1
br label %4
4:
ret i32 %3
}
New test cases covering this behavior are added, and other tests
updated as required.
Differential Revision: https://reviews.llvm.org/D58548
llvm-svn: 356789
49 lines
1.2 KiB
LLVM
49 lines
1.2 KiB
LLVM
; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | FileCheck %s --match-full-lines
|
|
; RUN: verify-uselistorder %s
|
|
|
|
define i32 @test1(i32 %X) {
|
|
; Implicit entry label. Not printed on output.
|
|
%1 = alloca i32
|
|
br label %2
|
|
; Implicit label ids still allowed.
|
|
br label %3
|
|
3: ; Explicit numeric label
|
|
br label %"2"
|
|
"2": ; string label, quoted number
|
|
br label %-3
|
|
-3: ; numeric-looking, but actually string, label
|
|
br label %-N-
|
|
-N-:
|
|
br label %$N
|
|
$N:
|
|
%4 = add i32 1, 1
|
|
ret i32 %4
|
|
}
|
|
|
|
; CHECK-LABEL: define i32 @test1(i32 %X) {
|
|
; CHECK-NEXT: %1 = alloca i32
|
|
; CHECK-NEXT: br label %2
|
|
; CHECK: 2: ; preds = %0
|
|
; CHECK-NEXT: br label %3
|
|
; CHECK: 3: ; preds = %2
|
|
; CHECK-NEXT: br label %"2"
|
|
; CHECK: "2": ; preds = %3
|
|
; CHECK-NEXT: br label %-3
|
|
; CHECK: -3: ; preds = %"2"
|
|
; CHECK-NEXT: br label %-N-
|
|
; CHECK: -N-: ; preds = %-3
|
|
; CHECK-NEXT: br label %"$N"
|
|
; CHECK: "$N": ; preds = %-N-
|
|
; CHECK-NEXT: %4 = add i32 1, 1
|
|
; CHECK-NEXT: ret i32 %4
|
|
; CHECK-NEXT: }
|
|
|
|
define void @test2(i32, i32) {
|
|
; entry label id still not printed on output
|
|
2:
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: define void @test2(i32, i32) {
|
|
; CHECK-NEXT: ret void
|