mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-02-01 05:01:59 +01:00
54b2d5c279
For wasm-ld table linking work to proceed, object files should indicate if they use an indirect function table. In the future this will be done by the usual symbols and relocations mechanism, but until that support lands in the linker, the presence of an `__indirect_function_table` in the object file's import section shows that the object file needs an indirect function table. Prior to https://reviews.llvm.org/D91637, this condition was met by all object files residualizing an `__indirect_function_table` import. Since https://reviews.llvm.org/D91637, the intention has been that only those object files needing an indirect function table would have the `__indirect_function_table` import. However, we missed the case of object files which use the table via `call_indirect` but which themselves do not declare any indirect functions. This changeset makes it so that when we lower a call to `call_indirect`, that we ensure that a `__indirect_function_table` symbol is present and that it will be propagated to the linker. A followup patch will revise this mechanism to make an explicit link between `call_indirect` and its associated indirect function table; see https://reviews.llvm.org/D90948. Differential Revision: https://reviews.llvm.org/D92840
29 lines
1.0 KiB
LLVM
29 lines
1.0 KiB
LLVM
; RUN: llc < %s -asm-verbose=false -O2 | FileCheck --check-prefix=CHECK %s
|
|
; RUN: llc < %s -asm-verbose=false -O2 --filetype=obj | obj2yaml | FileCheck --check-prefix=OBJ %s
|
|
|
|
; Test that compilation units with call_indirect but without any
|
|
; function pointer declarations still get a table.
|
|
|
|
target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
|
|
target triple = "wasm32-unknown-unknown"
|
|
|
|
; CHECK-LABEL: call_indirect_void:
|
|
; CHECK-NEXT: .functype call_indirect_void (i32) -> ()
|
|
; CHECK-NEXT: local.get 0
|
|
; CHECK-NEXT: call_indirect () -> ()
|
|
; CHECK-NEXT: end_function
|
|
define void @call_indirect_void(void ()* %callee) {
|
|
call void %callee()
|
|
ret void
|
|
}
|
|
|
|
; OBJ: Imports:
|
|
; OBJ-NEXT: - Module: env
|
|
; OBJ-NEXT: Field: __linear_memory
|
|
; OBJ-NEXT: Kind: MEMORY
|
|
; OBJ-NEXT: Memory:
|
|
; OBJ-NEXT: Initial: 0x0
|
|
; OBJ-NEXT: - Module: env
|
|
; OBJ-NEXT: Field: __indirect_function_table
|
|
; OBJ-NEXT: Kind: TABLE
|