mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-26 12:43:36 +01:00
acb0e6010b
This generally follows what other targets do. I don't completely understand why the special case for tail calls existed in the first place; even when the code was committed in r105413, call lowering didn't work in the way described in the comments. Stack protector lowering breaks if the register copies are not glued to a tail call: we have to insert the stack protector check before the tail call, and we choose the location based on the assumption that all physical register dependencies of a tail call are adjacent to the tail call. (See FindSplitPointForStackProtector.) This is sort of fragile, but I don't see any reason to break that assumption. I'm guessing nobody has seen this before just because it's hard to convince the scheduler to actually schedule the code in a way that breaks; even without the glue, the only computation that could actually be scheduled after the register copies is the computation of the call address, and the scheduler usually prefers to schedule that before the copies anyway. Fixes https://bugs.llvm.org/show_bug.cgi?id=41417 Differential Revision: https://reviews.llvm.org/D60427 llvm-svn: 360099
36 lines
1.3 KiB
LLVM
36 lines
1.3 KiB
LLVM
; RUN: llc < %s | FileCheck %s
|
|
target triple = "armv6kz-unknown-unknown-gnueabihf"
|
|
|
|
; Make sure this doesn't crash, and we actually emit a tail call.
|
|
; Unfortunately, this test is sort of fragile... the original issue only
|
|
; shows up if scheduling happens in a very specific order. But including
|
|
; it anyway just to demonstrate the issue.
|
|
; CHECK: pop {r4, lr}
|
|
|
|
@e = external local_unnamed_addr constant [0 x i32 (i32, i32)*], align 4
|
|
|
|
; Function Attrs: nounwind sspstrong
|
|
define i32 @AVI_ChunkRead_p_chk(i32 %g) nounwind sspstrong "target-cpu"="arm1176jzf-s" {
|
|
entry:
|
|
%b = alloca i8, align 1
|
|
%tobool = icmp eq i32 %g, 0
|
|
br i1 %tobool, label %if.end, label %if.then
|
|
|
|
if.then: ; preds = %entry
|
|
%add = add nsw i32 %g, 1
|
|
%arrayidx = getelementptr inbounds [0 x i32 (i32, i32)*], [0 x i32 (i32, i32)*]* @e, i32 0, i32 %add
|
|
%0 = load i32 (i32, i32)*, i32 (i32, i32)** %arrayidx, align 4
|
|
%call = tail call i32 %0(i32 0, i32 0) #3
|
|
br label %return
|
|
|
|
if.end: ; preds = %entry
|
|
call void @c(i8* nonnull %b)
|
|
br label %return
|
|
|
|
return: ; preds = %if.end, %if.then
|
|
%retval.0 = phi i32 [ %call, %if.then ], [ 0, %if.end ]
|
|
ret i32 %retval.0
|
|
}
|
|
|
|
declare void @c(i8*)
|