mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 20:23:11 +01:00
e3f12b0e68
The bitset metadata currently used in LLVM has a few problems: 1. It has the wrong name. The name "bitset" refers to an implementation detail of one use of the metadata (i.e. its original use case, CFI). This makes it harder to understand, as the name makes no sense in the context of virtual call optimization. 2. It is represented using a global named metadata node, rather than being directly associated with a global. This makes it harder to manipulate the metadata when rebuilding global variables, summarise it as part of ThinLTO and drop unused metadata when associated globals are dropped. For this reason, CFI does not currently work correctly when both CFI and vcall opt are enabled, as vcall opt needs to rebuild vtable globals, and fails to associate metadata with the rebuilt globals. As I understand it, the same problem could also affect ASan, which rebuilds globals with a red zone. This patch solves both of those problems in the following way: 1. Rename the metadata to "type metadata". This new name reflects how the metadata is currently being used (i.e. to represent type information for CFI and vtable opt). The new name is reflected in the name for the associated intrinsic (llvm.type.test) and pass (LowerTypeTests). 2. Attach metadata directly to the globals that it pertains to, rather than using the "llvm.bitsets" global metadata node as we are doing now. This is done using the newly introduced capability to attach metadata to global variables (r271348 and r271358). See also: http://lists.llvm.org/pipermail/llvm-dev/2016-June/100462.html Differential Revision: http://reviews.llvm.org/D21053 llvm-svn: 273729
147 lines
4.7 KiB
C++
147 lines
4.7 KiB
C++
//===-- llvm/GlobalObject.h - Class to represent global objects -*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This represents an independent object. That is, a function or a global
|
|
// variable, but not an alias.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_IR_GLOBALOBJECT_H
|
|
#define LLVM_IR_GLOBALOBJECT_H
|
|
|
|
#include "llvm/IR/DerivedTypes.h"
|
|
#include "llvm/IR/GlobalValue.h"
|
|
|
|
namespace llvm {
|
|
class Comdat;
|
|
class MDNode;
|
|
class Metadata;
|
|
class Module;
|
|
|
|
class GlobalObject : public GlobalValue {
|
|
GlobalObject(const GlobalObject &) = delete;
|
|
|
|
protected:
|
|
GlobalObject(Type *Ty, ValueTy VTy, Use *Ops, unsigned NumOps,
|
|
LinkageTypes Linkage, const Twine &Name,
|
|
unsigned AddressSpace = 0)
|
|
: GlobalValue(Ty, VTy, Ops, NumOps, Linkage, Name, AddressSpace),
|
|
ObjComdat(nullptr) {
|
|
setGlobalValueSubClassData(0);
|
|
}
|
|
|
|
std::string Section; // Section to emit this into, empty means default
|
|
Comdat *ObjComdat;
|
|
enum {
|
|
LastAlignmentBit = 4,
|
|
HasMetadataHashEntryBit,
|
|
|
|
GlobalObjectBits,
|
|
};
|
|
static const unsigned GlobalObjectSubClassDataBits =
|
|
GlobalValueSubClassDataBits - GlobalObjectBits;
|
|
|
|
private:
|
|
static const unsigned AlignmentBits = LastAlignmentBit + 1;
|
|
static const unsigned AlignmentMask = (1 << AlignmentBits) - 1;
|
|
static const unsigned GlobalObjectMask = (1 << GlobalObjectBits) - 1;
|
|
|
|
public:
|
|
unsigned getAlignment() const {
|
|
unsigned Data = getGlobalValueSubClassData();
|
|
unsigned AlignmentData = Data & AlignmentMask;
|
|
return (1u << AlignmentData) >> 1;
|
|
}
|
|
void setAlignment(unsigned Align);
|
|
|
|
unsigned getGlobalObjectSubClassData() const;
|
|
void setGlobalObjectSubClassData(unsigned Val);
|
|
|
|
bool hasSection() const { return !getSection().empty(); }
|
|
StringRef getSection() const { return Section; }
|
|
void setSection(StringRef S);
|
|
|
|
bool hasComdat() const { return getComdat() != nullptr; }
|
|
const Comdat *getComdat() const { return ObjComdat; }
|
|
Comdat *getComdat() { return ObjComdat; }
|
|
void setComdat(Comdat *C) { ObjComdat = C; }
|
|
|
|
/// Check if this has any metadata.
|
|
bool hasMetadata() const { return hasMetadataHashEntry(); }
|
|
|
|
/// Get the current metadata attachments for the given kind, if any.
|
|
///
|
|
/// These functions require that the function have at most a single attachment
|
|
/// of the given kind, and return \c nullptr if such an attachment is missing.
|
|
/// @{
|
|
MDNode *getMetadata(unsigned KindID) const;
|
|
MDNode *getMetadata(StringRef Kind) const;
|
|
/// @}
|
|
|
|
/// Appends all attachments with the given ID to \c MDs in insertion order.
|
|
/// If the global has no attachments with the given ID, or if ID is invalid,
|
|
/// leaves MDs unchanged.
|
|
/// @{
|
|
void getMetadata(unsigned KindID, SmallVectorImpl<MDNode *> &MDs) const;
|
|
void getMetadata(StringRef Kind, SmallVectorImpl<MDNode *> &MDs) const;
|
|
/// @}
|
|
|
|
/// Set a particular kind of metadata attachment.
|
|
///
|
|
/// Sets the given attachment to \c MD, erasing it if \c MD is \c nullptr or
|
|
/// replacing it if it already exists.
|
|
/// @{
|
|
void setMetadata(unsigned KindID, MDNode *MD);
|
|
void setMetadata(StringRef Kind, MDNode *MD);
|
|
/// @}
|
|
|
|
/// Add a metadata attachment.
|
|
/// @{
|
|
void addMetadata(unsigned KindID, MDNode &MD);
|
|
void addMetadata(StringRef Kind, MDNode &MD);
|
|
/// @}
|
|
|
|
/// Appends all attachments for the global to \c MDs, sorting by attachment
|
|
/// ID. Attachments with the same ID appear in insertion order.
|
|
void
|
|
getAllMetadata(SmallVectorImpl<std::pair<unsigned, MDNode *>> &MDs) const;
|
|
|
|
/// Erase all metadata attachments with the given kind.
|
|
void eraseMetadata(unsigned KindID);
|
|
|
|
/// Copy metadata from Src, adjusting offsets by Offset.
|
|
void copyMetadata(const GlobalObject *Src, unsigned Offset);
|
|
|
|
void addTypeMetadata(unsigned Offset, Metadata *TypeID);
|
|
|
|
void copyAttributesFrom(const GlobalValue *Src) override;
|
|
|
|
// Methods for support type inquiry through isa, cast, and dyn_cast:
|
|
static inline bool classof(const Value *V) {
|
|
return V->getValueID() == Value::FunctionVal ||
|
|
V->getValueID() == Value::GlobalVariableVal;
|
|
}
|
|
|
|
void clearMetadata();
|
|
|
|
private:
|
|
bool hasMetadataHashEntry() const {
|
|
return getGlobalValueSubClassData() & (1 << HasMetadataHashEntryBit);
|
|
}
|
|
void setHasMetadataHashEntry(bool HasEntry) {
|
|
unsigned Mask = 1 << HasMetadataHashEntryBit;
|
|
setGlobalValueSubClassData((~Mask & getGlobalValueSubClassData()) |
|
|
(HasEntry ? Mask : 0u));
|
|
}
|
|
};
|
|
|
|
} // End llvm namespace
|
|
|
|
#endif
|