mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-22 20:43:44 +02:00
9bece8dc4b
Summary: XRay had been assuming that the previous section is the "text" section of the function when lowering the instrumentation map. Unfortunately this is not a safe assumption, because we may be coming from lowering debug type information for the function being lowered. This fixes an issue with combining -gsplit-dwarf, -generate-type-units, -debug-compile and -fxray-instrument for sole member functions. When the split dwarf section is stripped, we're left with references from the xray_instr_map to the debug section. The change now uses the function's symbol instead of the previous section's start symbol. We found the bug while attempting to strip the split debug sections off an XRay-instrumented object file, which had a peculiar edge-case for single-function classes where the single function is being lowered. Because XRay had assocaited the instrumentation map for a function to the debug types section instead of the function's section, the objcopy call will fail due to the misplaced reference from the xray_instr_map section. Reviewers: pcc, dblaikie, echristo Subscribers: llvm-commits, aprantl Differential Revision: https://reviews.llvm.org/D37791 llvm-svn: 313233
19 lines
807 B
LLVM
19 lines
807 B
LLVM
; RUN: llc -filetype=asm -o - -mtriple=x86_64-unknown-linux-gnu -function-sections < %s | FileCheck %s
|
|
; RUN: llc -filetype=obj -o %t -mtriple=x86_64-unknown-linux-gnu -function-sections < %s
|
|
; RUN: llvm-objdump -triple x86_64-unknown-linux-gnu -disassemble-all %t | FileCheck %s --check-prefix=CHECK-OBJ
|
|
|
|
define i32 @foo() nounwind noinline uwtable "function-instrument"="xray-always" {
|
|
; CHECK: .section .text.foo,"ax",@progbits
|
|
ret i32 0
|
|
; CHECK: .section xray_instr_map,"awo",@progbits,foo,unique,1
|
|
}
|
|
|
|
$bar = comdat any
|
|
define i32 @bar() nounwind noinline uwtable "function-instrument"="xray-always" comdat($bar) {
|
|
; CHECK: .section .text.bar,"axG",@progbits,bar,comdat
|
|
ret i32 1
|
|
; CHECK: .section xray_instr_map,"aGwo",@progbits,bar,comdat,bar,unique,2
|
|
}
|
|
|
|
; CHECK-OBJ: section xray_instr_map:
|