mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 20:23:11 +01:00
6d0ecb4cce
This came out of a recent discussion on llvm-dev (https://reviews.llvm.org/D38042). Currently the Verifier will strip the debug info metadata from a module if it finds the dbeug info to be malformed. This feature is very valuable since it allows us to improve the Verifier by making it stricter without breaking bcompatibility, but arguable the Verifier pass should not be modifying the IR. This patch moves the stripping of broken debug info into AutoUpgrade (UpgradeDebugInfo to be precise), which is a much better location for this since the stripping of malformed (i.e., produced by older, buggy versions of Clang) is a (harsh) form of AutoUpgrade. This change is mostly NFC in nature, the one big difference is the behavior when LLVM module passes are introducing malformed debug info. Prior to this patch, a NoAsserts build would have printed a warning and stripped the debug info, after this patch the Verifier will report a fatal error. I believe this behavior is actually more desirable anyway. Differential Revision: https://reviews.llvm.org/D38184 llvm-svn: 314699
65 lines
2.3 KiB
LLVM
65 lines
2.3 KiB
LLVM
; RUN: llvm-as %s -o %t 2>&1 | FileCheck %s
|
|
; Created and then edited from
|
|
; extern void i();
|
|
; void h() { i(); }
|
|
; void g() { h(); }
|
|
; void f() { g(); }
|
|
;
|
|
; Compiling this with inlining runs into the
|
|
; "!dbg attachment points at wrong subprogram for function"
|
|
; assertion.
|
|
|
|
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-apple-macosx"
|
|
|
|
; Function Attrs: nounwind ssp uwtable
|
|
define void @h() #0 !dbg !7 {
|
|
entry:
|
|
call void (...) @i(), !dbg !9
|
|
ret void, !dbg !10
|
|
}
|
|
|
|
declare void @i(...) #1
|
|
|
|
; Function Attrs: nounwind ssp uwtable
|
|
define void @g() #0 !dbg !11 {
|
|
entry:
|
|
; Manually removed !dbg.
|
|
; CHECK: inlinable function call in a function with debug info must have a !dbg location
|
|
call void @h()
|
|
ret void, !dbg !13
|
|
}
|
|
|
|
; Function Attrs: nounwind ssp uwtable
|
|
define void @f() #0 !dbg !14 {
|
|
entry:
|
|
call void @g(), !dbg !15
|
|
ret void, !dbg !16
|
|
}
|
|
|
|
attributes #0 = { nounwind ssp uwtable }
|
|
|
|
; CHECK: warning: ignoring invalid debug info
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!3, !4, !5}
|
|
!llvm.ident = !{!6}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 3.9.0 (trunk 267186)", isOptimized: false, runtimeVersion: 0, emissionKind: LineTablesOnly, enums: !2)
|
|
!1 = !DIFile(filename: "test.c", directory: "/Volumes/Data/llvm")
|
|
!2 = !{}
|
|
!3 = !{i32 2, !"Dwarf Version", i32 2}
|
|
!4 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!5 = !{i32 1, !"PIC Level", i32 2}
|
|
!6 = !{!"clang version 3.9.0 (trunk 267186)"}
|
|
!7 = distinct !DISubprogram(name: "h", scope: !1, file: !1, line: 2, type: !8, isLocal: false, isDefinition: true, scopeLine: 2, isOptimized: false, unit: !0, variables: !2)
|
|
!8 = !DISubroutineType(types: !2)
|
|
!9 = !DILocation(line: 2, column: 12, scope: !7)
|
|
!10 = !DILocation(line: 2, column: 17, scope: !7)
|
|
!11 = distinct !DISubprogram(name: "g", scope: !1, file: !1, line: 3, type: !8, isLocal: false, isDefinition: true, scopeLine: 3, isOptimized: false, unit: !0, variables: !2)
|
|
!12 = !DILocation(line: 3, column: 12, scope: !11)
|
|
!13 = !DILocation(line: 3, column: 17, scope: !11)
|
|
!14 = distinct !DISubprogram(name: "f", scope: !1, file: !1, line: 4, type: !8, isLocal: false, isDefinition: true, scopeLine: 4, isOptimized: false, unit: !0, variables: !2)
|
|
!15 = !DILocation(line: 4, column: 12, scope: !14)
|
|
!16 = !DILocation(line: 4, column: 17, scope: !14)
|