mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 10:42:39 +01:00
2174d3b961
In PGO, a C++ external linkage function `foo` has a private counter `__profc_foo` and a private `__profd_foo` in a `comdat nodeduplicate`. A `__attribute__((weak))` function `foo` has a weak hidden counter `__profc_foo` and a private `__profd_foo` in a `comdat nodeduplicate`. In `ld.lld a.o b.o`, say a.o defines an external linkage `foo` and b.o defines a weak `foo`. Currently we treat `comdat nodeduplicate` as `comdat any`, ld.lld will incorrectly consider `b.o:__profc_foo` non-prevailing. In the worst case when `b.o:__profd_foo` is retained and `b.o:__profc_foo` isn't, there will be dangling reference causing an `undefined hidden symbol` error. Add SelectionKind to `Comdat` in IRSymtab and let linkers ignore nodeduplicate comdat. Differential Revision: https://reviews.llvm.org/D106228 |
||
|---|---|---|
| .. | ||
| archive-ir-asm.ll | ||
| archive-symbol-table.s | ||
| asm-lazy-reference.ll | ||
| coff-asm.ll | ||
| irsymtab-asm.ll | ||
| irsymtab-bad-alias.ll | ||
| irsymtab.ll | ||
| lit.local.cfg | ||
| macho-text-sections.test | ||
| nm-bitcodeweak.test | ||
| nm-coff.s | ||
| nm-ir.ll | ||
| nm-macho.s | ||
| nm-print-size.s | ||
| nm-undefinedweak.test | ||
| obj2yaml-dup-section-name.s | ||
| obj2yaml-dup-symbol-name.s | ||
| objdump-disassembly-inline-relocations.test | ||
| objdump-label.test | ||
| objdump-trivial-object.test | ||
| yaml2obj-elf-x86-rel.yaml | ||