mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-21 20:12:56 +02:00
d1f5a2789e
This patch improves the memory folding of the inserted float element for the (V)INSERTPS instruction. The existing implementation occurs in the DAGCombiner and relies on the narrowing of a whole vector load into a scalar load (and then converted into a vector) to (hopefully) allow folding to occur later on. Not only has this proven problematic for debug builds, it also prevents other memory folds (notably stack reloads) from happening. This patch removes the old implementation and moves the folding code to the X86 foldMemoryOperand handler. A new private 'special case' function - foldMemoryOperandCustom - has been added to deal with memory folding of instructions that can't just use the lookup tables - (V)INSERTPS is the first of several that could be done. It also tweaks the memory operand folding code with an additional pointer offset that allows existing memory addresses to be modified, in this case to convert the vector address to the explicit address of the scalar element that will be inserted. Unlike the previous implementation we now set the insertion source index to zero, although this is ignored for the (V)INSERTPSrm version, anything that relied on shuffle decodes (such as unfolding of insertps loads) was incorrectly calculating the source address - I've added a test for this at insertps-unfold-load-bug.ll Differential Revision: http://reviews.llvm.org/D13988 llvm-svn: 252074
34 lines
1.4 KiB
LLVM
34 lines
1.4 KiB
LLVM
; RUN: llc -mtriple=i686-unknown-unknown -mattr=+sse4.1 < %s | FileCheck %s -check-prefix=X32
|
|
; RUN: llc -mtriple=x86_64-unknown-unknown -mattr=+sse4.1 < %s | FileCheck %s -check-prefix=X64
|
|
|
|
; Test for case where insertps was folding the load of the insertion element, but a later optimization
|
|
; was then manipulating the load.
|
|
|
|
define <4 x float> @insertps_unfold(<4 x float>* %v0, <4 x float>* %v1) {
|
|
; X32-LABEL: insertps_unfold:
|
|
; X32: # BB#0:
|
|
; X32-NEXT: movl {{[0-9]+}}(%esp), %eax
|
|
; X32-NEXT: movl {{[0-9]+}}(%esp), %ecx
|
|
; X32-NEXT: movss {{.*#+}} xmm1 = mem[0],zero,zero,zero
|
|
; X32-NEXT: movaps (%eax), %xmm0
|
|
; X32-NEXT: insertps {{.*#+}} xmm0 = xmm0[0,1,2],mem[0]
|
|
; X32-NEXT: addps %xmm1, %xmm0
|
|
; X32-NEXT: retl
|
|
;
|
|
; X64-LABEL: insertps_unfold:
|
|
; X64: # BB#0:
|
|
; X64-NEXT: movss {{.*#+}} xmm1 = mem[0],zero,zero,zero
|
|
; X64-NEXT: movaps (%rdi), %xmm0
|
|
; X64-NEXT: insertps {{.*#+}} xmm0 = xmm0[0,1,2],mem[0]
|
|
; X64-NEXT: addps %xmm1, %xmm0
|
|
; X64-NEXT: retq
|
|
%a = getelementptr inbounds <4 x float>, <4 x float>* %v1, i64 0, i64 1
|
|
%b = load float, float* %a, align 4
|
|
%c = insertelement <4 x float> undef, float %b, i32 0
|
|
%d = load <4 x float>, <4 x float>* %v1, align 16
|
|
%e = load <4 x float>, <4 x float>* %v0, align 16
|
|
%f = shufflevector <4 x float> %e, <4 x float> %d, <4 x i32> <i32 0, i32 1, i32 2, i32 5>
|
|
%g = fadd <4 x float> %c, %f
|
|
ret <4 x float> %g
|
|
}
|