mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 19:23:23 +01:00
9baaae9344
Fixes PR27315.
The post-inc version of an add recurrence needs to "follow the same
rules" as a normal add or subtract expression. Otherwise we miscompile
programs like
```
int main() {
int a = 0;
unsigned a_u = 0;
volatile long last_value;
do {
a_u += 3;
last_value = (long) ((int) a_u);
if (will_add_overflow(a, 3)) {
// Leave, and don't actually do the increment, so no UB.
printf("last_value = %ld\n", last_value);
exit(0);
}
a += 3;
} while (a != 46);
return 0;
}
```
This patch changes SCEV to put no-wrap flags on post-inc add recurrences
only when the poison from a potential overflow will go ahead to cause
undefined behavior.
To avoid regressing performance too much, I've assumed infinite loops
without side effects is undefined behavior to prove poison<->UB
equivalence in more cases. This isn't ideal, but is not new to LLVM as
a whole, and far better than the situation I'm trying to fix.
llvm-svn: 271151
46 lines
1.0 KiB
LLVM
46 lines
1.0 KiB
LLVM
; RUN: opt -analyze -scalar-evolution < %s | FileCheck %s
|
|
|
|
define void @f(i1* %condition) {
|
|
; CHECK-LABEL: Classifying expressions for: @f
|
|
entry:
|
|
br label %loop
|
|
|
|
loop:
|
|
%idx = phi i32 [ 0, %entry ], [ %idx.inc, %loop ]
|
|
%idx.inc = add nsw i32 %idx, 1
|
|
|
|
%idx.inc2 = add i32 %idx.inc, 1
|
|
%idx.inc2.zext = zext i32 %idx.inc2 to i64
|
|
|
|
; CHECK: %idx.inc2.zext = zext i32 %idx.inc2 to i64
|
|
; CHECK-NEXT: --> {2,+,1}<nuw><%loop>
|
|
|
|
%c = load volatile i1, i1* %condition
|
|
br i1 %c, label %loop, label %exit
|
|
|
|
exit:
|
|
ret void
|
|
}
|
|
|
|
define void @g(i1* %condition) {
|
|
; CHECK-LABEL: Classifying expressions for: @g
|
|
entry:
|
|
br label %loop
|
|
|
|
loop:
|
|
%idx = phi i32 [ 0, %entry ], [ %idx.inc, %loop ]
|
|
%idx.inc = add nsw i32 %idx, 3
|
|
|
|
%idx.inc2 = add i32 %idx.inc, -1
|
|
%idx.inc2.sext = sext i32 %idx.inc2 to i64
|
|
; CHECK: %idx.inc2.sext = sext i32 %idx.inc2 to i64
|
|
; CHECK-NEXT: --> {2,+,3}<nuw><nsw><%loop>
|
|
|
|
%cond.gep = getelementptr inbounds i1, i1* %condition, i32 %idx.inc
|
|
%c = load volatile i1, i1* %cond.gep
|
|
br i1 %c, label %loop, label %exit
|
|
|
|
exit:
|
|
ret void
|
|
}
|