mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-18 18:42:46 +02:00
d94bcd2889
The StringView::substr now accepts a substring starting position and its length instead of previous non-standard `from` & `to` positions. All uses of two argument StringView::substr are in MicrosoftDemangler and have 0 as a starting position, so no changes are necessary. This also fixes a bug where attempting to extract a suffix with substr (a `to` position equal to size) would return a substring without the last character. Fixing the issue should not introduce observable changes in the demangler, since as currently used, a second argument to StringView::substr is either: 1) a result of a successful call to StringView::find and so necessarily smaller than size., or 2) in the case of Demangler::demangleCharLiteral potentially equal to size, but with demangler expecting more data to follow later on and failing either way. Reviewed By: #libc_abi, ldionne, erik.pilkington Differential Revision: https://reviews.llvm.org/D100246
49 lines
1.2 KiB
C++
49 lines
1.2 KiB
C++
//===- llvm/unittest/StringViewTest.cpp - StringView unit tests -----------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/Demangle/StringView.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace llvm;
|
|
using llvm::itanium_demangle::StringView;
|
|
|
|
namespace llvm {
|
|
namespace itanium_demangle {
|
|
|
|
std::ostream &operator<<(std::ostream &OS, const StringView &S) {
|
|
return OS.write(S.begin(), S.size());
|
|
}
|
|
|
|
} // namespace itanium_demangle
|
|
} // namespace llvm
|
|
|
|
TEST(StringViewTest, EmptyInitializerList) {
|
|
StringView S = {};
|
|
EXPECT_TRUE(S.empty());
|
|
|
|
S = {};
|
|
EXPECT_TRUE(S.empty());
|
|
}
|
|
|
|
TEST(StringViewTest, Substr) {
|
|
StringView S("abcdef");
|
|
|
|
EXPECT_EQ("abcdef", S.substr(0));
|
|
EXPECT_EQ("f", S.substr(5));
|
|
EXPECT_EQ("", S.substr(6));
|
|
|
|
EXPECT_EQ("", S.substr(0, 0));
|
|
EXPECT_EQ("a", S.substr(0, 1));
|
|
EXPECT_EQ("abcde", S.substr(0, 5));
|
|
EXPECT_EQ("abcdef", S.substr(0, 6));
|
|
EXPECT_EQ("abcdef", S.substr(0, 7));
|
|
|
|
EXPECT_EQ("f", S.substr(5, 100));
|
|
EXPECT_EQ("", S.substr(6, 100));
|
|
}
|