mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 10:42:39 +01:00
0e6a699715
Currently, we have some confusion in the codebase regarding the meaning of LocationSize::unknown(): Some parts (including most of BasicAA) assume that LocationSize::unknown() only allows accesses after the base pointer. Some parts (various callers of AA) assume that LocationSize::unknown() allows accesses both before and after the base pointer (but within the underlying object). This patch splits up LocationSize::unknown() into LocationSize::afterPointer() and LocationSize::beforeOrAfterPointer() to make this completely unambiguous. I tried my best to determine which one is appropriate for all the existing uses. The test changes in cs-cs.ll in particular illustrate a previously clearly incorrect AA result: We were effectively assuming that argmemonly functions were only allowed to access their arguments after the passed pointer, but not before it. I'm pretty sure that this was not intentional, and it's certainly not specified by LangRef that way. Differential Revision: https://reviews.llvm.org/D91649
49 lines
2.0 KiB
LLVM
49 lines
2.0 KiB
LLVM
; RUN: opt -basic-aa -print-alias-sets -S -o - < %s 2>&1 | FileCheck %s
|
|
|
|
@s = global i8 1, align 1
|
|
@d = global i8 2, align 1
|
|
|
|
; CHECK: Alias sets for function 'test_known_size':
|
|
; CHECK: Alias Set Tracker: 1 alias sets for 1 pointer values.
|
|
; CHECK: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %d, LocationSize::precise(1))
|
|
define void @test_known_size(i8* noalias %d) {
|
|
entry:
|
|
call void @llvm.memset.p0i8.i64(i8* align 1 %d, i8 0, i64 1, i1 false)
|
|
ret void
|
|
}
|
|
|
|
; CHECK: Alias sets for function 'test_unknown_size':
|
|
; CHECK: Alias Set Tracker: 1 alias sets for 1 pointer values.
|
|
; CHECK: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %d, unknown after)
|
|
define void @test_unknown_size(i8* noalias %d, i64 %len) {
|
|
entry:
|
|
call void @llvm.memset.p0i8.i64(i8* align 1 %d, i8 0, i64 %len, i1 false)
|
|
ret void
|
|
}
|
|
|
|
|
|
; CHECK: Alias sets for function 'test_atomic_known_size':
|
|
; CHECK: Alias Set Tracker: 1 alias sets for 1 pointer values.
|
|
; CHECK: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %d, LocationSize::precise(1))
|
|
define void @test_atomic_known_size(i8* noalias %d) {
|
|
entry:
|
|
call void @llvm.memset.element.unordered.atomic.p0i8.i32(i8* align 1 %d, i8 0, i64 1, i32 1)
|
|
ret void
|
|
}
|
|
|
|
; CHECK: Alias sets for function 'test_atomic_unknown_size':
|
|
; CHECK: Alias Set Tracker: 1 alias sets for 1 pointer values.
|
|
; CHECK: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %d, unknown after)
|
|
define void @test_atomic_unknown_size(i8* noalias %d, i64 %len) {
|
|
entry:
|
|
call void @llvm.memset.element.unordered.atomic.p0i8.i32(i8* align 1 %d, i8 0, i64 %len, i32 1)
|
|
ret void
|
|
}
|
|
|
|
declare void @llvm.memset.p0i8.i64(i8* %dest, i8 %val,
|
|
i64 %len, i1 %isvolatile)
|
|
declare void @llvm.memset.element.unordered.atomic.p0i8.i32(i8* %dest,
|
|
i8 %value,
|
|
i64 %len,
|
|
i32 %element_size)
|