mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 10:42:39 +01:00
fcb829d489
Dynamically loaded plugins for the new pass manager are initialised by calling llvmGetPassPluginInfo. This is defined as a weak symbol so that it is continually redefined by each plugin that is loaded. When loading a plugin from a shared library, the intention is that llvmGetPassPluginInfo will be resolved to the definition in the most recent plugin. However, using a global search for this resolution can fail in situations where multiple plugins are loaded. Currently: * If a plugin does not define llvmGetPassPluginInfo, then it will be silently resolved to the previous plugin's definition. * If loading the same plugin twice with another in between, e.g. plugin A/plugin B/plugin A, then the second load of plugin A will resolve to llvmGetPassPluginInfo in plugin B. * The previous case can also occur when a dynamic library defines both NPM and legacy plugins; the legacy plugins are loaded first and then with `-fplugin=A -fpass-plugin=B -fpass-plugin=A`: A will be loaded as a legacy plugin and define llvmGetPassPluginInfo; B will be loaded and redefine it; and finally when A is loaded as an NPM plugin it will be resolved to the definition from B. Instead of searching globally, restrict the symbol lookup to the library that is currently being loaded. Differential Revision: https://reviews.llvm.org/D104916
39 lines
1.2 KiB
C++
39 lines
1.2 KiB
C++
//===- unittests/Passes/TestPlugin.cpp --------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/Passes/PassBuilder.h"
|
|
#include "llvm/Passes/PassPlugin.h"
|
|
|
|
#include "TestPlugin.h"
|
|
|
|
using namespace llvm;
|
|
|
|
struct TestModulePass : public PassInfoMixin<TestModulePass> {
|
|
PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM) {
|
|
return PreservedAnalyses::all();
|
|
}
|
|
|
|
static void registerCallbacks(PassBuilder &PB) {
|
|
PB.registerPipelineParsingCallback(
|
|
[](StringRef Name, ModulePassManager &PM,
|
|
ArrayRef<PassBuilder::PipelineElement> InnerPipeline) {
|
|
if (Name == "plugin-pass") {
|
|
PM.addPass(TestModulePass());
|
|
return true;
|
|
}
|
|
return false;
|
|
});
|
|
}
|
|
};
|
|
|
|
extern "C" ::llvm::PassPluginLibraryInfo LLVM_ATTRIBUTE_WEAK
|
|
llvmGetPassPluginInfo() {
|
|
return {LLVM_PLUGIN_API_VERSION, TEST_PLUGIN_NAME, TEST_PLUGIN_VERSION,
|
|
TestModulePass::registerCallbacks};
|
|
}
|