mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 04:02:41 +01:00
fb33bc86b6
Summary: For builds with LLVM_BUILD_LLVM_DYLIB=ON and BUILD_SHARED_LIBS=OFF this change makes all symbols in the target specific libraries hidden by default. A new macro called LLVM_EXTERNAL_VISIBILITY has been added to mark symbols in these libraries public, which is mainly needed for the definitions of the LLVMInitialize* functions. This patch reduces the number of public symbols in libLLVM.so by about 25%. This should improve load times for the dynamic library and also make abi checker tools, like abidiff require less memory when analyzing libLLVM.so One side-effect of this change is that for builds with LLVM_BUILD_LLVM_DYLIB=ON and LLVM_LINK_LLVM_DYLIB=ON some unittests that access symbols that are no longer public will need to be statically linked. Before and after public symbol counts (using gcc 8.2.1, ld.bfd 2.31.1): nm before/libLLVM-9svn.so | grep ' [A-Zuvw] ' | wc -l 36221 nm after/libLLVM-9svn.so | grep ' [A-Zuvw] ' | wc -l 26278 Reviewers: chandlerc, beanz, mgorny, rnk, hans Reviewed By: rnk, hans Subscribers: merge_guards_bot, luismarques, smeenai, ldionne, lenary, s.egerton, pzheng, sameer.abuasal, MaskRay, wuzish, echristo, Jim, hiraditya, michaelplatings, chapuni, jholewinski, arsenm, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, javed.absar, sbc100, jgravelle-google, aheejin, kbarton, fedor.sergeev, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, zzheng, edward-jones, mgrang, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, PkmX, jocewei, kristina, jsji, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D54439
94 lines
2.9 KiB
CMake
94 lines
2.9 KiB
CMake
########################################################################
|
|
# Experimental CMake build script for Google Test.
|
|
#
|
|
# Consider this a prototype. It will change drastically. For now,
|
|
# this is only for people on the cutting edge.
|
|
#
|
|
# To run the tests for Google Test itself on Linux, use 'make test' or
|
|
# ctest. You can select which tests to run using 'ctest -R regex'.
|
|
# For more options, run 'ctest --help'.
|
|
########################################################################
|
|
#
|
|
# Project-wide settings
|
|
|
|
# Where gtest's .h files can be found.
|
|
include_directories(
|
|
googletest/include
|
|
googletest
|
|
googlemock/include
|
|
googlemock
|
|
)
|
|
|
|
# LLVM requires C++11 but gtest doesn't correctly detect the availability
|
|
# of C++11 on MSVC, so we force it on.
|
|
add_definitions(-DGTEST_LANG_CXX11=1)
|
|
add_definitions(-DGTEST_HAS_TR1_TUPLE=0)
|
|
|
|
if(WIN32)
|
|
add_definitions(-DGTEST_OS_WINDOWS=1)
|
|
endif()
|
|
|
|
# Google Test requires headers which need _ALL_SOURCE to build on AIX
|
|
if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
|
|
remove_definitions("-D_XOPEN_SOURCE=700")
|
|
add_definitions("-D_ALL_SOURCE")
|
|
endif()
|
|
|
|
if(SUPPORTS_VARIADIC_MACROS_FLAG)
|
|
add_definitions("-Wno-variadic-macros")
|
|
endif()
|
|
if(SUPPORTS_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS_FLAG)
|
|
add_definitions("-Wno-gnu-zero-variadic-macro-arguments")
|
|
endif()
|
|
if(CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG)
|
|
add_definitions("-Wno-covered-switch-default")
|
|
endif()
|
|
|
|
set(LLVM_REQUIRES_RTTI 1)
|
|
add_definitions( -DGTEST_HAS_RTTI=0 )
|
|
|
|
if (NOT LLVM_ENABLE_THREADS)
|
|
add_definitions( -DGTEST_HAS_PTHREAD=0 )
|
|
endif()
|
|
|
|
find_library(LLVM_PTHREAD_LIBRARY_PATH pthread)
|
|
if (LLVM_PTHREAD_LIBRARY_PATH)
|
|
list(APPEND LIBS pthread)
|
|
endif()
|
|
|
|
add_llvm_library(gtest
|
|
googletest/src/gtest-all.cc
|
|
googlemock/src/gmock-all.cc
|
|
|
|
LINK_LIBS
|
|
${LIBS}
|
|
|
|
LINK_COMPONENTS
|
|
Support # Depends on llvm::raw_ostream
|
|
|
|
# This is a library meant only for the build tree.
|
|
BUILDTREE_ONLY
|
|
)
|
|
|
|
add_subdirectory(UnitTestMain)
|
|
|
|
# When LLVM_LINK_LLVM_DYLIB is enabled, libLLVM.so is added to the interface
|
|
# link libraries for gtest and gtest_main. This means that any target, like
|
|
# unittests for example, that links against gtest will be forced to link
|
|
# against libLLVM.so. In some cases we may want to statically unittests if they
|
|
# need access to symbols that are marked private in libLLVM.so. The only
|
|
# way we can make this work is to remove libLLVM.so from the list of interface
|
|
# link libraries for gtest and then make gtest users responsible for explicitly
|
|
# adding libLLVM.so to their targets link libraries if they need it.
|
|
|
|
function (gtest_remove_dylib_from_link_interface target)
|
|
get_target_property(interface_libs ${target} INTERFACE_LINK_LIBRARIES)
|
|
if (interface_libs)
|
|
list(REMOVE_ITEM interface_libs LLVM)
|
|
set_target_properties(${target} PROPERTIES INTERFACE_LINK_LIBRARIES "${interface_libs}")
|
|
endif()
|
|
endfunction()
|
|
|
|
gtest_remove_dylib_from_link_interface(gtest)
|
|
gtest_remove_dylib_from_link_interface(gtest_main)
|