mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 20:23:11 +01:00
69b4df22e0
Summary: We hit undefined references building with ThinLTO when one source file contained explicit instantiations of a template method (weak_odr) but there were also implicit instantiations in another file (linkonce_odr), and the latter was the prevailing copy. In this case the symbol was marked hidden when the prevailing linkonce_odr copy was promoted to weak_odr. It led to unsats when the resulting shared library was linked with other code that contained a reference (expecting to be resolved due to the explicit instantiation). Add a CanAutoHide flag to the GV summary to allow the thin link to identify when all copies are eligible for auto-hiding (because they were all originally linkonce_odr global unnamed addr), and only do the auto-hide in that case. Most of the changes here are due to plumbing the new flag through the bitcode and llvm assembly, and resulting test changes. I augmented the existing auto-hide test to check for this situation. Reviewers: pcc Subscribers: mehdi_amini, inglorion, eraman, dexonsmith, arphaman, dang, llvm-commits, steven_wu, wmi Tags: #llvm Differential Revision: https://reviews.llvm.org/D59709 llvm-svn: 360466
32 lines
1.7 KiB
LLVM
32 lines
1.7 KiB
LLVM
; This test ensures that when linkonce_odr + unnamed_addr symbols promoted to
|
|
; weak symbols, it preserves the auto hide property when possible.
|
|
|
|
; RUN: opt -module-summary %s -o %t.bc
|
|
; RUN: opt -module-summary %p/Inputs/linkonce_odr_unnamed_addr.ll -o %t2.bc
|
|
; Check old LTO API
|
|
; RUN: llvm-lto -thinlto-action=thinlink -o %t3.bc %t.bc %t2.bc
|
|
; RUN: llvm-lto -thinlto-action=promote %t.bc -thinlto-index=%t3.bc -o - | llvm-dis -o - | FileCheck %s
|
|
; Check new LTO API
|
|
; RUN: llvm-lto2 run -save-temps -o %t6.bc %t.bc %t2.bc -r=%t.bc,linkonceodrunnamed,p -r=%t.bc,odrunnamed,p -r=%t2.bc,linkonceodrunnamed, -r=%t2.bc,odrunnamed,
|
|
; RUN: llvm-dis %t6.bc.1.1.promote.bc -o - | FileCheck %s
|
|
|
|
; Now test when one module does not have a summary. In that case we must be
|
|
; conservative and not auto hide.
|
|
; RUN: opt %p/Inputs/linkonce_odr_unnamed_addr.ll -o %t4.bc
|
|
; Check new LTO API (old LTO API does not detect this case).
|
|
; RUN: llvm-lto2 run -save-temps -o %t6.bc %t.bc %t4.bc -r=%t.bc,linkonceodrunnamed,p -r=%t.bc,odrunnamed,p -r=%t4.bc,linkonceodrunnamed, -r=%t4.bc,odrunnamed,
|
|
; RUN: llvm-dis %t6.bc.1.1.promote.bc -o - | FileCheck %s --check-prefix=NOSUMMARY
|
|
|
|
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-grtev4-linux-gnu"
|
|
|
|
; In this case all copies are linkonce_odr, so it may be hidden.
|
|
; CHECK: @linkonceodrunnamed = weak_odr hidden unnamed_addr constant i32 0
|
|
; NOSUMMARY: @linkonceodrunnamed = weak_odr unnamed_addr constant i32 0
|
|
@linkonceodrunnamed = linkonce_odr unnamed_addr constant i32 0
|
|
|
|
; In this case, the other copy was weak_odr, so it may not be hidden.
|
|
; CHECK: @odrunnamed = weak_odr unnamed_addr constant i32 0
|
|
; NOSUMMARY: @odrunnamed = weak_odr unnamed_addr constant i32 0
|
|
@odrunnamed = linkonce_odr unnamed_addr constant i32 0
|